docs: applying codacy suggestions (#3054)

Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>

Author: arianejasuwienas

packages/server/tests/acceptance/conformityTests.spec.ts

@@ -22,7 +22,7 @@ import {
   setTransaction1559AndBlockHash,
   setTransaction2930AndBlockHash,
 } from './data/conformity/utils/constants';
-import { TestCases, UpdateParamFunction } from './data/conformity/utils/interfaces';
+import { JsonRpcResponse, TestCases, UpdateParamFunction } from './data/conformity/utils/interfaces';
 import { processFileContent, splitReqAndRes } from './data/conformity/utils/processors';
 import {
   createContractLegacyTransaction,
@@ -42,35 +42,58 @@ let relayOpenRpcData: OpenrpcDocument;
   relayOpenRpcData = await parseOpenRPCDocument(JSON.stringify(openRpcData));
 })().catch((error) => console.error('Error parsing OpenRPC document:', error));
 
-const synthesizeTestCases = function (testCases: TestCases, updateParamIfNeeded: UpdateParamFunction) {
-  for (const testName in testCases) {
-    it(`${testName}`, async function () {
-      const isErrorStatusExpected: boolean =
-        (testCases[testName]?.status && testCases[testName].status != 200) ||
-        !!JSON.parse(testCases[testName].response).error;
-      const method = relayOpenRpcData.methods.find(
-        (m: MethodOrReference): m is MethodObject => 'name' in m && m.name === testName.split(' ')[0],
-      );
-      const schema: JSONSchemaObject | undefined =
-        method?.result && 'schema' in method.result && typeof method.result.schema === 'object'
-          ? method.result.schema
-          : undefined;
-      try {
-        const req = updateParamIfNeeded(testName, JSON.parse(testCases[testName].request));
-        const res = await sendRequestToRelay(RELAY_URL, req, false);
-        if (schema && schema.pattern) {
-          const check = isResponseValid(schema, res);
-          expect(check).to.be.true;
-        }
-        expect(isErrorStatusExpected).to.be.false;
-      } catch (e: any) {
-        expect(isErrorStatusExpected).to.be.true;
-        expect(e?.response?.status).to.equal(testCases[testName].status);
-      }
-    });
+const getBaseName = (testName: string) => testName.split(' ')[0];
+
+const findResultSchema = (testName: string): JSONSchemaObject | undefined => {
+  const method = relayOpenRpcData.methods.find(
+    (m: MethodOrReference): m is MethodObject => 'name' in m && m.name === getBaseName(testName),
+  );
+  return method?.result && 'schema' in method.result && typeof method.result.schema === 'object'
+    ? (method.result.schema as JSONSchemaObject)
+    : undefined;
+};
+
+const validateIfPattern = (schema: JSONSchemaObject | undefined, res: JsonRpcResponse) => {
+  if (schema?.pattern) {
+    const check = isResponseValid(schema, res);
+    expect(check).to.be.true;
+  }
+};
+
+const runSingleTest = async (
+  testName: string,
+  raw: TestCases[string],
+  updateParamIfNeeded: UpdateParamFunction,
+): Promise<void> => {
+  const parsedRequest = JSON.parse(raw.request);
+  const parsedResponse = JSON.parse(raw.response);
+  const hasOkStatus = raw?.status && raw.status !== 200;
+  const hasError = Boolean((parsedResponse as any)?.error);
+  if (!hasOkStatus && !hasError) {
+    const req = updateParamIfNeeded(testName, parsedRequest);
+    const res = await sendRequestToRelay(RELAY_URL, req, false);
+    const schema = findResultSchema(testName);
+    validateIfPattern(schema, res);
+    return;
+  }
+
+  try {
+    const req = updateParamIfNeeded(testName, parsedRequest);
+    await sendRequestToRelay(RELAY_URL, req, false);
+    expect.fail('Expected request to fail, but it succeeded.');
+  } catch (e: any) {
+    expect(e?.response?.status).to.equal(raw.status);
   }
 };
 
+export const synthesizeTestCases = function (testCases: TestCases, updateParamIfNeeded: UpdateParamFunction) {
+  Object.keys(testCases).forEach((testName) => {
+    it(testName, async function () {
+      await runSingleTest(testName, testCases[testName], updateParamIfNeeded);
+    });
+  });
+};
+
 /**
  * To run the Ethereum Execution API tests as defined in the repository ethereum/execution-apis, it’s necessary
  * to execute them against a specifically configured node. This node must use: