Skip to content

Commit 5236768

Browse files
test: forcing codacy to rerun checks (#3823)
Signed-off-by: Mariusz Jasuwienas <mariusz.jasuwienas@arianelabs.com>
1 parent 8473182 commit 5236768

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

packages/server/tests/acceptance/conformityTests.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ import {
3333
transaction2930,
3434
} from './data/conformity/utils/transactions';
3535
import { getLatestBlockHash, sendRequestToRelay, signAndSendRawTransaction } from './data/conformity/utils/utils';
36-
import { getMissingKeys, isResponseValid } from './data/conformity/utils/validations';
36+
import { findMissingKeys, isResponseValid } from './data/conformity/utils/validations';
3737

3838
const directoryPath = path.resolve(__dirname, '../../../../node_modules/execution-apis/tests');
3939
const overwritesDirectoryPath = path.resolve(__dirname, 'data/conformity/overwrites');
@@ -350,7 +350,7 @@ describe('@api-conformity', async function () {
350350
await new Promise((r) => setTimeout(r, 500));
351351

352352
const hasMissingKeys =
353-
getMissingKeys({
353+
findMissingKeys({
354354
actual: response,
355355
expected: JSON.parse(testCases[testName].response),
356356
wildcards: [],

packages/server/tests/acceptance/data/conformity/utils/validations.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ export function hasResponseFormatIssues(
8484
}
8585
return true;
8686
}
87-
const missingKeys = getMissingKeys({
87+
const missingKeys = findMissingKeys({
8888
actual: actualResponse as Record<string, unknown>,
8989
expected: parsedExpectedResponse,
9090
wildcards,
@@ -97,15 +97,17 @@ export function hasResponseFormatIssues(
9797
return hasValuesMismatch(actualResponse, parsedExpectedResponse, wildcards);
9898
}
9999

100-
export function getMissingKeys(response: {
100+
export function findMissingKeys(response: {
101101
actual: Record<string, unknown>;
102102
expected: Record<string, unknown>;
103103
wildcards: string[];
104104
}): string[] {
105105
const skipKeys = new Set([...extractKeys(response.actual), ...response.wildcards]);
106-
return extractKeys(response.expected).filter((key) => !skipKeys.has(key));
106+
return extractKeys(response.expected).filter(notIn(skipKeys));
107107
}
108108

109+
const notIn = (set: ReadonlySet<string>) => (k: string) => !set.has(k);
110+
109111
/**
110112
* Checks if the actual response is missing required error properties
111113
*

0 commit comments

Comments
 (0)