[coro_rpc] fix ELOG data race in coro_rpc::coro_rpc_server::stop() (alibaba#890)

poor-circle · howardlau1999 · commit f4ab6e37f326 · 2025-02-16T21:38:21.000+08:00
[coro_rpc] fix data race in coro_rpc
diff --git a/include/ylt/coro_rpc/impl/coro_rpc_server.hpp b/include/ylt/coro_rpc/impl/coro_rpc_server.hpp
@@ -205,12 +205,13 @@ class coro_rpc_server_base {
       return;
     }
 
-    ELOG_INFO << "begin to stop coro_rpc_server, conn size " << conns_.size();
+    ELOG_INFO << "begin to stop coro_rpc_server";
 
     if (flag_ == stat::started) {
       close_acceptor();
       {
         std::unique_lock lock(conns_mtx_);
+        ELOG_INFO << "total connection count: " << conns_.size();
         for (auto &conn : conns_) {
           if (!conn.second->has_closed()) {
             conn.second->async_close();

Original file line number	Diff line number	Diff line change
`@@ -205,12 +205,13 @@ class coro_rpc_server_base {`
`205`	`205`	`return;`
`206`	`206`	`}`
`207`	`207`
`208`		`- ELOG_INFO << "begin to stop coro_rpc_server, conn size " << conns_.size();`
	`208`	`+ ELOG_INFO << "begin to stop coro_rpc_server";`
`209`	`209`
`210`	`210`	`if (flag_ == stat::started) {`
`211`	`211`	`close_acceptor();`
`212`	`212`	`{`
`213`	`213`	`std::unique_lock lock(conns_mtx_);`
	`214`	`+ ELOG_INFO << "total connection count: " << conns_.size();`
`214`	`215`	`for (auto &conn : conns_) {`
`215`	`216`	`if (!conn.second->has_closed()) {`
`216`	`217`	`conn.second->async_close();`