Code coverage

Author: bitwiseman

src/main/java/org/kohsuke/github/GHCommentAuthorAssociation.java

@@ -38,5 +38,9 @@ public enum GHCommentAuthorAssociation {
     /**
      * Author is the owner of the repository.
      */
-    OWNER
+    OWNER,
+    /**
+     * Author association is not recognized.
+     */
+    UNKNOWN
 }

src/main/java/org/kohsuke/github/GHIssueComment.java

@@ -24,6 +24,7 @@
 package org.kohsuke.github;
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import org.kohsuke.github.internal.EnumUtils;
 
 import java.io.IOException;
 import java.net.URL;
@@ -107,7 +108,9 @@ public URL getHtmlUrl() {
      * @return the author association
      */
     public GHCommentAuthorAssociation getAuthorAssociation() {
-        return GHCommentAuthorAssociation.valueOf(authorAssociation);
+        return EnumUtils.getEnumOrDefault(GHCommentAuthorAssociation.class,
+                authorAssociation,
+                GHCommentAuthorAssociation.UNKNOWN);
     }
 
     /**

src/main/java/org/kohsuke/github/GHPullRequestCommitDetail.java

@@ -121,7 +121,7 @@ public Commit() {
         String url;
 
         /** The comment count. */
-        int commentCount;
+        Integer commentCount;
 
         /**
          * Gets author.
@@ -175,7 +175,7 @@ public int getComment_count() {
          *
          * @return the comment count
          */
-        public int getCommentCount() {
+        public Integer getCommentCount() {
             return commentCount;
         }
 

src/test/java/org/kohsuke/github/AppTest.java

@@ -1419,6 +1419,7 @@ public void testIssueSearch() {
             PagedIterable<GHIssueComment> comments = issue.listComments();
             for (GHIssueComment comment : comments) {
                 assertThat(comment, notNullValue());
+
             }
         }
     }

src/test/java/org/kohsuke/github/EnumTest.java

@@ -27,7 +27,7 @@ public void touchEnums() {
         assertThat(GHCheckRun.Conclusion.values().length, equalTo(9));
         assertThat(GHCheckRun.Status.values().length, equalTo(4));
 
-        assertThat(GHCommentAuthorAssociation.values().length, equalTo(8));
+        assertThat(GHCommentAuthorAssociation.values().length, equalTo(9));
 
         assertThat(GHCommitSearchBuilder.Sort.values().length, equalTo(2));
 

src/test/java/org/kohsuke/github/GHEventPayloadTest.java

@@ -195,6 +195,8 @@ public void issue_comment() throws Exception {
         assertThat(event.getIssue().getLabels().iterator().next().getName(), is("bug"));
         assertThat(event.getComment().getUser().getLogin(), is("baxterthehacker"));
         assertThat(event.getComment().getBody(), is("You are totally right! I'll get this fixed right away."));
+        assertThat(event.getComment().getAuthorAssociation(), equalTo(GHCommentAuthorAssociation.UNKNOWN));
+        assertThat(event.getComment().getBody(), is("You are totally right! I'll get this fixed right away."));
         assertThat(event.getRepository().getName(), is("public-repo"));
         assertThat(event.getRepository().getOwner().getLogin(), is("baxterthehacker"));
         assertThat(event.getSender().getLogin(), is("baxterthehacker"));

src/test/java/org/kohsuke/github/GHGistTest.java

@@ -168,5 +168,10 @@ public void gistFile() throws Exception {
         assertThat(f.getType(), equalTo("text/markdown"));
         assertThat(f.getLanguage(), equalTo("Markdown"));
         assertThat(f.getContent(), containsString("### Keybase proof"));
+        assertThat(f.getRawUrl().toString(),
+                equalTo("https://gist.githubusercontent.com/rtyler/9903708/raw/2b68396d836af8c5b6ba905f27c4baf94ceb0ed3/keybase.md"));
+        assertThat(f.getFileName(), equalTo("keybase.md"));
+        assertThat(f.getSize(), equalTo(2131));
+        assertThat(f.isTruncated(), equalTo(false));
     }
 }

src/test/java/org/kohsuke/github/GHIssueTest.java

@@ -92,6 +92,7 @@ public void issueComment() throws Exception {
         comments = issue.listComments().toList();
         assertThat(comments, hasSize(1));
         assertThat(comments, contains(hasProperty("body", equalTo("First comment"))));
+        assertThat(comments.get(0).getAuthorAssociation(), equalTo(GHCommentAuthorAssociation.NONE));
 
         comments = issue.queryComments().list().toList();
         assertThat(comments, hasSize(1));

src/test/java/org/kohsuke/github/GHProjectTest.java

@@ -47,6 +47,8 @@ public void testCreatedProject() {
         assertThat(project.getState(), equalTo(GHProject.ProjectState.OPEN));
         assertThat(project.getHtmlUrl().toString(), containsString("/orgs/hub4j-test-org/projects/"));
         assertThat(project.getUrl().toString(), containsString("/projects/"));
+        assertThat(project.getOwnerUrl().toString(), endsWith("/orgs/hub4j-test-org"));
+
     }
 
     /**

src/test/java/org/kohsuke/github/GHPullRequestTest.java

@@ -127,6 +127,7 @@ public void createDraftPullRequest() throws Exception {
     public void pullRequestComment() throws Exception {
         String name = "createPullRequestComment";
         GHPullRequest p = getRepository().createPullRequest(name, "test/stable", "main", "## test");
+        assertThat(p.getIssueUrl().toString(), endsWith("/repos/hub4j-test-org/github-api/issues/461"));
 
         List<GHIssueComment> comments;
         comments = p.listComments().toList();
@@ -226,9 +227,18 @@ public void getListOfCommits() throws Exception {
 
             GHPullRequestCommitDetail.Commit commit = detail.getCommit();
             assertThat(commit, notNullValue());
+            assertThat(commit.getAuthor().getEmail(), equalTo("bitwiseman@gmail.com"));
+            assertThat(commit.getCommitter().getEmail(), equalTo("bitwiseman@gmail.com"));
+            assertThat(commit.getMessage(), equalTo("Update README"));
+            assertThat(commit.getUrl().toString(),
+                    endsWith("/repos/hub4j-test-org/github-api/git/commits/2d29c787b46ce61b98a1c13e05e21ebc21f49dbf"));
+            assertThat(commit.getComment_count(), equalTo(0));
 
             GHPullRequestCommitDetail.Tree tree = commit.getTree();
             assertThat(tree, notNullValue());
+            assertThat(tree.getSha(), equalTo("ce7a1ba95aba901cf08d9f8365410d290d6c23aa"));
+            assertThat(tree.getUrl().toString(),
+                    endsWith("/repos/hub4j-test-org/github-api/git/trees/ce7a1ba95aba901cf08d9f8365410d290d6c23aa"));
 
             GHPullRequestCommitDetail.CommitPointer[] parents = detail.getParents();
             assertThat(parents, notNullValue());

src/test/java/org/kohsuke/github/GHRepositoryTest.java

@@ -643,6 +643,9 @@ public void addCollaborators() throws Exception {
 
         GHPersonSet<GHUser> collabs = repo.getCollaborators();
         GHUser colabUser = collabs.byLogin("jimmysombrero");
+        assertThat(colabUser.getAvatarUrl(), equalTo("https://avatars3.githubusercontent.com/u/12157727?v=4"));
+        assertThat(colabUser.getHtmlUrl().toString(), equalTo("https://github.com/jimmysombrero"));
+        assertThat(colabUser.getLocation(), nullValue());
 
         assertThat(user.getName(), equalTo(colabUser.getName()));
     }

src/test/java/org/kohsuke/github/GitHubTest.java

@@ -164,6 +164,10 @@ public void searchContent() throws Exception {
                 .order(GHDirection.DESC)
                 .list();
         GHContent c = r.iterator().next();
+        assertThat(c.getGitUrl(), endsWith("/repositories/167174/git/blobs/796fbcc808ca15bbe771f8c9c1a7bab3388f6128"));
+        assertThat(c.getHtmlUrl(),
+                endsWith(
+                        "https://github.com/jquery/jquery/blob/a684e6ba836f7c553968d7d026ed7941e1a612d8/src/attributes/classes.js"));
 
         // System.out.println(c.getName());
         assertThat(c.getDownloadUrl(), notNullValue());