Skip to content

Commit 37be904

Browse files
authored
Update src/test/java/org/kohsuke/github/ArchTests.java
1 parent e74755e commit 37be904

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

src/test/java/org/kohsuke/github/ArchTests.java

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -111,15 +111,14 @@ public void testRequireFollowingNamingConvention() {
111111
nameMatching("[A-Z0-9\\_]+"),
112112
// currently failing cases
113113
// TODO: 2025-03-28 Fix & remove these
114-
declaredIn(PagedIterable.class).and(name("_iterator")).and(rawReturnType(PagedIterator.class)),
115-
declaredIn(GHRepositoryBuilder.class).and(name("private_")).and(rawReturnType(Object.class)),
116-
declaredIn(GHDeployKey.class).and(name("getAdded_by")).and(rawReturnType(String.class)),
117-
declaredIn(GHDeployKey.class).and(name("isRead_only")).and(rawReturnType(boolean.class)),
118-
declaredIn(Creator.class).and(name("private_")).and(rawReturnType(Creator.class)),
119-
declaredIn(GHGistBuilder.class).and(name("public_")).and(rawReturnType(GHGistBuilder.class)),
120-
declaredIn(Commit.class).and(name("getComment_count")).and(rawReturnType(int.class)),
121-
declaredIn(CommitPointer.class).and(name("getHtml_url")).and(rawReturnType(URL.class)),
122-
declaredIn(GHRelease.class).and(name("getPublished_at")).and(rawReturnType(Instant.class))))
114+
declaredIn(PagedIterable.class).and(name("_iterator")),
115+
declaredIn(GHDeployKey.class).and(name("getAdded_by")),
116+
declaredIn(GHDeployKey.class).and(name("isRead_only")),
117+
declaredIn(Creator.class).and(name("private_")),
118+
declaredIn(GHGistBuilder.class).and(name("public_")),
119+
declaredIn(Commit.class).and(name("getComment_count")),
120+
declaredIn(CommitPointer.class).and(name("getHtml_url")),
121+
declaredIn(GHRelease.class).and(name("getPublished_at"))
123122
.because(reason);
124123

125124
final ArchRule classesNotFollowingConvention = noClasses().should(haveNamesContainingUnless("_"))

0 commit comments

Comments
 (0)