refactor: Rename exception handling methods to better reflect intent

Author: mestebangutierrez

src/main/java/org/kohsuke/github/EnterpriseManagedSupport.java

@@ -8,7 +8,7 @@
 import java.util.logging.Logger;
 
 /**
- * Utility class for helping with operation for enterprise managed resources.
+ * Utility class for helping with operations for enterprise managed resources.
  *
  * @author Miguel Esteban Gutiérrez
  */
@@ -26,7 +26,7 @@ private EnterpriseManagedSupport(GHOrganization organization) {
         this.organization = organization;
     }
 
-    Optional<GHIOException> handleException(final HttpException he, final String scenario) {
+    Optional<GHIOException> filterException(final HttpException he, final String scenario) {
         if (he.getResponseCode() == 400) {
             final String responseMessage = he.getMessage();
             try {
@@ -46,10 +46,10 @@ Optional<GHIOException> handleException(final HttpException he, final String sce
         return Optional.empty();
     }
 
-    Optional<GHException> handleException(final GHException e) {
+    Optional<GHException> filterException(final GHException e) {
         if (e.getCause() instanceof HttpException) {
             final HttpException he = (HttpException) e.getCause();
-            return handleException(he, COULD_NOT_RETRIEVE_ORGANIZATION_EXTERNAL_GROUPS)
+            return filterException(he, COULD_NOT_RETRIEVE_ORGANIZATION_EXTERNAL_GROUPS)
                     .map(translated -> new GHException(COULD_NOT_RETRIEVE_ORGANIZATION_EXTERNAL_GROUPS, translated));
         }
         return Optional.empty();

src/main/java/org/kohsuke/github/GHExternalGroupIterable.java

@@ -60,7 +60,7 @@ public boolean hasNext() {
                 try {
                     return base.hasNext();
                 } catch (final GHException e) {
-                    throw EnterpriseManagedSupport.forOrganization(owner).handleException(e).orElse(e);
+                    throw EnterpriseManagedSupport.forOrganization(owner).filterException(e).orElse(e);
                 }
             }
 

src/main/java/org/kohsuke/github/GHOrganization.java

@@ -240,7 +240,7 @@ public GHExternalGroup getExternalGroup(final long groupId) throws IOException {
                     .wrapUp(this);
         } catch (final HttpException e) {
             throw EnterpriseManagedSupport.forOrganization(this)
-                    .handleException(e, "Could not retrieve organization external group")
+                    .filterException(e, "Could not retrieve organization external group")
                     .orElse(e);
         }
     }

src/main/java/org/kohsuke/github/GHTeam.java

@@ -448,7 +448,7 @@ public List<GHExternalGroup> getExternalGroups() throws IOException {
                     .getGroups();
         } catch (final HttpException e) {
             throw EnterpriseManagedSupport.forOrganization(getOrganization())
-                    .handleException(e, "Could not retrieve team external groups")
+                    .filterException(e, "Could not retrieve team external groups")
                     .orElse(e);
         }
     }
@@ -489,7 +489,7 @@ public GHExternalGroup connectToExternalGroup(final long group_id) throws IOExce
                     .wrapUp(getOrganization());
         } catch (final HttpException e) {
             throw EnterpriseManagedSupport.forOrganization(getOrganization())
-                    .handleException(e, "Could not connect team to external group")
+                    .filterException(e, "Could not connect team to external group")
                     .orElse(e);
         }
     }

src/test/java/org/kohsuke/github/EnterpriseManagedSupportTest.java

@@ -37,7 +37,7 @@ public void testIgnoreNonHttpException() throws IOException {
         final GHException inputException = new GHException("Test", inputCause);
 
         final Optional<GHException> maybeException = EnterpriseManagedSupport.forOrganization(org)
-                .handleException(inputException);
+                .filterException(inputException);
 
         assertThat(maybeException.isPresent(), is(false));
     }
@@ -59,7 +59,7 @@ public void testIgnoreNonBadRequestExceptions() throws IOException {
         final GHException inputException = new GHException("Test", inputCause);
 
         final Optional<GHException> maybeException = EnterpriseManagedSupport.forOrganization(org)
-                .handleException(inputException);
+                .filterException(inputException);
 
         assertThat(maybeException.isPresent(), is(false));
     }
@@ -78,7 +78,7 @@ public void testIgnoreBadRequestsWithUnparseableJson() throws IOException {
         final GHException inputException = new GHException("Test", inputCause);
 
         final Optional<GHException> maybeException = EnterpriseManagedSupport.forOrganization(org)
-                .handleException(inputException);
+                .filterException(inputException);
 
         assertThat(maybeException.isPresent(), is(false));
     }
@@ -97,7 +97,7 @@ public void testIgnoreBadRequestsWithUnknownErrorMessage() throws IOException {
         final GHException inputException = new GHException("Test", inputCause);
 
         final Optional<GHException> maybeException = EnterpriseManagedSupport.forOrganization(org)
-                .handleException(inputException);
+                .filterException(inputException);
 
         assertThat(maybeException.isPresent(), is(false));
     }
@@ -119,7 +119,7 @@ public void testHandleEmbeddedNotPartOfExternallyManagedEnterpriseHttpException(
         final GHException inputException = new GHException("Test", inputCause);
 
         final Optional<GHException> maybeException = EnterpriseManagedSupport.forOrganization(org)
-                .handleException(inputException);
+                .filterException(inputException);
 
         assertThat(maybeException.isPresent(), is(true));
 
@@ -162,7 +162,7 @@ public void testHandleTeamCannotBeExternallyManagedHttpException() throws IOExce
                 org.getUrl().toString());
 
         final Optional<GHIOException> maybeException = EnterpriseManagedSupport.forOrganization(org)
-                .handleException(inputException, "Scenario");
+                .filterException(inputException, "Scenario");
 
         assertThat(maybeException.isPresent(), is(true));