Skip to content

Commit e7f3cc8

Browse files
committed
ops wrong order
1 parent 3dff8f1 commit e7f3cc8

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/transformers/models/gemma3n/modeling_gemma3n.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1355,10 +1355,10 @@ def forward(
13551355
"cache_position": cache_position,
13561356
"sliding_window": self.sliding_window,
13571357
}
1358-
key_states, value_states = past_key_values.update(key_states, value_states, self.layer_idx, cache_kwargs)
13591358
if self.store_full_length_kv:
13601359
past_key_values.layers[self.layer_idx].keys_to_share = key_states
13611360
past_key_values.layers[self.layer_idx].values_to_share = value_states
1361+
key_states, value_states = past_key_values.update(key_states, value_states, self.layer_idx, cache_kwargs)
13621362

13631363
attention_interface: Callable = eager_attention_forward
13641364
if self.config._attn_implementation != "eager":

src/transformers/models/gemma3n/modular_gemma3n.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1806,10 +1806,10 @@ def forward(
18061806
"cache_position": cache_position,
18071807
"sliding_window": self.sliding_window,
18081808
}
1809-
key_states, value_states = past_key_values.update(key_states, value_states, self.layer_idx, cache_kwargs)
18101809
if self.store_full_length_kv:
18111810
past_key_values.layers[self.layer_idx].keys_to_share = key_states
18121811
past_key_values.layers[self.layer_idx].values_to_share = value_states
1812+
key_states, value_states = past_key_values.update(key_states, value_states, self.layer_idx, cache_kwargs)
18131813

18141814
attention_interface: Callable = eager_attention_forward
18151815
if self.config._attn_implementation != "eager":

0 commit comments

Comments
 (0)