From 26fe1b3f35419fdc14932dfbda6bb39e4bdb9b34 Mon Sep 17 00:00:00 2001 From: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com> Date: Wed, 15 Oct 2025 11:34:17 +0200 Subject: [PATCH 1/3] Pass original dict instead of copy to maybe_load_adapters --- src/transformers/integrations/peft.py | 2 +- src/transformers/modeling_utils.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/transformers/integrations/peft.py b/src/transformers/integrations/peft.py index 3198cff77146..4b2274191bcb 100644 --- a/src/transformers/integrations/peft.py +++ b/src/transformers/integrations/peft.py @@ -625,7 +625,7 @@ def old_delete_adapter(model, adapter_name, prefix=None): def maybe_load_adapters( pretrained_model_name_or_path, download_kwargs: DownloadKwargs, - **adapter_kwargs, + adapter_kwargs: dict[str, Any], ): if pretrained_model_name_or_path is None or not is_peft_available(): return None, pretrained_model_name_or_path diff --git a/src/transformers/modeling_utils.py b/src/transformers/modeling_utils.py index 80727de16c7d..dd1c56543c65 100644 --- a/src/transformers/modeling_utils.py +++ b/src/transformers/modeling_utils.py @@ -4383,7 +4383,7 @@ def from_pretrained( _adapter_model_path, pretrained_model_name_or_path = maybe_load_adapters( pretrained_model_name_or_path, download_kwargs_with_commit, - **adapter_kwargs, + adapter_kwargs, ) device_map = check_and_set_device_map(device_map) # warn, error and fix the device map From c620187bbba9778af17ab7c099f307e656f01406 Mon Sep 17 00:00:00 2001 From: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com> Date: Sun, 19 Oct 2025 07:43:11 +0200 Subject: [PATCH 2/3] Revert "Pass original dict instead of copy to maybe_load_adapters" This reverts commit 26fe1b3f35419fdc14932dfbda6bb39e4bdb9b34. --- src/transformers/integrations/peft.py | 2 +- src/transformers/modeling_utils.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/transformers/integrations/peft.py b/src/transformers/integrations/peft.py index 4b2274191bcb..3198cff77146 100644 --- a/src/transformers/integrations/peft.py +++ b/src/transformers/integrations/peft.py @@ -625,7 +625,7 @@ def old_delete_adapter(model, adapter_name, prefix=None): def maybe_load_adapters( pretrained_model_name_or_path, download_kwargs: DownloadKwargs, - adapter_kwargs: dict[str, Any], + **adapter_kwargs, ): if pretrained_model_name_or_path is None or not is_peft_available(): return None, pretrained_model_name_or_path diff --git a/src/transformers/modeling_utils.py b/src/transformers/modeling_utils.py index 7a76c1a39338..ec3a93190cc7 100644 --- a/src/transformers/modeling_utils.py +++ b/src/transformers/modeling_utils.py @@ -4384,7 +4384,7 @@ def from_pretrained( _adapter_model_path, pretrained_model_name_or_path = maybe_load_adapters( pretrained_model_name_or_path, download_kwargs_with_commit, - adapter_kwargs, + **adapter_kwargs, ) device_map = check_and_set_device_map(device_map) # warn, error and fix the device map From 601fb29aeaf1876f8a20bf0eac9354a34a9d0cc3 Mon Sep 17 00:00:00 2001 From: Albert Villanova del Moral <8515462+albertvillanova@users.noreply.github.com> Date: Sun, 19 Oct 2025 07:47:13 +0200 Subject: [PATCH 3/3] Return cleaned version of adapter_kwargs --- src/transformers/integrations/peft.py | 4 ++-- src/transformers/modeling_utils.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/transformers/integrations/peft.py b/src/transformers/integrations/peft.py index 3198cff77146..d8cf4252060d 100644 --- a/src/transformers/integrations/peft.py +++ b/src/transformers/integrations/peft.py @@ -628,7 +628,7 @@ def maybe_load_adapters( **adapter_kwargs, ): if pretrained_model_name_or_path is None or not is_peft_available(): - return None, pretrained_model_name_or_path + return None, pretrained_model_name_or_path, adapter_kwargs token = download_kwargs.get("token") @@ -670,4 +670,4 @@ def maybe_load_adapters( _adapter_model_path = pretrained_model_name_or_path pretrained_model_name_or_path = json.load(f)["base_model_name_or_path"] - return _adapter_model_path, pretrained_model_name_or_path + return _adapter_model_path, pretrained_model_name_or_path, adapter_kwargs diff --git a/src/transformers/modeling_utils.py b/src/transformers/modeling_utils.py index ec3a93190cc7..a62856865cb0 100644 --- a/src/transformers/modeling_utils.py +++ b/src/transformers/modeling_utils.py @@ -4381,7 +4381,7 @@ def from_pretrained( if adapter_kwargs is None: adapter_kwargs = {} - _adapter_model_path, pretrained_model_name_or_path = maybe_load_adapters( + _adapter_model_path, pretrained_model_name_or_path, adapter_kwargs = maybe_load_adapters( pretrained_model_name_or_path, download_kwargs_with_commit, **adapter_kwargs,