Merge branch 'master' into fix-multiple-arguments

Author: mikeselander

CHANGELOG.md

@@ -0,0 +1,95 @@
+## Unreleased (0.6.0)
+
+### Summation:
+- Updated PHPCS to v3.4 #88
+- Updated WPCS to 1.2.0 #82
+- Updated eslint to 5.10 and associated deps #101
+
+### Added:
+- Stylelint configuration #45
+- Added VIP PHPCS standards dependency #122
+
+### Changed:
+- Use ecmaversion 2018 #87
+- Require space in curly braces for React JSX children #121
+- Allow multiple declaration in use statement #78
+- Exclude the `tests` dir from the NamespaceExclusionTest #112
+- Set composer library type to `phpcodesniffer-standard` #116 
+
+### Removed:
+- Allow `trigger_error` #98
+- Remove assignment of equals rule #96
+- Remove `href-no-hash` rule exclusion #114
+
+<details>
+    <summary>PHPCS Core Rule Additions</summary>
+    
+    https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/releases
+    * Added new Generic.CodeAnalysis.EmptyPHPStatement sniff
+        * Warns when it finds empty PHP open/close tag combinations or superfluous semicolons
+    * Added new Generic.Formatting.SpaceBeforeCast sniff
+        * Ensures there is exactly 1 space before a type cast, unless the cast statement is indented or multi-line
+    * Added new Generic.VersionControl.GitMergeConflict sniff
+        * Detects merge conflict artifacts left in files
+    * Added Generic.WhiteSpace.IncrementDecrementSpacing sniff
+        * Ensures there is no space between the operator and the variable it applies to
+    * Added PSR12.Functions.NullableTypeDeclaration sniff
+        * Ensures there is no space after the question mark in a nullable type declaration
+    * Added new Generic.PHP.LowerCaseType sniff
-Ensures PHP types used for type hints, return types, and type casting are lowercase
+    * Added new Generic.WhiteSpace.ArbitraryParenthesesSpacing sniff
+        * Generates an error for whitespace inside parenthesis that don't belong to a function call/declaration or control structure
+        * Generates a warning for any empty parenthesis found
+        * Allows the required spacing to be set using the spacing sniff property (default is 0)
+        * Allows newlines to be used by setting the ignoreNewlines sniff property (default is false)
+    * Added new PSR12.Classes.ClassInstantiation sniff
+        * Ensures parenthesis are used when instantiating a new class
+    * Added new PSR12.Keywords.ShortFormTypeKeywords sniff
+        * Ensures the short form of PHP types is used when type casting
+    * Added new PSR12.Namespaces.CompundNamespaceDepth sniff
+        * Ensures compound namespace use statements have a max depth of 2 levels
The max depth can be changed by setting the 'maxDepth' sniff property in a ruleset.xml file
+    * Added new PSR12.Operators.OperatorSpacing sniff
-Ensures operators are preceded and followed by at least 1 space
+</details> 
+
+## 0.5.0 (May 22, 2018)
+
+- Update ESLint config peer dependencies #65
+- Add ESLint config test script with example fixtures #42
+
+## 0.4.2 (May 1, 2018)
+
+- Remove support for ESLint-via-phpcs #54
+- Ignore array item alignment rule #49
+- Ignore line length when checking array alignment #57
+- Adjust object rules for destructuring #59
+
+## 0.4.1 (Apr 18, 2018)
+
+- Fix order error for closure `use` #53
+- Fix false positives for `T_USE` #12
+
+## 0.4.0 (Apr 17, 2018)
+
+- Always allow spaces inside arrays #3
+- Only run PHPCS on PHP files #36
+- Enforce spaces inside jsx curly braces #38
+- Make index pass its own rules #41
+- Add support for a .phpcsignore file #39
+- Add Sniff for unused "use" statements #44
+- Exclude filesystem groups from checks #50
+- Allow inline statements to drop semicolons #51
+
+## 0.3.0 (Jan 18, 2018)
+
+- Update license for new requirements #34
+- Add tests for our phpcs sniffs #32
+- Update phpcs to v3 #31
+
+## 0.2.2 (Nov 6, 2017)
+
+## 0.2.1 (Dec 8, 2016)
+
+## 0.2.0 (Dec 8, 2016)
+
+## 0.1.0 (Dec 7, 2016)
+
+- Initial Release

CONTRIBUTING.md

@@ -0,0 +1,35 @@
+# Contributing
+
+The HM coding standards represent the best practices for enabling our engineering teams to work together. As the way we work evolves over time, our coding standards likewise need to evolve.
+
+
+## Guidelines for Rule Changes
+
+Bugfixes are always welcomed and can be released in minor or patch versions.
+
+New rules or major changes to rules need to be carefully considered and balanced against the churn they may cause. Generally, code that exists right now should continue to pass in the future unless we are **intentionally** ratcheting up rules to be stricter. These cases need to be carefully considered, as breaking production code should be avoided in most cases.
+
+Relaxing rules can be done in minor releases, but generally should be done in major releases if it's a major change (for example, allowing different file names). Use your best judgement to decide what is a major and what is a minor change, and if in doubt, run it past @joehoyle or @rmccue.
+
+Generally, so long as changes to rules have consensus, they are fine to be published. Any controversial rules should be widely discussed, and if a tie-breaker is needed, @joehoyle can make a final call. If you're not sure, ask @rmccue. Non-controversial changes or bugfixes do not need input from @joehoyle or @rmccue provided versioning and release processes are all followed.
+
+
+## Releasing
+
+Any changes which cause existing, working production code to fail should trigger a new major release. Only bugfixes or making rules more lenient should be in minor releases.
+
+When publishing major releases, these need to be published in a two-step process. First, publish the standards, then bump the defaults after some time. This gives projects time to assess the changes and migrate at their own pace. The time between the publish and the default bump depends on the size and scope of the major changes, but generally should be 2-4 sprints worth of time for major changes.
+
+The process for releasing is:
+
+* Ensure your working directory is clean and up-to-date on `master`
+* Run `yarn publish` and enter the tag number
+	* This publishes to npm, commits the version change, and creates a corresponding git tag
+* Push the version bump commit to `master`: `git push`
+* Push the new tag: `git push --tags`
+	* This triggers Packagist to release the new version
+* Run `./publish.sh` to push the standards for hm-linter
+	* This will ask if you want to bump the latest version to the new version. Only do this for minor releases.
+* For major releases, publish a changelog to the Dev H2 (significant bugfixes may also warrant a post)
+
+If you're releasing a major version, you should also create a branch for the major version so that bugfix releases can be created. This branch should be a humanised name of the version; e.g. 0.4 would be `oh-dot-four`, 1.6 would be `one-dot-six`.

composer.json

@@ -6,6 +6,7 @@
 	"require": {
 		"php": ">=7.1",
 		"wp-coding-standards/wpcs": "1.2.1",
+		"automattic/vipwpcs": "^0.4.0",
 		"fig-r/psr2r-sniffer": "^0.5.0",
 		"squizlabs/php_codesniffer": "~3.4.0",
 		"dealerdirect/phpcodesniffer-composer-installer": "^0.5.0"

packages/eslint-config-humanmade/index.js

@@ -94,7 +94,10 @@ module.exports = {
 			},
 		} ],
 		'yoda': [ 'error', 'never' ],
-		'react/jsx-curly-spacing': [ 'error', 'always' ],
+		'react/jsx-curly-spacing': [ 'error', {
+			'when': 'always',
+			'children': true,
+		} ],
 		'react/jsx-wrap-multilines': [ 'error' ],
 		'jsx-a11y/anchor-is-valid': [ 'error' ],
 	},

packages/eslint-config-humanmade/readme.md

@@ -2,8 +2,6 @@
 
 Human Made coding standards for JavaScript.
 
-We highly recommend using this [via the `humanmade/coding-standards` Composer package.](https://github.com/humanmade/coding-standards).
-
 ## Installation
 
 This package is an ESLint shareable configuration, and requires `babel-eslint`, `eslint`, `eslint-config-react-app`, `eslint-plugin-flowtype`, `eslint-plugin-import`, `eslint-plugin-jsx-a11y`, `eslint-plugin-react`.

packages/stylelint-config-humanmade/readme.md

@@ -2,8 +2,6 @@
 
 Human Made coding standards for CSS and SCSS.
 
-We highly recommend using this [via the `humanmade/coding-standards` Composer package.](https://github.com/humanmade/coding-standards).
-
 ## Installation
 
 This package is a Stylelint shareable configuration, and requires the `stylelint` library.