Skip to content

Update hypercert evaluations #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update hypercert evaluations #8

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c058057
add measurements and location fields in hypercertEvaluation
s-adamantine Nov 6, 2025
8f356a3
add hypercert in there
s-adamantine Nov 10, 2025
a34e0ae
merge main to hypercertEvidence
s-adamantine Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions hypercertEvaluation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,26 @@
},
"maxLength": 100
},
"measurements": {
"type": "array",
"description": "Optional references to the measurements that contributed to this evaluation. The record(s) referenced must conform with the lexicon org.hypercerts.claim.measurement ",
Copy link
Member

@holkexyz holkexyz Nov 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Let's allow to reference measurements or evidence here. Would it be helpful to have that separate or in the same array?

Copy link
Contributor

@aspiers aspiers Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh I'm still not super clear on the differences between measurements and evidence, so I'm not sure what the best answer is yet. Pretty sure I've heard you explain it but can't remember the details 🙈 Maybe there are some improvements we can make in the lexicons to help clarify the distinction.

"items": {
"type": "ref",
"refs": "com.atproto.repo.strongRef"
},
"maxLength": 100
},
"summary": {
"type": "string",
"description": "Brief evaluation summary",
"maxLength": 5000,
"maxGraphemes": 1000
},
"location": {
"type": "ref",
"ref": "com.atproto.repo.strongRef",
"description": "An optional reference for georeferenced evaluations. The record referenced must conform with the lexicon app.certified.location."
},
"createdAt": {
"type": "string",
"format": "datetime",
Expand Down