From a80616b4478dd72dc9bbc5dc3746affcc8143c21 Mon Sep 17 00:00:00 2001 From: lovesh harchandani Date: Mon, 18 Feb 2019 12:20:57 +0530 Subject: [PATCH] fix documentation and variable names Signed-off-by: lovesh harchandani --- libindy-crypto/tests/cl.rs | 144 ++++++++++++++++++------------------- 1 file changed, 72 insertions(+), 72 deletions(-) diff --git a/libindy-crypto/tests/cl.rs b/libindy-crypto/tests/cl.rs index 30f185d..458bc7f 100644 --- a/libindy-crypto/tests/cl.rs +++ b/libindy-crypto/tests/cl.rs @@ -50,7 +50,7 @@ mod test { let gvt_simple_tail_accessor = SimpleTailsAccessor::new(&mut gvt_rev_tails_generator).unwrap(); - // 5. Issuer creates nonce used Prover to blind master secret + // 5. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let gvt_credential_nonce = new_nonce().unwrap(); // 6. Issuer creates GVT credential values @@ -69,7 +69,7 @@ mod test { &gvt_credential_values, &gvt_credential_nonce).unwrap(); - // 8. Prover creates nonce used Issuer to credential issue + // 8. Prover creates nonce used by Issuer to create correctness proof for signature let gvt_credential_issuance_nonce = new_nonce().unwrap(); // 9. Issuer signs GVT credential values @@ -127,7 +127,7 @@ mod test { let xyz_simple_tail_accessor = SimpleTailsAccessor::new(&mut xyz_rev_tails_generator).unwrap(); - // 15. Issuer creates nonce used Prover to blind master secret + // 15. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let xyz_credential_nonce = new_nonce().unwrap(); // 16. Issuer creates XYZ credential values @@ -144,7 +144,7 @@ mod test { &xyz_credential_values, &xyz_credential_nonce).unwrap(); - // 18. Prover creates nonce used Issuer to credential issue + // 18. Prover creates nonce used by Issuer to create correctness proof for signature let xyz_credential_issuance_nonce = new_nonce().unwrap(); // 19. Issuer signs XYZ credential values @@ -258,7 +258,7 @@ mod test { // 3. Issuer creates credential values let credential_values = helpers::gvt_credential_values(&Prover::new_master_secret().unwrap()); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 5. Prover blinds hidden attributes @@ -268,7 +268,7 @@ mod test { &credential_values, &credential_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); @@ -343,18 +343,18 @@ mod test { // 4. Issuer creates and sign credential values let credential_values = helpers::gvt_credential_values(&Prover::new_master_secret().unwrap()); - // 5. Issuer creates nonce used Prover to blind master secret - let credential_nonce = new_nonce().unwrap(); + // 5. Issuer creates nonce used by Prover to create correctness proof for blinded secrets + let blinding_correctness_nonce = new_nonce().unwrap(); // 6. Prover blinds hidden attributes let (blinded_credential_secrets, credential_secrets_blinding_factors, blinded_credential_secrets_correctness_proof) = Prover::blind_credential_secrets(&credential_pub_key, &credential_key_correctness_proof, &credential_values, - &credential_nonce).unwrap(); + &blinding_correctness_nonce).unwrap(); - // 7. Prover creates nonce used Issuer to credential issue - let credential_issuance_nonce = new_nonce().unwrap(); + // 7. Prover creates nonce used by Issuer to create correctness proof for signature + let signature_correctness_nonce = new_nonce().unwrap(); let rev_idx = 1; @@ -362,8 +362,8 @@ mod test { Issuer::sign_credential_with_revoc(PROVER_ID, &blinded_credential_secrets, &blinded_credential_secrets_correctness_proof, - &credential_nonce, - &credential_issuance_nonce, + &blinding_correctness_nonce, + &signature_correctness_nonce, &credential_values, &credential_pub_key, &credential_priv_key, @@ -387,7 +387,7 @@ mod test { &signature_correctness_proof, &credential_secrets_blinding_factors, &credential_pub_key, - &credential_issuance_nonce, + &signature_correctness_nonce, Some(&rev_key_pub), Some(&rev_reg), Some(&witness)).unwrap(); @@ -445,18 +445,18 @@ mod test { // 4. Prover creates master secret with credential values let credential_values = helpers::gvt_credential_values(&Prover::new_master_secret().unwrap()); - // 5. Issuer creates nonce used Prover to blind master secret - let credential_nonce = new_nonce().unwrap(); + // 5. Issuer creates nonce used by Prover to create correctness proof for blinded secrets + let blinding_correctness_nonce = new_nonce().unwrap(); // 6. Prover blinds master secret let (blinded_credential_secrets, credential_secrets_blinding_factors, blinded_credential_secrets_correctness_proof) = Prover::blind_credential_secrets(&credential_pub_key, &credential_key_correctness_proof, &credential_values, - &credential_nonce).unwrap(); + &blinding_correctness_nonce).unwrap(); - // 7. Prover creates nonce used Issuer to credential issue - let credential_issuance_nonce = new_nonce().unwrap(); + // 7. Prover creates nonce used by Issuer to create correctness proof for signature + let signature_correctness_nonce = new_nonce().unwrap(); // 8. Issuer creates and sign credential values let rev_idx = 1; @@ -464,8 +464,8 @@ mod test { Issuer::sign_credential_with_revoc(PROVER_ID, &blinded_credential_secrets, &blinded_credential_secrets_correctness_proof, - &credential_nonce, - &credential_issuance_nonce, + &blinding_correctness_nonce, + &signature_correctness_nonce, &credential_values, &credential_pub_key, &credential_priv_key, @@ -492,7 +492,7 @@ mod test { &signature_correctness_proof, &credential_secrets_blinding_factors, &credential_pub_key, - &credential_issuance_nonce, + &signature_correctness_nonce, Some(&rev_key_pub), Some(&rev_reg), Some(&witness)).unwrap(); @@ -1583,26 +1583,26 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 5. Issuer creates nonce used Prover to blind master secret - let credential_nonce = new_nonce().unwrap(); + // 5. Issuer creates nonce used by Prover to create correctness proof for blinded secrets + let blinding_correctness_nonce = new_nonce().unwrap(); // 6. Prover blinds master secret let (blinded_credential_secrets, credential_secrets_blinding_factors, blinded_credential_secrets_correctness_proof) = Prover::blind_credential_secrets(&credential_pub_key, &credential_key_correctness_proof, &credential_values, - &credential_nonce).unwrap(); + &blinding_correctness_nonce).unwrap(); - // 7. Prover creates nonce used Issuer to credential issue - let credential_issuance_nonce = new_nonce().unwrap(); + // 7. Prover creates nonce used by Issuer to create correctness proof for signature + let signature_correctness_nonce = new_nonce().unwrap(); let rev_idx = 1; let (mut credential_signature, signature_correctness_proof, rev_reg_delta) = Issuer::sign_credential_with_revoc(PROVER_ID, &blinded_credential_secrets, &blinded_credential_secrets_correctness_proof, - &credential_nonce, - &credential_issuance_nonce, + &blinding_correctness_nonce, + &signature_correctness_nonce, &credential_values, &credential_pub_key, &credential_priv_key, @@ -1626,7 +1626,7 @@ mod test { &signature_correctness_proof, &credential_secrets_blinding_factors, &credential_pub_key, - &credential_issuance_nonce, + &signature_correctness_nonce, Some(&rev_key_pub), Some(&rev_reg), Some(&witness)).unwrap(); @@ -1687,7 +1687,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 5. Issuer creates nonce used Prover to blind master secret + // 5. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 6. Prover blinds master secret @@ -1697,7 +1697,7 @@ mod test { &credential_values, &credential_nonce).unwrap(); - // 7. Prover creates nonce used Issuer to credential issue + // 7. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); let rev_idx = 1; @@ -1791,7 +1791,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 5. Issuer creates nonce used Prover to blind master secret + // 5. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 6. Prover blinds master secret @@ -1801,7 +1801,7 @@ mod test { &credential_values, &credential_nonce).unwrap(); - // 7. Prover creates nonce used Issuer to credential issue + // 7. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); let rev_idx = 1; @@ -1920,7 +1920,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 5. Issuer creates nonce used Prover to blind master secret + // 5. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 6. Prover blinds master secret @@ -1930,7 +1930,7 @@ mod test { &credential_values, &credential_nonce).unwrap(); - // 7. Prover creates nonce used Issuer to credential issue + // 7. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); Issuer::sign_credential_with_revoc(PROVER_ID, @@ -1992,7 +1992,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 5. Issuer creates nonce used Prover to blind master secret + // 5. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 6. Prover blinds master secret @@ -2002,7 +2002,7 @@ mod test { &credential_values, &credential_nonce).unwrap(); - // 7. Prover creates nonce used Issuer to credential issue + // 7. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); // 8. Issuer creates and signs credential values @@ -2088,7 +2088,7 @@ mod test { // Reissue credential with different values but same rev_index - // 16. Issuer creates nonce used Prover to blind master secret + // 16. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let new_credential_nonce = new_nonce().unwrap(); // 17. Prover blinds master secret @@ -2193,7 +2193,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 5. Prover blinds master secret @@ -2203,7 +2203,7 @@ mod test { &credential_values, &credential_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); // 7. Issuer creates and signs credential values @@ -2257,7 +2257,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 5. Prover blinds master secret @@ -2267,7 +2267,7 @@ mod test { &credential_values, &credential_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); // 7. Issuer creates and signs credential values wrong keys @@ -2336,7 +2336,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 5. Prover blinds master secret @@ -2346,7 +2346,7 @@ mod test { &credential_values, &credential_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); // 7. Issuer creates and signs credential values wrong keys @@ -2414,7 +2414,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 5. Prover blinds master secret @@ -2424,7 +2424,7 @@ mod test { &credential_values, &credential_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); // 7. Issuer creates and signs credential values @@ -2548,7 +2548,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::xyz_credential_values(&master_secret); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 5. Prover blinds master secret @@ -2558,7 +2558,7 @@ mod test { &credential_values, &credential_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); // 7. Issuer creates credential values not correspondent to issuer keys @@ -2591,7 +2591,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 5. Prover blinds master secret @@ -2601,7 +2601,7 @@ mod test { &credential_values, &credential_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); // 7. Issuer creates and signs credential values @@ -2657,7 +2657,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 5. Prover blinds master secret @@ -2667,7 +2667,7 @@ mod test { &credential_values, &credential_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); // 7. Issuer creates and signs credential values @@ -2721,7 +2721,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 5. Prover blinds master secret @@ -2731,7 +2731,7 @@ mod test { &credential_values, &credential_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); // 7. Issuer creates and signs credential values @@ -2787,7 +2787,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 5. Prover blinds master secret @@ -2797,7 +2797,7 @@ mod test { &credential_values, &credential_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); // 7. Issuer creates and signs credential values @@ -2883,7 +2883,7 @@ mod test { let (_, _, xyz_credential_key_correctness_proof) = Issuer::new_credential_def(&xyz_credential_schema, &non_credential_schema, false).unwrap(); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let gvt_credential_nonce = new_nonce().unwrap(); // 5. Prover blind master secret by gvt_public_key and xyz_key_correctness_proof @@ -2910,7 +2910,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); let other_nonce = new_nonce().unwrap(); @@ -2919,7 +2919,7 @@ mod test { let (blinded_credential_secrets, _, blinded_credential_secrets_correctness_proof) = Prover::blind_credential_secrets(&credential_pub_key, &credential_key_correctness_proof, &credential_values, &other_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); // 7. Issuer creates credential values @@ -2953,14 +2953,14 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let gvt_credential_values = helpers::gvt_credential_values(&master_secret); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 5. Prover blinds master secret by GVT key let (blinded_credential_secrets, _, blinded_credential_secrets_correctness_proof) = Prover::blind_credential_secrets(&gvt_credential_pub_key, &gvt_credential_key_correctness_proof, &gvt_credential_values, &credential_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); // 7. Issuer creates credential values @@ -2991,7 +2991,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 3. Issuer creates nonce used Prover to blind master secret + // 3. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 4. Prover blinds master secret @@ -3002,7 +3002,7 @@ mod test { let (blinded_credential_secrets, _, _) = Prover::blind_credential_secrets(&credential_pub_key, &credential_key_correctness_proof, &credential_values, &credential_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); // 7. Issuer creates credential values @@ -3034,14 +3034,14 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 5. Prover blinds master secret let (blinded_credential_secrets, credential_secrets_blinding_factors, blinded_credential_secrets_correctness_proof) = Prover::blind_credential_secrets(&credential_pub_key, &credential_key_correctness_proof, &credential_values, &credential_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); let different_nonce = new_nonce().unwrap(); @@ -3084,14 +3084,14 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 5. Prover blinds master secret let (blinded_credential_secrets, credential_secrets_blinding_factors, blinded_credential_secrets_correctness_proof) = Prover::blind_credential_secrets(&credential_pub_key, &credential_key_correctness_proof, &credential_values, &credential_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); let different_nonce = new_nonce().unwrap(); @@ -3144,7 +3144,7 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 5. Prover blinds master secret @@ -3155,7 +3155,7 @@ mod test { let (_, credential_secrets_blinding_factors, _) = Prover::blind_credential_secrets(&credential_pub_key, &credential_key_correctness_proof, &credential_values, &credential_nonce).unwrap(); - // 7. Prover creates nonce used Issuer to credential issue + // 7. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); // 8. Issuer creates credential values @@ -3196,14 +3196,14 @@ mod test { let master_secret = Prover::new_master_secret().unwrap(); let credential_values = helpers::gvt_credential_values(&master_secret); - // 4. Issuer creates nonce used Prover to blind master secret + // 4. Issuer creates nonce used by Prover to create correctness proof for blinded secrets let credential_nonce = new_nonce().unwrap(); // 5. Prover blinds master secret let (blinded_credential_secrets, credential_secrets_blinding_factors, blinded_credential_secrets_correctness_proof) = Prover::blind_credential_secrets(&credential_pub_key, &credential_key_correctness_proof, &credential_values, &credential_nonce).unwrap(); - // 6. Prover creates nonce used Issuer to credential issue + // 6. Prover creates nonce used by Issuer to create correctness proof for signature let credential_issuance_nonce = new_nonce().unwrap(); // 7. Issuer creates credential values