fixed last broken test in signing

- When switching back to SDK reintroduced errors that where fixed in VDR

Signed-off-by: Nicholas Massad <nicholasmassad@hotmail.com>

Author: R3CK0

plenum/test/conftest.py

@@ -41,7 +41,8 @@
 from plenum.test.greek import genNodeNames
 from plenum.test.grouped_load_scheduling import GroupedLoadScheduling
 from plenum.test.node_catchup.helper import waitNodeDataEquality, check_last_3pc_master
-from plenum.test.pool_transactions.helper import vdr_add_new_nym, vdr_pool_refresh, vdr_add_new_steward_and_node
+from plenum.test.pool_transactions.helper import vdr_add_new_nym, vdr_pool_refresh, vdr_add_new_steward_and_node, \
+    sdk_pool_refresh, sdk_add_new_nym, sdk_add_new_steward_and_node
 from plenum.test.simulation.sim_random import DefaultSimRandom
 from plenum.test.spy_helpers import getAllReturnVals
 from plenum.test.view_change.helper import ensure_view_change
@@ -66,7 +67,8 @@
     waitForViewChange, requestReturnedToNode, randomText, \
     mockDistributions, mockImportModule, chk_all_funcs, \
     create_new_test_node, vdr_json_to_request_object, vdr_send_random_requests, \
-    vdr_get_and_check_replies, vdr_set_protocol_version, vdr_send_random_and_check, MockTimer, create_pool_txn_data, sdk_set_protocol_version
+    vdr_get_and_check_replies, vdr_set_protocol_version, vdr_send_random_and_check, MockTimer, \
+    create_pool_txn_data, sdk_set_protocol_version, sdk_send_random_and_check
 from plenum.test.node_request.node_request_helper import checkPrePrepared, \
     checkPropagated, checkPrepared, checkCommitted
 from plenum.test.plugin.helper import getPluginPath
@@ -1368,8 +1370,8 @@ def vdr_node_created_after_some_txns(looper, testNodeClass, do_post_node_creatio
 
 
 @pytest.fixture(scope="module")
-def vdr_node_set_with_node_advdr_pool_handletxns(
-        txnPoolNodeSet, sdk_vdr_pool_handleter_some_txns):
+def vdr_node_set_with_node_added_after_some_txns(
+        txnPoolNodeSet, vdr_node_created_after_some_txns):
     looper, new_node, sdk_pool_handle, new_steward_wallet_handle = \
         vdr_node_created_after_some_txns
     txnPoolNodeSet.append(new_node)
@@ -1380,8 +1382,8 @@ def vdr_node_set_with_node_advdr_pool_handletxns(
 
 @pytest.fixture(scope="module")
 def vdr_new_node_caught_up(txnPoolNodeSet,
-                           sdk_node_set_with_node_added_after_some_txns):
-    looper, new_node, _, _ = sdk_node_set_with_node_added_after_some_txns
+                           vdr_node_set_with_node_added_after_some_txns):
+    looper, new_node, _, _ = vdr_node_set_with_node_added_after_some_txns
     waitNodeDataEquality(looper, new_node, *txnPoolNodeSet[:4],
                          exclude_from_check=['check_last_ordered_3pc_backup'])
     check_last_3pc_master(new_node, txnPoolNodeSet[:4])
@@ -1403,9 +1405,6 @@ def vdr_new_node_caught_up(txnPoolNodeSet,
 
     return new_node
 
-######## SDK
-
-
 
 
 @pytest.fixture(params=range(100))

plenum/test/helper.py

@@ -874,15 +874,15 @@ def sdk_signed_random_requests(looper, sdk_wallet, count):
     return sdk_sign_request_objects(looper, sdk_wallet, reqs_obj)
 
 
-def sdk_send_signed_requests(pool_h, signed_reqs: Sequence):
+def sdk_send_signed_requests(looper, pool_h, signed_reqs: Sequence):
     return [(json.loads(req),
-             asyncio.ensure_future(submit_sdk_request(pool_h, req)))
+             asyncio.ensure_future(submit_sdk_request(pool_h, req), loop=looper.loop))
             for req in signed_reqs]
 
 
 def sdk_send_random_requests(looper, pool_h, sdk_wallet, count: int):
     reqs = sdk_signed_random_requests(looper, sdk_wallet, count)
-    return sdk_send_signed_requests(pool_h, reqs)
+    return sdk_send_signed_requests(looper, pool_h, reqs)
 
 
 def sdk_send_random_request(looper, pool_h, sdk_wallet):

plenum/test/pool_transactions/helper.py

@@ -841,7 +841,7 @@ def sdk_sign_and_send_prepared_request(looper, sdk_wallet, sdk_pool_handle, stri
     signed_reqs = sdk_sign_request_objects(looper, sdk_wallet,
                                            [sdk_json_to_request_object(
                                                json.loads(string_req))])
-    request_couple = sdk_send_signed_requests(sdk_pool_handle, signed_reqs)[0]
+    request_couple = sdk_send_signed_requests(looper, sdk_pool_handle, signed_reqs)[0]
     return request_couple
 
 

plenum/test/signing/test_signing.py

@@ -90,7 +90,7 @@ def test_request_with_incorrect_multisig_signatures(looper, sdk_pool_handle, sdk
 
     multisig_req = sdk_multisign_request_object(looper, sdk_wallet_client2, json.dumps(req.as_dict))
 
-    rep1 = sdk_send_signed_requests(sdk_pool_handle, [multisig_req])
+    rep1 = sdk_send_signed_requests(looper, sdk_pool_handle, [multisig_req])
 
     invalid_signatures = 'did={}, signature={}'.format(req.identifier, req.signatures[req.identifier])
     expected_error_message = 'Reason: client request invalid: {}'.\