Differences between eslint CLI and vscode linting

[chelentos]

Hello!

I've upgraded to eslint@9 in my project and have some issues with linting.

Linting of import/order errors is different in CLI/vscode.

What i'm getting in vscode:

what i have in terminal:

Maybe it's caused by several eslint configs or aliases, but i think i'm using all needed settings for this.

I've made repo with reproduction of this problem: https://github.com/chelentos/vscode-eslint-repr

There are vscode settings in README.

Configs for eslint you can find here: https://github.com/gravity-ui/eslint-config
Import/order config: https://github.com/gravity-ui/eslint-config/blob/main/import-order.js

I've already created issue in vscode plugin repo, but maybe you can help me too.

[ljharb]

The CLI is the source of truth, so if vscode is different, it's the one that's broken. I will definitely try to take a look when I can, thanks for the repro repo!

[chelentos]

@ljharb

The CLI is the source of truth, so if vscode is different, it's the one that's broken

I think yes, but...

It seems to me that vscode linting is more accurate. It's trying to divide external lib and internal alias that looks like external lib.

[JounQin]

I didn't read the repro actually, but there could be a chance that resolver doesn't know about correct ESLint cwd from VSCode because there in no such info passed into resolver.

See also #2108

[chelentos]

@ljharb @JounQin

FYI

The problem might be in resolving ts aliases not as internal.

I've tried to add this code in config in repro repo:

settings: {
    'import/internal-regex': '^@my-test-package/'
}

and the difference in linting has gone.

Where should I look to make possible fix?

[JounQin]

@chelentos You're just by passing the resolving step and mark those packages as internal directly, it's not a fix, just a workaround.

eslint-plugin-import/src/core/importType.js

Lines 21 to 24 in da5f6ec

	function isInternalRegexMatch(name, settings) {
	const internalScope = settings && settings['import/internal-regex'];
	return internalScope && new RegExp(internalScope).test(name);
	}

The root cause is already described at #2108, and the fix #2519 is alreay there for a long time. @ljharb

[chelentos]

@JounQin

Could you help me one more time please.

Is there any 100% workaround of this problem now? To not specifying every ts alias as internal regex.

[JounQin]

The fix is already there: #2519, no other workarounds.

I'll adopt my our PR into https://github.com/un-ts/eslint-plugin-import-x ASAP.