feat: support stake key message signing

Author: rhyslbw

apps/browser-extension-wallet/src/views/browser-view/features/sign-message/useSignMessageState.tsx

@@ -13,7 +13,7 @@ import { useSecrets } from '@lace/core';
 import { parseError } from '@src/utils/parse-error';
 
 interface SignMessageState {
-  usedAddresses: { address: string; id: number }[];
+  usedAddresses: { address: string; id: number; type: 'payment' | 'stake' }[];
   isSigningInProgress: boolean;
   signatureObject: Cip30DataSignature | undefined;
   error: string;
@@ -37,6 +37,7 @@ export const useSignMessageState = (): SignMessageState => {
   const [hardwareWalletError, setHardwareWalletError] = useState<string>('');
 
   const addresses = useObservable(inMemoryWallet?.addresses$);
+  const rewardAccounts = useObservable(inMemoryWallet?.delegation.rewardAccounts$);
 
   const resetSigningState = useCallback(() => {
     setIsSigningInProgress(false);
@@ -57,10 +58,16 @@ export const useSignMessageState = (): SignMessageState => {
         isHardwareWallet
           ? analytics.sendEventToPostHog(PostHogAction.SignMessageAskingHardwareWalletInteraction)
           : analytics.sendEventToPostHog(PostHogAction.SignMessageAskingForPassword);
+
+        // Determine if the address is a payment address or reward account
+        const isRewardAccount = Wallet.Cardano.isRewardAccount(address);
+
         const signatureGenerated = await withSignDataConfirmation(
           async () =>
             await inMemoryWallet.signData({
-              signWith: address as Wallet.Cardano.PaymentAddress,
+              signWith: isRewardAccount
+                ? (address as Wallet.Cardano.RewardAccount)
+                : (address as Wallet.Cardano.PaymentAddress),
               payload
             }),
           !isHardwareWallet ? password : {},
@@ -92,11 +99,20 @@ export const useSignMessageState = (): SignMessageState => {
     [isHardwareWallet, analytics, clearSecrets, inMemoryWallet, t]
   );
 
-  const usedAddresses =
-    addresses?.map((address, index) => ({
+  const usedAddresses = [
+    // Payment addresses
+    ...(addresses?.map((address, index) => ({
       address: address.address.toString(),
-      id: index
-    })) || [];
+      id: index,
+      type: 'payment' as const
+    })) || []),
+    // Reward accounts (stake addresses)
+    ...(rewardAccounts?.map((rewardAccount, index) => ({
+      address: rewardAccount.address,
+      id: addresses?.length ? addresses.length + index : index,
+      type: 'stake' as const
+    })) || [])
+  ];
 
   return {
     usedAddresses,

packages/core/src/ui/components/WalletOwnAddressesDropdown/WalletOwnAddressDropdown.tsx

@@ -9,6 +9,7 @@ import { useTranslation } from 'react-i18next';
 export interface AddressSchema {
   id: number;
   address: string;
+  type?: 'payment' | 'stake';
 }
 
 export type WalletOwnAddressDropdownProps = {
@@ -40,10 +41,25 @@ export const WalletOwnAddressDropdown = ({
     }
   };
 
-  const items: MenuProps['items'] = addresses.map((address) => ({
-    key: address.id.toString(),
-    label: addEllipsis(address.address, FIRST_PART_ADDRESS_LENGTH, LAST_PART_ADDRESS_LENGTH)
-  }));
+  const getAddressTypeDisplay = (addressType?: 'payment' | 'stake'): string => {
+    if (addressType === 'stake') {
+      return ` (${t('core.signMessage.addressTypeStake')})`;
+    }
+    if (addressType === 'payment') {
+      return ` (${t('core.signMessage.addressTypePayment')})`;
+    }
+    return '';
+  };
+
+  const items: MenuProps['items'] = addresses.map((address) => {
+    const shortenedAddress = addEllipsis(address.address, FIRST_PART_ADDRESS_LENGTH, LAST_PART_ADDRESS_LENGTH);
+    const addressType = getAddressTypeDisplay(address.type);
+
+    return {
+      key: address.id.toString(),
+      label: `${shortenedAddress}${addressType}`
+    };
+  });
 
   const menuProps: MenuProps = {
     items,

packages/translation/src/lib/translations/core/en.json

@@ -237,6 +237,8 @@
   "core.signMessage.signButton": "Sign message",
   "core.signMessage.signWithHardwareWalletButton": "Sign message with hardware wallet",
   "core.signMessage.hardwareWalletNotConnected": "Make sure your hardware wallet is connected and unlocked.",
+  "core.signMessage.addressTypePayment": "Payment",
+  "core.signMessage.addressTypeStake": "Stake",
   "core.Burn.title": "Confirm transaction",
   "core.coinInputSelection.assetSelection": "Select tokens or NFTs",
   "core.coinInputSelection.nfts": "NFTs",