Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.
This repository was archived by the owner on May 9, 2024. It is now read-only.

[Warn] Conflict of codegen methods #569

@Devjiu

Description

@Devjiu

I am not sure how to resolve this clash of namings.

ReductionCode ResultSetReductionJIT::codegen() const

vs

ReductionCode GpuReductionHelperJIT::codegen(const CompilationOptions& co) 

at omniscidb/QueryEngine/ResultSetReductionJIT.h

Second one method have single call, if it's what's intended to be done, let's remove virtual and rename GpuReductionHelperJIT method.

Metadata

Metadata

Assignees

Labels

help wantedExtra attention is neededinvalidThis doesn't seem right

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions