add show flag to show values for resp features (#444)

Author: viveksahu26

cmd/list.go

@@ -40,6 +40,7 @@ type userListCmd struct {
 	json     bool
 	detailed bool
 	color    bool
+	show     bool
 
 	// Debug control
 	debug bool
@@ -67,11 +68,13 @@ var listCmd = &cobra.Command{
   # Component features: 
   [comp_with_name, comp_with_version, comp_with_supplier, comp_with_uniq_ids, comp_valid_licenses, comp_with_any_vuln_lookup_id, 
   comp_with_deprecated_licenses, comp_with_multi_vuln_lookup_id, comp_with_primary_purpose, comp_with_restrictive_licenses, 
-  comp_with_checksums, comp_with_licenses]
+  comp_with_checksums, comp_with_licenses, comp_with_checksums_sha256, comp_with_source_code_uri, comp_with_source_code_hash, 
+  comp_with_executable_uri, comp_with_associated_license, comp_with_concluded_license, comp_with_declared_license]
   
   # SBOM features:
   [sbom_creation_timestamp, sbom_authors, sbom_with_creator_and_version, sbom_with_primary_component, sbom_dependencies, 
-  sbom_sharable, sbom_parsable, sbom_spec, sbom_spec_file_format, sbom_spec_version]
+  sbom_sharable, sbom_parsable, sbom_spec, sbom_file_format, sbom_spec_version, spec_with_version_compliant, sbom_with_uri,
+  sbom_with_vuln, sbom_build_process]
 `,
 
 	Args: func(_ *cobra.Command, args []string) error {
@@ -130,6 +133,9 @@ func parseListParams(cmd *cobra.Command, args []string) *userListCmd {
 	color, _ := cmd.Flags().GetBool("color")
 	uCmd.color = color
 
+	show, _ := cmd.Flags().GetBool("show")
+	uCmd.show = show
+
 	// Debug control
 	debug, _ := cmd.Flags().GetBool("debug")
 	uCmd.debug = debug
@@ -147,6 +153,7 @@ func fromListToEngineParams(uCmd *userListCmd) *engine.Params {
 		Detailed: uCmd.detailed,
 		Color:    uCmd.color,
 		Debug:    uCmd.debug,
+		Show:     uCmd.show,
 	}
 }
 
@@ -166,6 +173,7 @@ func init() {
 	listCmd.Flags().BoolP("json", "j", false, "Results in JSON")
 	listCmd.Flags().BoolP("detailed", "d", true, "Results in table format, default")
 	listCmd.Flags().BoolP("color", "l", false, "Output in color")
+	listCmd.Flags().BoolP("show", "s", false, "Show values of features, (default: false)")
 
 	// Debug Control
 	listCmd.Flags().BoolP("debug", "D", false, "Enable debug logging")

pkg/engine/list.go

@@ -31,6 +31,7 @@ func parseListParams(ep *Params) *list.Params {
 		Color:    ep.Color,
 		Missing:  ep.Missing,
 		Debug:    ep.Debug,
+		Show:     ep.Show,
 	}
 }
 

pkg/engine/score.go

@@ -52,6 +52,7 @@ type Params struct {
 	Missing bool
 
 	Debug bool
+	Show  bool
 
 	ConfigPath string
 

pkg/list/list.go

@@ -146,6 +146,8 @@ func parseSBOMDocument(ctx context.Context, filePath string) (sbom.Document, err
 // processFeatureForSBOM processes a single feature for an SBOM document and returns a ListResult
 func processFeatureForSBOM(ctx context.Context, ep *Params, doc sbom.Document, filePath, feature string) (*Result, error) {
 	log := logger.FromContext(ctx)
+	log.Debug("list.processFeatureForSBOM()")
+	log.Debug("processing feature: ", feature)
 	feature = strings.TrimSpace(feature)
 
 	// Validate the feature
@@ -175,6 +177,7 @@ func processFeatureForSBOM(ctx context.Context, ep *Params, doc sbom.Document, f
 // processComponentFeature processes a component-based feature for an SBOM document
 func processComponentFeature(ctx context.Context, ep *Params, doc sbom.Document, result *Result) (*Result, error) {
 	log := logger.FromContext(ctx)
+	log.Debug("processing component feature: ", result.Feature)
 	result.Components = []ComponentResult{}
 	var totalComponents int
 
@@ -243,8 +246,9 @@ func generateReport(ctx context.Context, results []*Result, ep *Params) error {
 		reportFormat = "json"
 	}
 	coloredOutput := ep.Color
+	show := ep.Show
 
-	lnr := NewListReport(ctx, results, WithFormat(strings.ToLower(reportFormat)), WithColor(coloredOutput))
+	lnr := NewListReport(ctx, results, WithFormat(strings.ToLower(reportFormat)), WithColor(coloredOutput), WithValues(show))
 	lnr.Report()
 	return nil
 }

pkg/list/report.go

@@ -54,12 +54,19 @@ func WithColor(c bool) OptionList {
 	}
 }
 
+func WithValues(s bool) OptionList {
+	return func(r *Report) {
+		r.Show = s
+	}
+}
+
 // listReport holds the state for reporting the list command results
 type Report struct {
 	Ctx     context.Context
 	Results []*Result
 	Format  string
 	Color   bool
+	Show    bool // show values for corresponding features
 }
 
 // Report renders the list command results in the specified format
@@ -97,13 +104,21 @@ func (r *Report) detailedReport() {
 		if result.Missing {
 			presence = "missing"
 		}
+		show := r.Show
+		fmt.Println()
 		fmt.Printf("File: %s\tFeature: %s (%s)\n", result.FilePath, result.Feature, presence)
 
 		// Initialize tablewriter
 		table := tablewriter.NewWriter(os.Stdout)
 		if strings.HasPrefix(result.Feature, "comp_") {
+
+			if show {
+				table.SetHeader([]string{"Feature", "Component Name", "Version", "Value"})
+			} else {
+				table.SetHeader([]string{"Feature", "Component Name", "Version"})
+			}
+
 			// Component-based feature
-			table.SetHeader([]string{"Feature", "Component Name", "Version"})
 			featureCol := fmt.Sprintf("%s (%d/%d)", result.Feature, len(result.Components), result.TotalComponents)
 			if len(result.Components) == 0 {
 				// No components to display
@@ -119,29 +134,38 @@ func (r *Report) detailedReport() {
 					versionCol := color.New(color.FgHiGreen).Sprint(comp.Version)
 					table.Append([]string{featureCol1, nameCol, versionCol})
 				}
-				table.Append([]string{featureCol, comp.Name, comp.Version})
-
+				if show {
+					table.Append([]string{featureCol, comp.Name, comp.Version, comp.Values})
+				} else {
+					table.Append([]string{featureCol, comp.Name, comp.Version})
+				}
 			}
 
 		} else {
 			// SBOM-based feature
 			featureCol := fmt.Sprintf("%s (%s)", result.Feature, presence)
+			table.SetHeader([]string{"Feature", "SBOM Feature", "Value"})
+
 			if r.Color {
 				featureCol1 := color.New(color.FgHiCyan).Sprint(featureCol)
 				propertyCol := color.New(color.FgHiBlue).Sprint(result.DocumentProperty.Key)
 				valueCol := color.New(color.FgHiBlue).Sprint(result.DocumentProperty.Value)
 				table.Append([]string{featureCol1, propertyCol, valueCol})
 			} else {
 				if result.DocumentProperty.Present {
+					if result.DocumentProperty.Value == "" {
+						result.DocumentProperty.Value = "N/A"
+					}
 					table.Append([]string{featureCol, result.DocumentProperty.Key, result.DocumentProperty.Value})
 				} else {
-					table.Append([]string{featureCol, result.DocumentProperty.Key, "N/A"})
+					if result.DocumentProperty.Value == "" {
+						result.DocumentProperty.Value = "N/A"
+					}
+					table.Append([]string{featureCol, result.DocumentProperty.Key, result.DocumentProperty.Value})
 				}
 			}
 		}
 
-		// Configure table settings
-		table.SetHeader([]string{"Feature", "Key/Component Name", "Value/Version"})
 		table.SetRowLine(true)
 		table.SetColWidth(50)
 		table.SetAutoMergeCellsByColumnIndex([]int{0})

pkg/list/types.go

@@ -47,6 +47,7 @@ type Params struct {
 	Basic    bool
 	Detailed bool
 	Color    bool
+	Show     bool
 
 	Missing bool