add integrity extractor test

Author: viveksahu26

pkg/scorer/v2/engine/farmulas.go

@@ -14,12 +14,20 @@
 
 package engine
 
-import "github.com/interlynk-io/sbomqs/pkg/scorer/v2/config"
+import (
+	"fmt"
 
+	"github.com/interlynk-io/sbomqs/pkg/scorer/v2/config"
+)
+
+func NoComponentsNA() string           { return "N/A (no components)" }
 func MissingField(field string) string { return "missing " + field }
 func PresentField(field string) string { return "present " + field }
 func NonSupportedSPDXField() string    { return "N/A (SPDX)" }
 func UnknownSpec() string              { return "N/A (unknown spec)" }
+func CompDescription(have, total int, field string) string {
+	return fmt.Sprintf("%d/%d have %s", have, total, field)
+}
 
 // perComponentScore returns 10 × (have/total)
 func PerComponentScore(have, total int) float64 {

pkg/scorer/v2/extractors/identification.go

@@ -30,7 +30,7 @@ func CompWithName(doc sbom.Document) config.FeatureScore {
 	if total == 0 {
 		return config.FeatureScore{
 			Score:  engine.PerComponentScore(0, total),
-			Desc:   "N/A (no components)",
+			Desc:   engine.NoComponentsNA(),
 			Ignore: true,
 		}
 	}
@@ -40,8 +40,9 @@ func CompWithName(doc sbom.Document) config.FeatureScore {
 	})
 
 	return config.FeatureScore{
-		Score:  engine.PerComponentScore(have, total),
-		Desc:   fmt.Sprintf("%d/%d have names", have, total),
+		Score: engine.PerComponentScore(have, total),
+		Desc:  engine.CompDescription(have, total, "names"),
+
 		Ignore: false,
 	}
 }
@@ -52,7 +53,7 @@ func CompWithVersion(doc sbom.Document) config.FeatureScore {
 	if total == 0 {
 		return config.FeatureScore{
 			Score:  engine.PerComponentScore(0, total),
-			Desc:   "N/A (no components)",
+			Desc:   engine.NoComponentsNA(),
 			Ignore: true,
 		}
 	}
@@ -63,7 +64,7 @@ func CompWithVersion(doc sbom.Document) config.FeatureScore {
 
 	return config.FeatureScore{
 		Score:  engine.PerComponentScore(have, total),
-		Desc:   fmt.Sprintf("%d/%d have versions", have, total),
+		Desc:   engine.CompDescription(have, total, "versions"),
 		Ignore: false,
 	}
 }
@@ -74,7 +75,7 @@ func CompWithUniqLocalIDs(doc sbom.Document) config.FeatureScore {
 	if total == 0 {
 		return config.FeatureScore{
 			Score:  engine.PerComponentScore(0, total),
-			Desc:   "N/A (no components)",
+			Desc:   engine.NoComponentsNA(),
 			Ignore: true,
 		}
 	}
@@ -90,7 +91,7 @@ func CompWithUniqLocalIDs(doc sbom.Document) config.FeatureScore {
 
 	return config.FeatureScore{
 		Score:  engine.PerComponentScore(len(have), total),
-		Desc:   fmt.Sprintf("%d/%d have unique IDs", len(have), total),
+		Desc:   engine.CompDescription(len(have), total, "unique IDs"),
 		Ignore: false,
 	}
 }

pkg/scorer/v2/extractors/integrity.go

@@ -33,21 +33,21 @@ func CompWithSHA1Plus(doc sbom.Document) config.FeatureScore {
 	if total == 0 {
 		return config.FeatureScore{
 			Score:  engine.PerComponentScore(0, 0),
-			Desc:   "N/A (no components)",
+			Desc:   engine.NoComponentsNA(),
 			Ignore: true,
 		}
 	}
 
-	withSHA1p := 0
+	have := 0
 	for _, comp := range comps {
 		if hasSHA1Plus(comp) {
-			withSHA1p++
+			have++
 		}
 	}
 
 	return config.FeatureScore{
-		Score:  engine.PerComponentScore(withSHA1p, total),
-		Desc:   fmt.Sprintf("%d/%d have SHA-1+", withSHA1p, total),
+		Score:  engine.PerComponentScore(have, total),
+		Desc:   engine.CompDescription(have, total, "SHA-1+"),
 		Ignore: false,
 	}
 }
@@ -59,21 +59,21 @@ func CompWithSHA256Plus(doc sbom.Document) config.FeatureScore {
 	if total == 0 {
 		return config.FeatureScore{
 			Score:  engine.PerComponentScore(0, 0),
-			Desc:   "N/A (no components)",
+			Desc:   engine.NoComponentsNA(),
 			Ignore: true,
 		}
 	}
 
-	with256p := 0
+	have := 0
 	for _, c := range comps {
 		if hasSHA256Plus(c) {
-			with256p++
+			have++
 		}
 	}
 
 	return config.FeatureScore{
-		Score:  engine.PerComponentScore(with256p, total),
-		Desc:   fmt.Sprintf("%d/%d have SHA-256+", with256p, total),
+		Score:  engine.PerComponentScore(have, total),
+		Desc:   engine.CompDescription(have, total, "SHA-256+"),
 		Ignore: false,
 	}
 }
@@ -88,18 +88,18 @@ var verifySignature = common.VerifySignature
 //	 5 = signature present but verification failed
 //	 0 = no signature / incomplete bundle
 func SBOMSignature(doc sbom.Document) config.FeatureScore {
-	s := doc.Signature()
-	if s == nil {
+	sig := doc.Signature()
+	if sig == nil {
 		return config.FeatureScore{
 			Score:  0,
-			Desc:   "no signature",
+			Desc:   engine.MissingField("signature"),
 			Ignore: false,
 		}
 	}
 
-	pubKeyPath := strings.TrimSpace(s.GetPublicKey())
-	blobPath := strings.TrimSpace(s.GetBlob())
-	sigPath := strings.TrimSpace(s.GetSigValue())
+	pubKeyPath := strings.TrimSpace(sig.GetPublicKey())
+	blobPath := strings.TrimSpace(sig.GetBlob())
+	sigPath := strings.TrimSpace(sig.GetSigValue())
 
 	// Incomplete bundle → treat as missing
 	if pubKeyPath == "" || blobPath == "" || sigPath == "" {