Close the controller when state not synchronized (#49)

* Close the controller when state not synchronized

* Bump version to v0.7.3

Author: kairen

Makefile

@@ -1,6 +1,6 @@
 VERSION_MAJOR ?= 0
 VERSION_MINOR ?= 7
-VERSION_BUILD ?= 2
+VERSION_BUILD ?= 3
 VERSION ?= v$(VERSION_MAJOR).$(VERSION_MINOR).$(VERSION_BUILD)
 
 GOOS ?= $(shell go env GOOS)

cmd/main.go

@@ -134,27 +134,32 @@ func main() {
 		active := false
 		callbacks := &ha.Callbacks{
 			OnActive: func(status *util.HighAvailability) {
+				stateSync := status.Group.Local.StateSync
+				syncEnabled := status.Group.RunningSyncEnabled
+				runningSync := status.Group.RunningSync
 				switch {
-				case status.Group.Local.StateSync == "Complete":
-					if status.Group.RunningSyncEnabled == "yes" && status.Group.RunningSync == "synchronized" {
-						glog.V(3).Infof("PAN firewall on active, and synchronized.")
-						if !active {
-							if err := op.Run(ctx); err != nil {
-								glog.Fatalf("Error to run the operator: %s.", err)
-							}
-							active = true
+				case stateSync == "Complete" && syncEnabled == "yes" && runningSync == "synchronized":
+					glog.V(3).Infof("PAN firewall on active, and synchronized.")
+					if !active {
+						if err := op.Run(ctx); err != nil {
+							glog.Fatalf("Error to run the operator: %s.", err)
 						}
+						active = true
 					}
 				default:
 					glog.V(3).Infof("PAN firewall on active, but not synchronized.")
+					if active {
+						op.Stop()
+						glog.Fatalf("The active state lost and not synchronized, exiting...")
+					}
 				}
 			},
 			OnPassive: func() {
 				glog.V(3).Infof("PAN firewall on passive.")
 				if active {
 					op.Stop()
 					active = false
-					glog.Fatalf("Active state lost, exiting...")
+					glog.Fatalf("The active state lost, exiting...")
 				}
 			},
 			OnFail: func(err error) {

deploy/deployment.yml

@@ -24,7 +24,7 @@ spec:
       serviceAccountName: pa-controller
       containers:
       - name: pa-controller
-        image: inwinstack/pa-controller:v0.7.2
+        image: inwinstack/pa-controller:v0.7.3
         args:
         - --logtostderr=true
         - --v=2