[mw] Improve reading of data source credentials from environment vars

Before, the system would happily use empty credentials induced by CI
when running from foreign repositories, where the GitHub secrets
attached to the repository are not active, but the GHA workflow
configuration still sets the environment variables - to empty values.

Author: amotl

patzilla/access/depatech/clientpool.py

@@ -43,6 +43,8 @@ def from_settings(datasource_settings):
 
     @staticmethod
     def from_environment():
+        if not os.environ["DEPATECH_API_USERNAME"] or not os.environ["DEPATECH_API_PASSWORD"]:
+            raise KeyError("DEPATECH_API_USERNAME or DEPATECH_API_PASSWORD is empty")
         return {
             "api_username": os.environ["DEPATECH_API_USERNAME"],
             "api_password": os.environ["DEPATECH_API_PASSWORD"],

patzilla/access/epo/ops/client.py

@@ -38,6 +38,8 @@ def from_settings(datasource_settings):
 
     @staticmethod
     def from_environment():
+        if not os.environ["OPS_API_CONSUMER_KEY"] or not os.environ["OPS_API_CONSUMER_SECRET"]:
+            raise KeyError("OPS_API_CONSUMER_KEY or OPS_API_CONSUMER_SECRET is empty")
         return {
             "consumer_key": os.environ["OPS_API_CONSUMER_KEY"],
             "consumer_secret": os.environ["OPS_API_CONSUMER_SECRET"],

patzilla/access/ificlaims/clientpool.py

@@ -46,6 +46,8 @@ def from_settings(datasource_settings):
 
     @staticmethod
     def from_environment():
+        if not os.environ["IFICLAIMS_API_USERNAME"] or not os.environ["IFICLAIMS_API_PASSWORD"]:
+            raise KeyError("IFICLAIMS_API_USERNAME or IFICLAIMS_API_PASSWORD is empty")
         return {
             "api_username": os.environ["IFICLAIMS_API_USERNAME"],
             "api_password": os.environ["IFICLAIMS_API_PASSWORD"],

patzilla/access/sip/clientpool.py

@@ -46,6 +46,8 @@ def from_settings(datasource_settings):
 
     @staticmethod
     def from_environment():
+        if not os.environ["SIP_API_USERNAME"] or not os.environ["SIP_API_PASSWORD"]:
+            raise KeyError("SIP_API_USERNAME or SIP_API_PASSWORD is empty")
         return {
             "api_username": os.environ["SIP_API_USERNAME"],
             "api_password": os.environ["SIP_API_PASSWORD"],