Merge pull request #19 from mki98/patch-1

Suggest fix for incomaptiabilty with windows file system

Author: ishtms

chapters/ch04.2-writing-logs.md

@@ -410,7 +410,7 @@ class Logger {
     #log_file_handle;
 
     async init() {
-        const file_name = this.#config.file_prefix + new Date().toISOString().replace(/\..+/, "") + ".log";
+         const file_name = this.#config.file_prefix + new Date().toISOString().replace(/[\.:]+/, "-") + ".log";
         this.#log_file_handle = await fs.open(file_name, "a+");
     }
 }
@@ -467,7 +467,7 @@ class Logger {
     ...
 
     async init() {
-        const file_name = this.#config.file_prefix + new Date().toISOString().replace(/\..+/, "") + ".log";
+        const file_name = this.#config.file_prefix + new Date().toISOString().replace(/[\.:]+/, "-") + ".log";
         this.#log_file_handle = await fs.open(file_name, "a+");
         console.log("File created.")
     }
@@ -602,7 +602,7 @@ Update the code inside `Logger.init` method:
 const path = require('node:path')
 
 async init() {
-    const file_name = this.#config.file_prefix + new Date().toISOString().replace(/\..+/, "") + ".log";
+    const file_name = this.#config.file_prefix + new Date().toISOString().replace(/[\.:]+/, "-") + ".log";
     this.#log_file_handle = await fs.open(path.join('logs', file_name), "a+");
 }
 ```
@@ -699,7 +699,7 @@ Let's go through the `check_and_create_dir` function's code line by line.
         async init() {
             const log_dir_path = check_and_create_dir("logs")
 
-            const file_name = this.#config.file_prefix + new Date().toISOString().replace(/\..+/, "") + ".log";
+            const file_name = this.#config.file_prefix + new Date().toISOString().replace(/[\.:]+/, "-") + ".log";
 
             // Open/Create the file at the specified log directory and
             // save the file handle to the `#log_file_handle` for further
@@ -793,4 +793,4 @@ We'll take care of all this in the next chapter.
 
 [![Read Next](/assets/imgs/next.png)](/chapters/ch04.3-capturing-metadata.md)
 
-![](https://uddrapi.com/api/img?page=ch04.2)
+![](https://uddrapi.com/api/img?page=ch04.2)

chapters/ch04.5-rolling-file-support.md

@@ -155,7 +155,7 @@ We call the `Logger.init` method to create the new file again. Here's the code f
 async init() {
     const log_dir_path = check_and_create_dir("logs");
 
-    const file_name = this.#config.file_prefix + new Date().toISOString().replace(/\..+/, "") + ".log";
+    const file_name = this.#config.file_prefix + new Date().toISOString().replace(/[\.:]+/, "-") + ".log";
     this.#log_file_handle = await fs.open(path.join(log_dir_path, file_name), "a+");
 }
 ```

code/chapter_04.2/lib/logger.js

@@ -28,7 +28,7 @@ class Logger {
     async init() {
           const log_dir_path = check_and_create_dir("logs")
 
-          const file_name = this.#config.file_prefix + new Date().toISOString().replace(/\..+/, "") + ".log";
+          const file_name = this.#config.file_prefix + new Date().toISOString().replace(/[\.:]+/, "-") + ".log";
           this.#log_file_handle = await fs.open(path.join(log_dir_path, file_name), "a+");
     }
 

code/chapter_04.2/logs/LogTar_2023-08-18T19:48:03.log renamed to code/chapter_04.2/logs/LogTar_2023-08-18T19-48-03.log

@@ -44,7 +44,7 @@ class Logger {
     async init() {
         const log_dir_path = check_and_create_dir("logs");
 
-        const file_name = this.#config.file_prefix + new Date().toISOString().replace(/\..+/, "") + ".log";
+        const file_name = this.#config.file_prefix + new Date().toISOString().replace(/[\.:]+/, "-") + ".log";
         this.#log_file_handle = await fs.open(path.join(log_dir_path, file_name), "a+");
     }
 

code/chapter_04.3/lib/logger.js

@@ -32,7 +32,7 @@ class Logger {
     async init() {
         const log_dir_path = check_and_create_dir("logs");
 
-        const file_name = this.#config.file_prefix + new Date().toISOString().replace(/\..+/, "") + ".log";
+        const file_name = this.#config.file_prefix + new Date().toISOString().replace(/[\.:]+/, "-") + ".log";
         this.#log_file_handle = await fs.open(path.join(log_dir_path, file_name), "a+");
     }