Enable more linters (#414)

Author: bfabio

.golangci.yaml

@@ -38,8 +38,10 @@ linters:
     - errname
     - errorlint
     - exhaustive
+    - exptostd
     - forbidigo
     - forcetypeassert
+    - funcorder
     # - funlen
     - ginkgolinter
     - gocheckcompilerdirectives
@@ -60,6 +62,7 @@ linters:
     - grouper
     - importas
     - interfacebloat
+    - intrange
     # - ireturn
     - lll
     - loggercheck
@@ -80,11 +83,11 @@ linters:
     - prealloc
     - predeclared
     - promlinter
+    - protogetter
     - reassign
     - revive
     - rowserrcheck
     - sqlclosecheck
-    # - stylecheck
     - tagliatelle
     - testableexamples
     - testpackage

crawler/crawler.go

@@ -9,6 +9,7 @@ import (
 	"path"
 	"regexp"
 	"runtime"
+	"slices"
 	"strings"
 	"sync"
 
@@ -22,7 +23,6 @@ import (
 	publiccode "github.com/italia/publiccode-parser-go/v4"
 	log "github.com/sirupsen/logrus"
 	"github.com/spf13/viper"
-	"golang.org/x/exp/slices"
 )
 
 // Crawler is a helper class representing a crawler.
@@ -162,47 +162,6 @@ func (c *Crawler) CrawlPublishers(publishers []common.Publisher) error {
 	return c.crawl()
 }
 
-func (c *Crawler) crawl() error {
-	reposChan := make(chan common.Repository)
-
-	// Start the metrics server.
-	go metrics.StartPrometheusMetricsServer()
-
-	defer c.publishersWg.Wait()
-
-	// Get cpus number
-	numCPUs := runtime.NumCPU()
-	log.Debugf("CPUs #: %d", numCPUs)
-
-	// Process the repositories in order to retrieve the files.
-	for i := 0; i < numCPUs; i++ {
-		c.repositoriesWg.Add(1)
-		go func(id int) {
-			log.Debugf("Starting ProcessRepositories() goroutine (#%d)", id)
-			c.ProcessRepositories(reposChan)
-		}(i)
-	}
-
-	for repo := range c.repositories {
-		reposChan <- repo
-	}
-	close(reposChan)
-	c.repositoriesWg.Wait()
-
-	log.Infof(
-		"Summary: Total repos scanned: %v. With good publiccode.yml file: %v. With bad publiccode.yml file: %v\n"+
-			"Repos with good publiccode.yml file: New repos: %v, Known repos: %v, Failures saving to API: %v",
-		metrics.GetCounterValue("repository_processed", c.Index),
-		metrics.GetCounterValue("repository_good_publiccodeyml", c.Index),
-		metrics.GetCounterValue("repository_bad_publiccodeyml", c.Index),
-		metrics.GetCounterValue("repository_new", c.Index),
-		metrics.GetCounterValue("repository_known", c.Index),
-		metrics.GetCounterValue("repository_upsert_failures", c.Index),
-	)
-
-	return nil
-}
-
 // ScanPublisher scans all the publisher' repositories and sends the ones
 // with a valid publiccode.yml to the repositories channel.
 func (c *Crawler) ScanPublisher(publisher common.Publisher) {
@@ -484,6 +443,47 @@ func (c *Crawler) ProcessRepo(repository common.Repository) { //nolint:maintidx
 	}
 }
 
+func (c *Crawler) crawl() error {
+	reposChan := make(chan common.Repository)
+
+	// Start the metrics server.
+	go metrics.StartPrometheusMetricsServer()
+
+	defer c.publishersWg.Wait()
+
+	// Get cpus number
+	numCPUs := runtime.NumCPU()
+	log.Debugf("CPUs #: %d", numCPUs)
+
+	// Process the repositories in order to retrieve the files.
+	for i := range numCPUs {
+		c.repositoriesWg.Add(1)
+		go func(id int) {
+			log.Debugf("Starting ProcessRepositories() goroutine (#%d)", id)
+			c.ProcessRepositories(reposChan)
+		}(i)
+	}
+
+	for repo := range c.repositories {
+		reposChan <- repo
+	}
+	close(reposChan)
+	c.repositoriesWg.Wait()
+
+	log.Infof(
+		"Summary: Total repos scanned: %v. With good publiccode.yml file: %v. With bad publiccode.yml file: %v\n"+
+			"Repos with good publiccode.yml file: New repos: %v, Known repos: %v, Failures saving to API: %v",
+		metrics.GetCounterValue("repository_processed", c.Index),
+		metrics.GetCounterValue("repository_good_publiccodeyml", c.Index),
+		metrics.GetCounterValue("repository_bad_publiccodeyml", c.Index),
+		metrics.GetCounterValue("repository_new", c.Index),
+		metrics.GetCounterValue("repository_known", c.Index),
+		metrics.GetCounterValue("repository_upsert_failures", c.Index),
+	)
+
+	return nil
+}
+
 // validateFile performs additional validations that are not strictly mandated
 // by the publiccode.yml Standard.
 // Using `one` command this check will be skipped.

git/repo_activity.go

@@ -95,7 +95,7 @@ func CalculateRepoActivity(repository common.Repository, days int) (float64, map
 		log.Warn(err)
 	}
 
-	for i := 0; i < days; i++ {
+	for i := range days {
 		userCommunity = ranges("userCommunity", userCommunityLastDays(commitsLastDays[i]))
 
 		codeActivity = ranges("codeActivity", activityLastDays(commitsPerDay[i]))
@@ -271,7 +271,7 @@ func ranges(name string, value float64) float64 {
 func extractCommitsLastDays(days int, commits []*object.Commit) map[int][]*object.Commit {
 	commitsLastDays := map[int][]*object.Commit{}
 	// Populate the slice of commits in every day.
-	for i := 0; i < days; i++ {
+	for i := range days {
 		lastDays := time.Now().AddDate(0, 0, -i)
 		// Append all the commits created before lastDays date.
 		for _, c := range commits {
@@ -288,7 +288,7 @@ func extractCommitsLastDays(days int, commits []*object.Commit) map[int][]*objec
 func extractCommitsPerDay(days int, commits []*object.Commit) map[int][]*object.Commit {
 	commitsPerDay := map[int][]*object.Commit{}
 	// Populate the slice of commits in every day.
-	for i := 0; i < days; i++ {
+	for i := range days {
 		lastDays := time.Now().AddDate(0, 0, -i)
 		// Append all the commits created before lastDays date.
 		for _, c := range commits {
@@ -306,7 +306,7 @@ func extractCommitsPerDay(days int, commits []*object.Commit) map[int][]*object.
 // extractTagsPerDay returns a map of #[days] commits where a tag is created.
 func extractTagsPerDay(days int, tags []*object.Commit) map[int][]*object.Commit {
 	tagsPerDays := map[int][]*object.Commit{}
-	for i := 0; i < days; i++ {
+	for i := range days {
 		lastDays := time.Now().AddDate(0, 0, -i)
 		// Append all the commits created before lastDays date.
 		for _, t := range tags {

metrics/prometheus.go

@@ -40,7 +40,7 @@ func GetCounterValue(name, namespace string) float64 {
 		return 0
 	}
 
-	return m.Counter.GetValue()
+	return m.GetCounter().GetValue()
 }
 
 // RegisterPrometheusCounter register a new Counter of given name with help text.