Merge pull request #336 from jdkandersson/enhancement/support-int

Enhancement/support int

Author: jdkandersson

CHANGELOG.md

@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Added
+
+- Add support for `int` values for `number` types.
+
 ## [v2.4.2] - 2021-04-04
 
 ### Added

open_alchemy/utility_base/from_dict/simple.py

@@ -35,7 +35,7 @@ def convert(
             )
         return value
     if type_ == "number":
-        if not isinstance(value, float):
+        if not isinstance(value, (float, int)):
             raise exceptions.InvalidInstanceError(
                 "Number type columns must have float values."
             )

tests/open_alchemy/utility_base/from_dict/test_simple.py

@@ -12,20 +12,37 @@
 @pytest.mark.parametrize(
     "schema, value, exception",
     [
-        ({}, mock.MagicMock(), exceptions.TypeMissingError),
-        ({"type": "type 1"}, mock.MagicMock(), exceptions.FeatureNotImplementedError),
-        ({"type": "integer"}, 1.1, exceptions.InvalidInstanceError),
-        ({"type": "number"}, 1, exceptions.InvalidInstanceError),
-        ({"type": "string"}, 1, exceptions.InvalidInstanceError),
-        ({"type": "boolean"}, 1, exceptions.InvalidInstanceError),
-    ],
-    ids=[
-        "no type",
-        "unsupported type",
-        "integer different type",
-        "number different type",
-        "string different type",
-        "boolean different type",
+        pytest.param({}, mock.MagicMock(), exceptions.TypeMissingError, id="no type"),
+        pytest.param(
+            {"type": "type 1"},
+            mock.MagicMock(),
+            exceptions.FeatureNotImplementedError,
+            id="unsupported type",
+        ),
+        pytest.param(
+            {"type": "integer"},
+            1.1,
+            exceptions.InvalidInstanceError,
+            id="integer different type",
+        ),
+        pytest.param(
+            {"type": "number"},
+            "1",
+            exceptions.InvalidInstanceError,
+            id="number different type",
+        ),
+        pytest.param(
+            {"type": "string"},
+            1,
+            exceptions.InvalidInstanceError,
+            id="string different type",
+        ),
+        pytest.param(
+            {"type": "boolean"},
+            1,
+            exceptions.InvalidInstanceError,
+            id="boolean different type",
+        ),
     ],
 )
 @pytest.mark.utility_base
@@ -66,6 +83,12 @@ def test_convert_invalid(schema, value, exception):
             1.1,
             id="number",
         ),
+        pytest.param(
+            {"type": "number"},
+            1,
+            1,
+            id="number integer value",
+        ),
         pytest.param(
             {"type": "number", "format": "float"},
             1.1,