Skip to content

Commit a3419ce

Browse files
committed
Drop bluebird dependency, use native Promise
Node.js provides native Promise API for more than six years. Node.js versions older than that are unmaintained and unsupported for many years. Thus Bluebird dependency is completely unnecessary. Resolves alvarcarto#159
1 parent 4fd7b10 commit a3419ce

File tree

5 files changed

+1
-19
lines changed

5 files changed

+1
-19
lines changed

package-lock.json

Lines changed: 0 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
},
2323
"homepage": "https://github.com/alvarcarto/url-to-pdf-api#readme",
2424
"dependencies": {
25-
"bluebird": "^3.5.0",
2625
"body-parser": "^1.18.2",
2726
"compression": "^1.7.1",
2827
"cors": "^2.8.4",

src/index.js

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,8 @@
11
const createApp = require('./app');
22
const enableDestroy = require('server-destroy');
3-
const BPromise = require('bluebird');
43
const logger = require('./util/logger')(__filename);
54
const config = require('./config');
65

7-
BPromise.config({
8-
warnings: config.NODE_ENV !== 'production',
9-
longStackTraces: true,
10-
});
11-
126
const app = createApp();
137
const server = app.listen(config.PORT, () => {
148
logger.info(

src/util/express.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
const _ = require('lodash');
2-
const BPromise = require('bluebird');
32

43
// Route which assumes that the Promise `func` returns, will be resolved
54
// with data which will be sent as json response.
@@ -28,7 +27,7 @@ function createRoute(func, responseHandler) {
2827
let valuePromise = callback();
2928
if (!_.isFunction(_.get(valuePromise, 'then'))) {
3029
// It was a not a Promise, so wrap it as a Promise
31-
valuePromise = BPromise.resolve(valuePromise);
30+
valuePromise = Promise.resolve(valuePromise);
3231
}
3332

3433
if (_.isFunction(responseHandler)) {

test/test-all.js

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,12 @@
33
const chai = require('chai');
44
const fs = require('fs');
55
const request = require('supertest');
6-
const BPromise = require('bluebird');
76
const { getResource } = require('./util');
87
const pdf = require('pdf-parse');
98
const createApp = require('../src/app');
109

1110
const DEBUG = false;
1211

13-
BPromise.config({
14-
longStackTraces: true,
15-
});
16-
1712
const app = createApp();
1813

1914
function normalisePdfText(text) {

0 commit comments

Comments
 (0)