[5.4] code cleanup

Author: janschoenherr

components/com_users/tmpl/login/default_logout.php

@@ -25,7 +25,7 @@
     </div>
     <?php endif; ?>
 
-    <?php if (($this->params->get('logoutdescription_show') == 1 && str_replace(' ', '', $this->params->get('logout_description', '')) != '') || $this->params->get('logout_image') != '') : ?>
+    <?php if (($this->params->get('logoutdescription_show') == 1 && trim($this->params->get('logout_description', '')) != '') || $this->params->get('logout_image') != '') : ?>
         <div class="com-users-logout__description logout-description">
     <?php endif; ?>
 
@@ -37,7 +37,7 @@
         <?php echo HTMLHelper::_('image', $this->params->get('logout_image'), empty($this->params->get('logout_image_alt')) && empty($this->params->get('logout_image_alt_empty')) ? false : $this->params->get('logout_image_alt'), ['class' => 'com-users-logout__image thumbnail float-end logout-image']); ?>
     <?php endif; ?>
 
-    <?php if (($this->params->get('logoutdescription_show') == 1 && str_replace(' ', '', $this->params->get('logout_description', '')) != '') || $this->params->get('logout_image') != '') : ?>
+    <?php if (($this->params->get('logoutdescription_show') == 1 && trim($this->params->get('logout_description', '')) != '') || $this->params->get('logout_image') != '') : ?>
         </div>
     <?php endif; ?>
 

templates/cassiopeia/offline.php

@@ -111,7 +111,7 @@
             <?php if ($app->get('offline_image')) : ?>
                 <?php echo HTMLHelper::_('image', $app->get('offline_image'), $sitename, [], false, 0); ?>
             <?php endif; ?>
-            <?php if ($app->get('display_offline_message', 1) == 1 && str_replace(' ', '', $app->get('offline_message')) != '') : ?>
+            <?php if ($app->get('display_offline_message', 1) == 1 && trim($app->get('offline_message')) != '') : ?>
                 <p><?php echo $app->get('offline_message'); ?></p>
             <?php elseif ($app->get('display_offline_message', 1) == 2) : ?>
                 <p><?php echo Text::_('JOFFLINE_MESSAGE'); ?></p>

templates/system/offline.php

@@ -42,11 +42,11 @@
         <h1>
             <?php echo htmlspecialchars($app->get('sitename'), ENT_COMPAT, 'UTF-8'); ?>
         </h1>
-    <?php if ($app->get('display_offline_message', 1) == 1 && str_replace(' ', '', $app->get('offline_message')) !== '') : ?>
+    <?php if ($app->get('display_offline_message', 1) == 1 && trim($app->get('offline_message')) !== '') : ?>
         <p>
             <?php echo $app->get('offline_message'); ?>
         </p>
-    <?php elseif ($app->get('display_offline_message', 1) == 2 && str_replace(' ', '', Text::_('JOFFLINE_MESSAGE')) !== '') : ?>
+    <?php elseif ($app->get('display_offline_message', 1) == 2 && trim(Text::_('JOFFLINE_MESSAGE')) !== '') : ?>
         <p>
             <?php echo Text::_('JOFFLINE_MESSAGE'); ?>
         </p>