Skip to content

Consider duplicating sync/async code vs relying on async_to_sync from asgiref #96

@joshuadavidthomas

Description

@joshuadavidthomas

Initially used the methods from asgiref to cut down on the duplication needed to maintain sync and async flavors of the code, but I have run into issues in implementing and testing #90 that I'm starting to think it would just be simpler to have the code duplicated instead of relying on async_to_sync. On top of that, the sync version then wouldn't have the overhead of dealing with event loops and coroutines when they aren't used at all. (I'm sure the perf overhead is negligible, but still...)

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions