Documentation for console-launcher seem to miss exit code -1

[laeubi]

I go to https://docs.junit.org/current/user-guide/#running-tests-console-launcher and it says:

The ConsoleLauncher exits with a status code of 1 if any containers or tests failed. If no tests are discovered and the --fail-if-no-tests command-line option is supplied, the ConsoleLauncher exits with a status code of 2. Otherwise, the exit code is 0.

But I found that in case no test-engine is found -1 is returned (or maybe in other cases as well?).

It would be good to know other exits codes as well as I'm currently work on integrate the launcher with another application and want to give good error messages if something fails.

[sormuras]

All non-zero error codes are bad.

[laeubi]

All non-zero error codes are bad.

That's for sure but it seems wasteful if we have 2147483648 possible values to not tell to the caller whats going wrong :-)

Its of course not very important but something I noticed and could improve integrations.

[sormuras]

Here

junit-framework/junit-platform-console/src/main/java/org/junit/platform/console/command/ExecuteTestsCommand.java

Lines 38 to 46 in 7ea280a

	/**
	* Exit code indicating test failure(s)
	*/
	private static final int TEST_FAILED = 1;
	/**
	* Exit code indicating no tests found
	*/
	private static final int NO_TESTS_FOUND = 2;

are two exit codes defined and documented for the execute tests command. There doesn't seem to exist something similar for the discover command nor for other top-level commands of the junit tool. I'll create an enum a constant collection named ExitCode to gather all such codes in a single place.