From da5a5abafa9cf56c966a03e85de9684259bfd038 Mon Sep 17 00:00:00 2001 From: Jordan Bradford <36420801+jrdnbradford@users.noreply.github.com> Date: Sun, 28 Sep 2025 14:18:51 -0400 Subject: [PATCH] Only warn on failed install from requirements url --- tljh/installer.py | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/tljh/installer.py b/tljh/installer.py index aacd03a7..e02757f5 100644 --- a/tljh/installer.py +++ b/tljh/installer.py @@ -293,12 +293,16 @@ def ensure_user_environment(user_requirements_txt_file): ) if user_requirements_txt_file: - # FIXME: This currently fails hard, should fail soft and not abort installer - conda.ensure_pip_requirements( - USER_ENV_PREFIX, - user_requirements_txt_file, - upgrade=True, - ) + try: + conda.ensure_pip_requirements( + USER_ENV_PREFIX, + user_requirements_txt_file, + upgrade=True, + ) + except Exception as e: + logger.warning( + f"Failed to install requirements for user env from {user_requirements_txt_file}: {e}" + ) def ensure_admins(admin_password_list): @@ -530,7 +534,7 @@ def main(): ensure_admins(args.admin) ensure_usergroups() if args.user_requirements_txt_url: - logger.info("installing packages from user_requirements_txt_url") + logger.info("Installing packages from user_requirements_txt_url") ensure_user_environment(args.user_requirements_txt_url) logger.info("Setting up JupyterHub...")