Skip to content

encodeBinaryJSON, decodeBinaryJSON error handling and flags #228

@jscheid

Description

@jscheid

Hi, thanks for this lib. I'm working on small improvements to encodeBinaryJSON and decodeBinaryJSON:

  • Return a QuickJSContextResult<QuickJSHandle> instead of a QuickJSHandle, to surface any errors.
  • Accept flags and pass them through, instead of hardwiring JS_WRITE_OBJ_REFERENCE for encode and no flags for decode.

I've noticed that there are a few PRs open and not much activity in recent months, so before I open a new PR I just wanted to check to see if you're interested in these improvements? If so we'd also have to discuss backward compatibility.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions