Skip to content

Feature Request: add prop for sharp edges in generateStageSvgPathString function #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aggieN opened this issue May 7, 2025 · 1 comment

Comments

@aggieN
Copy link

aggieN commented May 7, 2025

Hey team,

I have a suggestion for the generateStageSvgPathString function. It would be great if we could add a prop to the StageDefinition interface to allow sharp edges for the highlight box. Right now, it only supports rounded edges with stageRadius.

Proposed Change:

Add a sharpEdges prop to StageDefinition. If sharpEdges is true, the function should generate sharp edges instead of rounded ones.

Example:

const stageDefinition: StageDefinition = {
  x: 100,
  y: 100,
  width: 200,
  height: 200,
  sharpEdges: true, 
};

const pathString = generateStageSvgPathString(stageDefinition);

This would give more flexibility in how the highlight box looks. Let me know if this is something you'd consider. Happy to help with a pull request if needed.

Thanks!

Best,
Aga

@jarikmarwede
Copy link
Contributor

Are you looking for the stageRadius configuration option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants