v1.4.2 to fix libb64 fallthrough compile warning

khoih-prog · web-flow · commit d7f3a7b25fdb · 2022-01-11T21:02:39.000-05:00
### Releases v1.4.2

1. Fix libb64 `fallthrough` compile warnings
diff --git a/src/EthernetHttpClient_SSL_STM32.h b/src/EthernetHttpClient_SSL_STM32.h
@@ -8,7 +8,7 @@
   Built by Khoi Hoang https://github.com/khoih-prog/EthernetWebServer_STM32
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -22,6 +22,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
 
 // Library to simplify HTTP fetching on Arduino
diff --git a/src/EthernetWebServer_SSL_STM32-impl.h b/src/EthernetWebServer_SSL_STM32-impl.h
@@ -11,7 +11,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
 
 #pragma once
diff --git a/src/EthernetWebServer_SSL_STM32.h b/src/EthernetWebServer_SSL_STM32.h
@@ -11,7 +11,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
 
 #pragma once
@@ -35,13 +36,13 @@
  #error This code is designed to run on STM32F/L/H/G/WB/MP1 platform! Please check your Tools->Board setting.
 #endif
 
-#define ETHERNET_WEBSERVER_SSL_STM32_VERSION      "EthernetWebServer_SSL_STM32 v1.4.1"
+#define ETHERNET_WEBSERVER_SSL_STM32_VERSION      "EthernetWebServer_SSL_STM32 v1.4.2"
 
 #define ETHERNET_WEBSERVER_SSL_STM32_VERSION_MAJOR    1
 #define ETHERNET_WEBSERVER_SSL_STM32_VERSION_MINOR    4
-#define ETHERNET_WEBSERVER_SSL_STM32_VERSION_PATCH    1
+#define ETHERNET_WEBSERVER_SSL_STM32_VERSION_PATCH    2
 
-#define ETHERNET_WEBSERVER_SSL_STM32_VERSION_INT      1004001
+#define ETHERNET_WEBSERVER_SSL_STM32_VERSION_INT      1004002
 
 #define USE_NEW_WEBSERVER_VERSION     true
 
diff --git a/src/Ethernet_HTTPClient/Ethernet_HttpClient.cpp b/src/Ethernet_HTTPClient/Ethernet_HttpClient.cpp
@@ -11,7 +11,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
  
 // Class to simplify HTTP fetching on Arduino
diff --git a/src/Ethernet_HTTPClient/Ethernet_HttpClient.h b/src/Ethernet_HTTPClient/Ethernet_HttpClient.h
@@ -11,7 +11,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
 
 // Class to simplify HTTP fetching on Arduino
diff --git a/src/Ethernet_HTTPClient/Ethernet_URLEncoder.cpp b/src/Ethernet_HTTPClient/Ethernet_URLEncoder.cpp
@@ -11,7 +11,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
 
 // Library to simplify HTTP fetching on Arduino
diff --git a/src/Ethernet_HTTPClient/Ethernet_URLEncoder.h b/src/Ethernet_HTTPClient/Ethernet_URLEncoder.h
@@ -11,7 +11,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
  
 // Library to simplify HTTP fetching on Arduino
diff --git a/src/Ethernet_HTTPClient/Ethernet_WebSocketClient.cpp b/src/Ethernet_HTTPClient/Ethernet_WebSocketClient.cpp
@@ -11,7 +11,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
  
 // (c) Copyright Arduino. 2016
diff --git a/src/Ethernet_HTTPClient/Ethernet_WebSocketClient.h b/src/Ethernet_HTTPClient/Ethernet_WebSocketClient.h
@@ -11,7 +11,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
  
 // (c) Copyright Arduino. 2016
diff --git a/src/Parsing_SSL_STM32-impl.h b/src/Parsing_SSL_STM32-impl.h
@@ -11,7 +11,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
 
 #pragma once
diff --git a/src/detail/Debug_STM32.h b/src/detail/Debug_STM32.h
@@ -11,7 +11,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
 
 #pragma once
diff --git a/src/detail/RequestHandler_STM32.h b/src/detail/RequestHandler_STM32.h
@@ -11,7 +11,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
 
 #pragma once
diff --git a/src/detail/RequestHandlersImpl_STM32.h b/src/detail/RequestHandlersImpl_STM32.h
@@ -11,7 +11,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
 
 #pragma once
diff --git a/src/detail/mimetable.h b/src/detail/mimetable.h
@@ -11,7 +11,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -25,6 +25,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
  
 #ifndef __MIMETABLE_H__
diff --git a/src/inner.h b/src/inner.h
@@ -12,7 +12,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -26,6 +26,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
 
 #include "SSLClient/inner.h"
diff --git a/src/libb64/base64.cpp b/src/libb64/base64.cpp
@@ -12,7 +12,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -26,6 +26,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
 
 #include "base64.h"
diff --git a/src/libb64/base64.h b/src/libb64/base64.h
@@ -12,7 +12,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -26,6 +26,7 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *************************************************************************************************************************************/
  
 #pragma once
diff --git a/src/libb64/cdecode.c b/src/libb64/cdecode.c
@@ -12,7 +12,7 @@
        
   Licensed under MIT license
   
-  Version: 1.4.1
+  Version: 1.4.2
 
   Version Modified By   Date      Comments
   ------- -----------  ---------- -----------
@@ -26,11 +26,12 @@
   1.3.1   K Hoang      04/10/2021 Change option for PIO `lib_compat_mode` from default `soft` to `strict`. Update Packages Patches
   1.4.0   K Hoang      25/12/2021 Reduce usage of Arduino String with std::string. Fix bug
   1.4.1   K Hoang      27/12/2021 Fix wrong http status header bug and authenticate issue caused by libb64
+  1.4.2   K Hoang      11/01/2022 Fix libb64 fallthrough compile warning
  *****************************************************************************************************************************/
 
 #include "cdecode.h"
 
-int base64_decode_value(char value_in)
+int base64_decode_value(int value_in)
 {
   static const char decoding[] =
   { 62, -1, -1, -1, 63, 52, 53, 54, 55, 56, 57, 58, 59, 60, 61, -1, -1, -1, -2, -1, -1, -1, 0, 1, 2,
@@ -58,7 +59,7 @@ int base64_decode_block(const char* code_in, const int length_in, char* plaintex
 {
   const char* codechar = code_in;
   char* plainchar = plaintext_out;
-  char fragment;
+  int fragment;
 
   *plainchar = state_in->plainchar;
 
@@ -76,10 +77,12 @@ int base64_decode_block(const char* code_in, const int length_in, char* plaintex
             return plainchar - plaintext_out;
           }
 
-          fragment = (char)base64_decode_value(*codechar++);
+          fragment = base64_decode_value(*codechar++);
         } while (fragment < 0);
 
         *plainchar    = (fragment & 0x03f) << 2;
+        
+        // fall through
 
       case step_b:
         do
@@ -91,11 +94,13 @@ int base64_decode_block(const char* code_in, const int length_in, char* plaintex
             return plainchar - plaintext_out;
           }
 
-          fragment = (char)base64_decode_value(*codechar++);
+          fragment = base64_decode_value(*codechar++);
         } while (fragment < 0);
 
         *plainchar++ |= (fragment & 0x030) >> 4;
         *plainchar    = (fragment & 0x00f) << 4;
+        
+        // fall through
 
       case step_c:
         do
@@ -107,11 +112,13 @@ int base64_decode_block(const char* code_in, const int length_in, char* plaintex
             return plainchar - plaintext_out;
           }
 
-          fragment = (char)base64_decode_value(*codechar++);
+          fragment = base64_decode_value(*codechar++);
         } while (fragment < 0);
 
         *plainchar++ |= (fragment & 0x03c) >> 2;
         *plainchar    = (fragment & 0x003) << 6;
+        
+        // fall through
 
       case step_d:
         do
@@ -123,10 +130,12 @@ int base64_decode_block(const char* code_in, const int length_in, char* plaintex
             return plainchar - plaintext_out;
           }
 
-          fragment = (char)base64_decode_value(*codechar++);
+          fragment = base64_decode_value(*codechar++);
         } while (fragment < 0);
 
         *plainchar++   |= (fragment & 0x03f);
+        
+        // fall through
       }
   }
 
diff --git a/src/libb64/cdecode.h b/src/libb64/cdecode.h
diff --git a/src/libb64/cencode.c b/src/libb64/cencode.c
diff --git a/src/libb64/cencode.h b/src/libb64/cencode.h
diff --git a/src/time_macros.h b/src/time_macros.h
