Added additional logging

Signed-off-by: Konstantin Panchenko <kpanchen@konstantech.com>

Author: kpanchen

META-INF/MANIFEST.MF

@@ -11,15 +11,17 @@ Bundle-Version: 2.5.0.qualifier
 Import-Package: 
  com.google.gson,
  com.google.gson.annotations,
+ javax.measure.quantity,
  org.apache.commons.lang,
  org.eclipse.jdt.annotation;resolution:=optional,
- org.eclipse.jetty.client;version="9.4.11",
- org.eclipse.jetty.client.api;version="9.4.11",
- org.eclipse.jetty.client.util;version="9.4.11",
- org.eclipse.jetty.http;version="9.4.11",
- org.eclipse.jetty.util;version="9.4.11",
- org.eclipse.jetty.util.component;version="9.4.11",
+ org.eclipse.jetty.client,
+ org.eclipse.jetty.client.api,
+ org.eclipse.jetty.client.util,
+ org.eclipse.jetty.http,
+ org.eclipse.jetty.util,
+ org.eclipse.jetty.util.component,
  org.eclipse.smarthome.config.core,
+ org.eclipse.smarthome.config.discovery,
  org.eclipse.smarthome.core.library.types,
  org.eclipse.smarthome.core.library.unit,
  org.eclipse.smarthome.core.thing,
@@ -28,10 +30,8 @@ Import-Package:
  org.eclipse.smarthome.core.thing.type,
  org.eclipse.smarthome.core.types,
  org.eclipse.smarthome.core.util,
+ org.eclipse.smarthome.io.net.http,
+ org.osgi.framework,
  org.slf4j
 Service-Component: OSGI-INF/*.xml
-Require-Bundle: org.eclipse.smarthome.config.discovery,
- org.eclipse.smarthome.io.net,
- org.apache.commons.lang,
- javax.measure.unit-api,
- org.eclipse.osgi
+

README.md

@@ -60,23 +60,23 @@ HeatSetPoint - Heat set point for the zone (Read / Write)<br />
 Thing example:
 
 ```
-Bridge icomfortwifi:account:demoaccount "My Acoount" @ "My House" [ userName = "johndoe", password = "supersecret", refreshInterval = 60] {<br />
-    Thing zone home_zone_1 "Zone 1" @ "Whole House" [ id = "WS12A34567_0", name = "Main Zone" ]<br />
-}<br />
+Bridge icomfortwifi:account:demoaccount "My Acoount" @ "My House" [ userName = "johndoe", password = "supersecret", refreshInterval = 60] {
+    Thing zone home_zone_1 "Zone 1" @ "Whole House" [ id = "WS12A34567_0", name = "Main Zone" ]
+}
 ```
 
 Items example:
 
 ```
-//Zone items<br />
-Number:Temperature Thermostat_Temperature "Temperature [%.1f %unit%]" <temperature> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:Temperature"}<br />
-Number:Dimensionless Thermostat_Humudity "Humidity [%.1f %unit%]" <humidity> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:Humidity"}<br />
-String Thermostat_Status "System Status [%s]" <heating> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:SystemStatus"}<br />
-String Thermostat_Mode "Operation Mode [%s]" <heating> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:OperationMode"}<br />
-String Thermostat_Away_Mode "Away Mode [%s]" <heating> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:AwayMode"}<br />
-String Thermostat_Fan_Mode "Fan Mode [%s]" <fan> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:FanMode"}<br />
-Number:Temperature Thermostat_Cool_Point    "Cool Set Point [%.1f %unit%]" <temperature> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:CoolSetPoint"}<br />
-Number:Temperature Thermostat_Heat_Point    "Heat Set Point [%.1f %unit%]" <temperature> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:HeatSetPoint"}<br />
+//Zone items
+Number:Temperature Thermostat_Temperature "Temperature [%.1f %unit%]" <temperature> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:Temperature"}
+Number:Dimensionless Thermostat_Humudity "Humidity [%.1f %unit%]" <humidity> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:Humidity"}
+String Thermostat_Status "System Status [%s]" <heating> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:SystemStatus"}
+String Thermostat_Mode "Operation Mode [%s]" <heating> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:OperationMode"}
+String Thermostat_Away_Mode "Away Mode [%s]" <heating> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:AwayMode"}
+String Thermostat_Fan_Mode "Fan Mode [%s]" <fan> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:FanMode"}
+Number:Temperature Thermostat_Cool_Point    "Cool Set Point [%.1f %unit%]" <temperature> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:CoolSetPoint"}
+Number:Temperature Thermostat_Heat_Point    "Heat Set Point [%.1f %unit%]" <temperature> (gWholeHouse) {channel="icomfortwifi:zone:demoaccount:home_zone_1:HeatSetPoint"}
 ```
 
 ## Foot note!

src/main/java/org/openhab/binding/icomfortwifi/handler/iComfortWiFiHeatingZoneHandler.java

@@ -9,7 +9,6 @@
 package org.openhab.binding.icomfortwifi.handler;
 
 import javax.measure.quantity.Temperature;
-//import javax.measure.quantity.Time;
 
 import org.eclipse.smarthome.core.library.types.QuantityType;
 import org.eclipse.smarthome.core.library.types.StringType;
@@ -23,6 +22,8 @@
 import org.eclipse.smarthome.core.types.RefreshType;
 import org.openhab.binding.icomfortwifi.iComfortWiFiBindingConstants;
 import org.openhab.binding.icomfortwifi.internal.api.models.response.ZoneStatus;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * The {@link iComfortWiFiHeatingZoneHandler} is responsible for handling commands, which are
@@ -32,6 +33,7 @@
  */
 public class iComfortWiFiHeatingZoneHandler extends BaseiComfortWiFiHandler {
 
+    private final Logger logger = LoggerFactory.getLogger(iComfortWiFiHeatingZoneHandler.class);
     // private static final int CANCEL_SET_POINT_OVERRIDE = 0;
     private ThingStatus tcsStatus;
     private ZoneStatus zoneStatus;
@@ -82,6 +84,9 @@ public void update(ThingStatus tcsStatus, ZoneStatus zoneStatus) {
     @SuppressWarnings("unchecked")
     @Override
     public void handleCommand(ChannelUID channelUID, Command command) {
+        logger.debug("Entering Heating Zone Handler for Gateway {}, zone {}", zoneStatus.gatewaySN,
+                zoneStatus.zoneNumber);
+        logger.debug("Executing command {}", command.toString());
 
         if (command == RefreshType.REFRESH) {
             update(tcsStatus, zoneStatus);
@@ -93,6 +98,7 @@ public void handleCommand(ChannelUID channelUID, Command command) {
                     bridge.setZoneAwayMode(zoneStatus,
                             ZoneStatus.AwayStatus.valueOf(command.toString()).getAwayValue());
                 } else if (zoneStatus.awayMode == ZoneStatus.AwayStatus.AWAY_OFF) {
+                    logger.debug("Zone is not in Away mode, executing the command");
                     if (iComfortWiFiBindingConstants.ZONE_COOL_SET_POINT_CHANNEL.equals(channelId)
                             && command instanceof QuantityType) {
                         bridge.setZoneCoolingPoint(zoneStatus, ((QuantityType<Temperature>) command).doubleValue());
@@ -110,6 +116,8 @@ public void handleCommand(ChannelUID channelUID, Command command) {
                                 ZoneStatus.FanMode.valueOf(command.toString()).getFanModeValue());
 
                     }
+                } else {
+                    logger.debug("Zone is in Away mode, not executing the command");
                 }
             }
         }

src/main/java/org/openhab/binding/icomfortwifi/internal/api/iComfortWiFiApiClientException.java

@@ -16,6 +16,8 @@
  */
 public class iComfortWiFiApiClientException extends Exception {
 
+    private static final long serialVersionUID = 9991L;
+
     public iComfortWiFiApiClientException() {
     }