Skip to content

Argo-Workflows crd's not working #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Transmitt0r opened this issue Feb 14, 2023 · 2 comments · Fixed by #215 · May be fixed by #158
Closed

Argo-Workflows crd's not working #108

Transmitt0r opened this issue Feb 14, 2023 · 2 comments · Fixed by #215 · May be fixed by #158
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@Transmitt0r
Copy link

Hey everybody,
I was trying to write a simple tool to query argo-workflows and return the status. But from all the crd's in here only the workflowtaskresults worked. Do you have any idea why I don't get any generated code (except of the use statements at the top of the file) for the other crd's?

Thank you!

@clux
Copy link
Member

clux commented Feb 14, 2023

Thanks for the report. These are enormous CRDs (the main one is too big to even view on github 😓 ) and this project is still a bit early stage - there are still some bugs in here, and they are likely to be encountered on such a huge schema.

Still, this is how we can make it better; find error cases and improve by playing with this bigger dataset.

..when time allows.

Had a brief look at cronworkflows to confirm one and it spat out (with debug logs):

[2023-02-14T13:37:42Z DEBUG kopium::analyzer] with optional member sidecars of type Vec<CronWorkflowSpecWorkflowSpecTemplateDefaultsSidecars>
Error: missing items in array type

which i believe refers to this section in the schema:

https://github.com/argoproj/argo-workflows/blob/1322f26272b403bb300f276b808a43ba1db136dc/manifests/base/crds/full/argoproj.io_cronworkflows.yaml#L8647-L8657

so as a first step, we can extract that array item thing into a minimal test case (as per previous prs here) and hopefully we'll find isolated bits of logic that's wrong (worked in the past).

don't have time to look at this in the near future, so will put it as help wanted for now (sorry).

@clux clux added help wanted Extra attention is needed bug Something isn't working labels Feb 14, 2023
@clux clux linked a pull request Oct 17, 2023 that will close this issue
poelzi added a commit to poelzi/kopium that referenced this issue Mar 21, 2024
Fixes kube-rs#108

Argo workflows have 2 CRDs, minimal and full.
The full CRD is supposed to be used in the editor and can't be
installed in kubernetes, but provide full validation.
The minimal version has no validation and should be installed.

In `--relaxed` mode, entries like `inline: {}` are mapped to
object like hashmaps.
poelzi added a commit to poelzi/kopium that referenced this issue Mar 21, 2024
Fixes kube-rs#108

Argo workflows have 2 CRDs, minimal and full.
The full CRD is supposed to be used in the editor and can't be
installed in kubernetes, but provide full validation.
The minimal version has no validation and should be installed.

In `--relaxed` mode, entries like `inline: {}` are mapped to
object like hashmaps.
poelzi added a commit to poelzi/kopium that referenced this issue Mar 21, 2024
Fixes kube-rs#108

Argo workflows have 2 CRDs, minimal and full.
The full CRD is supposed to be used in the editor and can't be
installed in kubernetes, but provide full validation.
The minimal version has no validation and should be installed.

In `--relaxed` mode, entries like `inline: {}` are mapped to
object like hashmaps.

Signed-off-by: Daniel Poelzleithner <poelzleithner@b1-systems.de>
@clux clux closed this as completed in #215 Apr 1, 2024
@Transmitt0r
Copy link
Author

Wow nice, thanks @poelzi and @clux!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants