Skip to content

Commit 03633d4

Browse files
committed
docs: eip service annotation - mention subnet discovery
1 parent 9e9432b commit 03633d4

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

docs/guide/service/annotations.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ on the load balancer.
152152

153153
!!!note
154154
- This configuration is optional, and you can use it to assign static IP addresses to your NLB
155-
- You must specify the same number of eip allocations as load balancer subnets [annotation](#subnets)
155+
- You must specify the same number of eip allocations as load balancer subnets ([annotation](#subnets) or [discovery](../../deploy/subnet_discovery.md))
156156
- NLB must be internet-facing
157157

158158
!!!example

pkg/service/model_build_load_balancer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ func (t *defaultModelBuildTask) buildLoadBalancerSubnets(ctx context.Context, sc
416416
)
417417
}
418418

419-
// for internet-facing Load Balancers, the subnets mush have at least 8 available IP addresses;
419+
// for internet-facing Load Balancers, the subnets must have at least 8 available IP addresses;
420420
// for internal Load Balancers, this is only required if private ip address is not assigned
421421
var privateIpv4Addresses []string
422422
ipv4Configured := t.annotationParser.ParseStringSliceAnnotation(annotations.SvcLBSuffixPrivateIpv4Addresses, &privateIpv4Addresses, t.service.Annotations)

0 commit comments

Comments
 (0)