From e1dc6fd864fffbe5071ec9c21caad7d911840e85 Mon Sep 17 00:00:00 2001 From: Andrey Lebedev Date: Thu, 23 May 2024 00:29:14 +0200 Subject: [PATCH] docs: eip service annotation - mention subnet discovery --- docs/guide/service/annotations.md | 2 +- pkg/service/model_build_load_balancer.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/guide/service/annotations.md b/docs/guide/service/annotations.md index f56d0419c8..5476d4b8b4 100644 --- a/docs/guide/service/annotations.md +++ b/docs/guide/service/annotations.md @@ -152,7 +152,7 @@ on the load balancer. !!!note - This configuration is optional, and you can use it to assign static IP addresses to your NLB - - You must specify the same number of eip allocations as load balancer subnets [annotation](#subnets) + - You must specify the same number of eip allocations as load balancer subnets ([annotation](#subnets) or [discovery](../../deploy/subnet_discovery.md)) - NLB must be internet-facing !!!example diff --git a/pkg/service/model_build_load_balancer.go b/pkg/service/model_build_load_balancer.go index 1a645205da..8726008c3a 100644 --- a/pkg/service/model_build_load_balancer.go +++ b/pkg/service/model_build_load_balancer.go @@ -416,7 +416,7 @@ func (t *defaultModelBuildTask) buildLoadBalancerSubnets(ctx context.Context, sc ) } - // for internet-facing Load Balancers, the subnets mush have at least 8 available IP addresses; + // for internet-facing Load Balancers, the subnets must have at least 8 available IP addresses; // for internal Load Balancers, this is only required if private ip address is not assigned var privateIpv4Addresses []string ipv4Configured := t.annotationParser.ParseStringSliceAnnotation(annotations.SvcLBSuffixPrivateIpv4Addresses, &privateIpv4Addresses, t.service.Annotations)