Fixed linting issues

Author: irapandey

internal/util/tree/tree.go

@@ -123,7 +123,10 @@ func PrintObjectTree(tree *tree.ObjectTree, w io.Writer) {
 	addObjectRow("", tbl, tree, tree.GetRoot())
 
 	// Prints the output table
-	tbl.Render()
+	if err := tbl.Render(); err != nil {
+		fmt.Printf("Error rendering table: %v", err)
+		os.Exit(1)
+	}
 }
 
 // PrintObjectTreeV1Beta1 prints the cluster status to stdout.
@@ -136,7 +139,10 @@ func PrintObjectTreeV1Beta1(tree *tree.ObjectTree) {
 	addObjectRowV1Beta1("", tbl, tree, tree.GetRoot())
 
 	// Prints the output table
-	tbl.Render()
+	if err := tbl.Render(); err != nil {
+		fmt.Printf("Error rendering table: %v", err)
+		os.Exit(1)
+	}
 }
 
 // addObjectRow add a row for a given object, and recursively for all the object's children.
@@ -179,7 +185,7 @@ func addObjectRow(prefix string, tbl *tablewriter.Table, objectTree *tree.Object
 	if len(msg) >= 1 {
 		msg0 = msg[0]
 	}
-	tbl.Append([]string{
+	if err := tbl.Append([]string{
 		fmt.Sprintf("%s%s", gray.Sprint(prefix), name),
 		rowDescriptor.replicas,
 		rowDescriptor.availableCounters,
@@ -188,11 +194,14 @@ func addObjectRow(prefix string, tbl *tablewriter.Table, objectTree *tree.Object
 		rowDescriptor.status,
 		rowDescriptor.reason,
 		rowDescriptor.age,
-		msg0})
+		msg0}); err != nil {
+		fmt.Printf("Error appending row: %v", err)
+		os.Exit(1)
+	}
 
 	multilinePrefix := getRootMultiLineObjectPrefix(obj, objectTree)
 	for _, m := range msg[1:] {
-		tbl.Append([]string{
+		if err := tbl.Append([]string{
 			gray.Sprint(multilinePrefix),
 			"",
 			"",
@@ -201,7 +210,10 @@ func addObjectRow(prefix string, tbl *tablewriter.Table, objectTree *tree.Object
 			"",
 			"",
 			"",
-			m})
+			m}); err != nil {
+			fmt.Printf("Error appending row: %v", err)
+			os.Exit(1)
+		}
 	}
 
 	// If it is required to show all the conditions for the object, add a row for each object's conditions.
@@ -259,13 +271,16 @@ func addObjectRowV1Beta1(prefix string, tbl *tablewriter.Table, objectTree *tree
 	// Add the row representing the object that includes
 	// - The row name with the tree view prefix.
 	// - The object's ready condition.
-	tbl.Append([]string{
+	if err := tbl.Append([]string{
 		fmt.Sprintf("%s%s", gray.Sprint(prefix), name),
 		readyDescriptor.readyColor.Sprint(readyDescriptor.status),
 		readyDescriptor.readyColor.Sprint(readyDescriptor.severity),
 		readyDescriptor.readyColor.Sprint(readyDescriptor.reason),
 		readyDescriptor.age,
-		readyDescriptor.message})
+		readyDescriptor.message}); err != nil {
+		fmt.Printf("Error appending row: %v", err)
+		os.Exit(1)
+	}
 
 	// If it is required to show all the conditions for the object, add a row for each object's conditions.
 	if tree.IsShowConditionsObject(obj) {
@@ -330,7 +345,7 @@ func addOtherConditions(prefix string, tbl *tablewriter.Table, objectTree *tree.
 		if len(msg) >= 1 {
 			msg0 = msg[0]
 		}
-		tbl.Append([]string{
+		if err := tbl.Append([]string{
 			fmt.Sprintf("%s%s", gray.Sprint(childPrefix), cyan.Sprint(condition.Type)),
 			"",
 			"",
@@ -339,10 +354,13 @@ func addOtherConditions(prefix string, tbl *tablewriter.Table, objectTree *tree.
 			c.Sprint(status),
 			reason,
 			age,
-			msg0})
+			msg0}); err != nil {
+			fmt.Printf("Error appending row: %v", err)
+			os.Exit(1)
+		}
 
 		for _, m := range msg[1:] {
-			tbl.Append([]string{
+			if err := tbl.Append([]string{
 				gray.Sprint(getMultilineConditionPrefix(childPrefix)),
 				"",
 				"",
@@ -351,7 +369,10 @@ func addOtherConditions(prefix string, tbl *tablewriter.Table, objectTree *tree.
 				"",
 				"",
 				"",
-				m})
+				m}); err != nil {
+				fmt.Printf("Error appending row: %v", err)
+				os.Exit(1)
+			}
 		}
 	}
 }
@@ -373,13 +394,16 @@ func addOtherConditionsV1Beta1(prefix string, tbl *tablewriter.Table, objectTree
 		otherCondition := otherConditions[i]
 		otherDescriptor := newV1Beta1ConditionDescriptor(otherCondition)
 		otherConditionPrefix := getChildPrefix(prefix+childrenPipe+filler, i, len(otherConditions))
-		tbl.Append([]string{
+		if err := tbl.Append([]string{
 			fmt.Sprintf("%s%s", gray.Sprint(otherConditionPrefix), cyan.Sprint(otherCondition.Type)),
 			otherDescriptor.readyColor.Sprint(otherDescriptor.status),
 			otherDescriptor.readyColor.Sprint(otherDescriptor.severity),
 			otherDescriptor.readyColor.Sprint(otherDescriptor.reason),
 			otherDescriptor.age,
-			otherDescriptor.message})
+			otherDescriptor.message}); err != nil {
+			fmt.Printf("Error appending row: %v", err)
+			os.Exit(1)
+		}
 	}
 }
 

internal/util/tree/tree_test.go

@@ -19,12 +19,11 @@ package tree
 import (
 	"bytes"
 	"fmt"
+	"os"
 	"strings"
 	"testing"
 
 	"github.com/fatih/color"
-	// "github.com/olekukonko/tablewriter"
-	// "github.com/olekukonko/tablewriter/tw".
 	. "github.com/onsi/gomega"
 	gtype "github.com/onsi/gomega/types"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
@@ -284,8 +283,10 @@ func Test_V1Beta1TreePrefix(t *testing.T) {
 
 			// Add row for the root object, the cluster, and recursively for all the nodes representing the cluster status.
 			addObjectRowV1Beta1("", tbl, tt.objectTree, tt.objectTree.GetRoot())
-			tbl.Render()
-
+			if err := tbl.Render(); err != nil {
+				fmt.Printf("Error rendering table: %v", err)
+				os.Exit(1)
+			}
 			// Compare the output with the expected prefix.
 			// We only check whether the output starts with the expected prefix,
 			// meaning expectPrefix does not contain the full expected output.
@@ -512,8 +513,11 @@ func Test_TreePrefix(t *testing.T) {
 
 			// Add row for the root object, the cluster, and recursively for all the nodes representing the cluster status.
 			addObjectRow("", tbl, tt.objectTree, tt.objectTree.GetRoot())
-			tbl.Render()
 
+			if err := tbl.Render(); err != nil {
+				fmt.Printf("Error rendering table: %v", err)
+				os.Exit(1)
+			}
 			// Remove empty lines from the output. We need this because v1beta2 adds lines at the beginning and end.
 			outputString := strings.TrimSpace(output.String())
 

test/go.sum

@@ -259,8 +259,8 @@ github.com/prometheus/procfs v0.15.1/go.mod h1:fB45yRUv8NstnjriLhBQLuOUt+WW4BsoG
 github.com/rivo/uniseg v0.2.0/go.mod h1:J6wj4VEh+S6ZtnVlnTBMWIodfgj8LQOQFoIToxlJtxc=
 github.com/rivo/uniseg v0.4.7 h1:WUdvkW8uEhrYfLC4ZzdpI2ztxP1I582+49Oc5Mq64VQ=
 github.com/rivo/uniseg v0.4.7/go.mod h1:FN3SvrM+Zdj16jyLfmOkMNblXMcoc8DfTHruCPUcx88=
-github.com/rogpeppe/go-internal v1.13.1 h1:KvO1DLK/DRN07sQ1LQKScxyZJuNnedQ5/wKSR38lUII=
-github.com/rogpeppe/go-internal v1.13.1/go.mod h1:uMEvuHeurkdAXX61udpOXGD/AzZDWNMNyH2VO9fmH0o=
+github.com/rogpeppe/go-internal v1.14.1 h1:UQB4HGPB6osV0SQTLymcB4TgvyWu6ZyliaW0tI/otEQ=
+github.com/rogpeppe/go-internal v1.14.1/go.mod h1:MaRKkUm5W0goXpeCfT7UZI6fk/L7L7so1lCWt35ZSgc=
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
 github.com/sagikazarmark/locafero v0.11.0 h1:1iurJgmM9G3PA/I+wWYIOw/5SyBtxapeHDcg+AAIFXc=
 github.com/sagikazarmark/locafero v0.11.0/go.mod h1:nVIGvgyzw595SUSUE6tvCp3YYTeHs15MvlmU87WwIik=