Skip to content

Commit 214d511

Browse files
committed
change feature-gate name
Signed-off-by: kerthcet <kerthcet@gmail.com>
1 parent 5adfc58 commit 214d511

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

keps/sig-scheduling/3094-pod-topology-spread-considering-taints/README.md

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -282,11 +282,13 @@ type TopologySpreadConstraint struct {
282282
There are two policies now regarding to nodeAffinity and nodeTaint:
283283
```golang
284284
type NodeInclusionPolicies struct {
285-
// Respect nodeAffinity/nodeSelector or not in calculating.
286-
// By default we will respect this policy.
285+
// NodeAffinity policy indicates how we will treat nodeAffinity/nodeSelector
286+
// when calculating pod topology spread skew. The value could be Respect/Ignore.
287+
// By default, the policy is Respect.
287288
NodeAffinity PolicyName
288-
// Respect all nodeTaints or not in calculating.
289-
// By default we will ignore this policy to maintain current behavior.
289+
// NodeTaint policy indicates how we will treat node taints
290+
// when calculating pod topology spread skew. The value could be Respect/Ignore.
291+
// By default, the policy is Ignore for backwards compatibility.
290292
NodeTaint PolicyName
291293
}
292294
```
@@ -397,7 +399,7 @@ in back-to-back releases.
397399
#### Beta
398400
- Feature is enabled by default
399401
- Benchmark tests passed, and there is no performance problem.
400-
- Gather feedback from developers and surveys.
402+
- Gather feedback from developers.
401403

402404
#### GA
403405
- No negative feedback.
@@ -417,12 +419,11 @@ enhancement:
417419
-->
418420

419421
- Upgrade
420-
- While the feature gate is disabled, field `NodeInclusionPolicies` will be ignored.
421422
- While the feature gate is enabled, `NodeInclusionPolicies` is allowed to use by end-users.
422423
- While the feature gate is enabled, and we don't set this field, default values
423424
will be configured, which will maintain previous behavior.
424425
- Downgrade
425-
- Whatever we enable/disable feature gate, previously configured values will be ignored.
426+
- Previously configured values will be ignored.
426427

427428
### Version Skew Strategy
428429
N/A
@@ -477,7 +478,7 @@ Pick one of these and delete the rest.
477478
-->
478479

479480
- [x] Feature gate (also fill in values in `kep.yaml`)
480-
- Feature gate name: PodTopologySpreadTaintPolicy
481+
- Feature gate name: PodTopologySpreadNodePolicies
481482
- Components depending on the feature gate: kube-scheduler, kube-apiserver
482483

483484
###### Does enabling the feature change any default behavior?
@@ -499,7 +500,7 @@ NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
499500
Yes.
500501

501502
###### What happens if we reenable the feature if it was previously rolled back?
502-
N/A.
503+
The policies are respected again.
503504

504505
###### Are there any tests for feature enablement/disablement?
505506
Yes, unit test will switch the feature gate manually to compare the different behavior.

keps/sig-scheduling/3094-pod-topology-spread-considering-taints/kep.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ milestone:
4141
# The following PRR answers are required at alpha release
4242
# List the feature gate name and the components for which it must be enabled
4343
feature-gates:
44-
- name: PodTopologySpreadTaintPolicy
44+
- name: PodTopologySpreadNodePolicies
4545
components:
4646
- kube-apiserver
4747
- kube-scheduler

0 commit comments

Comments
 (0)