@@ -282,11 +282,13 @@ type TopologySpreadConstraint struct {
282
282
There are two policies now regarding to nodeAffinity and nodeTaint:
283
283
``` golang
284
284
type NodeInclusionPolicies struct {
285
- // Respect nodeAffinity/nodeSelector or not in calculating.
286
- // By default we will respect this policy.
285
+ // NodeAffinity policy indicates how we will treat nodeAffinity/nodeSelector
286
+ // when calculating pod topology spread skew. The value could be Respect/Ignore.
287
+ // By default, the policy is Respect.
287
288
NodeAffinity PolicyName
288
- // Respect all nodeTaints or not in calculating.
289
- // By default we will ignore this policy to maintain current behavior.
289
+ // NodeTaint policy indicates how we will treat node taints
290
+ // when calculating pod topology spread skew. The value could be Respect/Ignore.
291
+ // By default, the policy is Ignore for backwards compatibility.
290
292
NodeTaint PolicyName
291
293
}
292
294
```
@@ -397,7 +399,7 @@ in back-to-back releases.
397
399
#### Beta
398
400
- Feature is enabled by default
399
401
- Benchmark tests passed, and there is no performance problem.
400
- - Gather feedback from developers and surveys .
402
+ - Gather feedback from developers.
401
403
402
404
#### GA
403
405
- No negative feedback.
@@ -417,12 +419,11 @@ enhancement:
417
419
-->
418
420
419
421
- Upgrade
420
- - While the feature gate is disabled, field ` NodeInclusionPolicies ` will be ignored.
421
422
- While the feature gate is enabled, ` NodeInclusionPolicies ` is allowed to use by end-users.
422
423
- While the feature gate is enabled, and we don't set this field, default values
423
424
will be configured, which will maintain previous behavior.
424
425
- Downgrade
425
- - Whatever we enable/disable feature gate, previously configured values will be ignored.
426
+ - Previously configured values will be ignored.
426
427
427
428
### Version Skew Strategy
428
429
N/A
@@ -477,7 +478,7 @@ Pick one of these and delete the rest.
477
478
-->
478
479
479
480
- [x] Feature gate (also fill in values in ` kep.yaml ` )
480
- - Feature gate name: PodTopologySpreadTaintPolicy
481
+ - Feature gate name: PodTopologySpreadNodePolicies
481
482
- Components depending on the feature gate: kube-scheduler, kube-apiserver
482
483
483
484
###### Does enabling the feature change any default behavior?
@@ -499,7 +500,7 @@ NOTE: Also set `disable-supported` to `true` or `false` in `kep.yaml`.
499
500
Yes.
500
501
501
502
###### What happens if we reenable the feature if it was previously rolled back?
502
- N/A .
503
+ The policies are respected again .
503
504
504
505
###### Are there any tests for feature enablement/disablement?
505
506
Yes, unit test will switch the feature gate manually to compare the different behavior.
0 commit comments