Merge pull request #313 from lablabs/feat/args_validation

Role argumentss validation

Author: MonolithProjects

.github/CONTRIBUTING.md

@@ -23,11 +23,13 @@ Install [Pre-commit](https://pre-commit.com/#install) software
 
 Do the changes in your own GitHub namespace.
 
-## 5. Test the changes
+## 5. Define new variables in argument_specs.yml
 
-**Note:** I will test the role again, so you don't need to do that if you don't want to.
+If you introduce any new variables, **you must also define them in the `meta/argument_specs.yml` file** with appropriate type, default, and description. This ensures proper validation and documentation for all role variables. Additionally, **add all new variables to the `README.md` file** (usually by updating the variables section, which is a copy of `defaults/main.yml`).
 
-Install [molecule](https://molecule.readthedocs.io/en/stable/) and run the test:
+## 6. Test the changes
+
+You can use Molecule for testing. Install [molecule](https://molecule.readthedocs.io/en/stable/) and run the test:
 
 ```bash
 pip install molecule molecule-docker ansible-lint docker
@@ -37,11 +39,11 @@ molecule test
 
 > You will need to edit the files in `molecule/default` directory (please do not commit those changes)
 
-## 6. Create a pull request
+## 7. Create a pull request
 
 Please create a pull request into the `main` branch. Here is [how to do it](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork).
 
-## 7. Semantic Commits
+## 8. Semantic Commits
 
 Commits must follow conventional specs below:
 

.github/workflows/lint.yml

@@ -7,7 +7,7 @@ on:
 
 jobs:
   lint:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-24.04
     strategy:
       fail-fast: true
     steps:

README.md

@@ -194,7 +194,7 @@ rke2_channel: stable
 
 # Do not deploy packaged components and delete any deployed components
 # Valid items: rke2-canal, rke2-coredns, rke2-ingress-nginx, rke2-metrics-server
-rke2_disable:
+rke2_disable: []
 
 # Option to disable kube-proxy
 disable_kube_proxy: false
@@ -210,10 +210,10 @@ rke2_cloud_provider_name: "external"
 
 # Path to custom manifests deployed during the RKE2 installation
 # It is possible to use Jinja2 templating in the manifests
-rke2_custom_manifests:
+rke2_custom_manifests: []
 
 # Path to static pods deployed during the RKE2 installation
-rke2_static_pods:
+rke2_static_pods: []
 
 # Configure custom Containerd Registry
 rke2_custom_registry_mirrors: []

defaults/main.yml

@@ -156,7 +156,7 @@ rke2_channel: stable
 
 # Do not deploy packaged components and delete any deployed components
 # Valid items: rke2-canal, rke2-coredns, rke2-ingress-nginx, rke2-metrics-server
-rke2_disable:
+rke2_disable: []
 
 # Option to disable kube-proxy
 disable_kube_proxy: false
@@ -172,10 +172,10 @@ rke2_cloud_provider_name: "external"
 
 # Path to custom manifests deployed during the RKE2 installation
 # It is possible to use Jinja2 templating in the manifests
-rke2_custom_manifests:
+rke2_custom_manifests: []
 
 # Path to static pods deployed during the RKE2 installation
-rke2_static_pods:
+rke2_static_pods: []
 
 # Configure custom Containerd Registry
 rke2_custom_registry_mirrors: []