From 9983e62de9dda66b920907b547cee3d68b7d3e28 Mon Sep 17 00:00:00 2001 From: Francisco Xavier Gauna Date: Tue, 27 May 2025 17:04:04 -0300 Subject: [PATCH 1/3] Update Dockerfile --- clients/ethrex/Dockerfile | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/clients/ethrex/Dockerfile b/clients/ethrex/Dockerfile index c7d3fb455f..b6fb13a377 100644 --- a/clients/ethrex/Dockerfile +++ b/clients/ethrex/Dockerfile @@ -1,7 +1,12 @@ -ARG baseimage=ghcr.io/lambdaclass/ethrex +# This is the image we build on a push to main +# We do have a problem, if we're testing locally it doesn't show changes +# Removing this from here now, but the upstream version should use the ghcr.io version +# ARG baseimage=ghcr.io/lambdaclass/ethrex +ARG baseimage=ethrex # We don + ARG tag=latest -FROM $baseimage:$tag as builder +FROM $baseimage:$tag AS builder # Install script tools. RUN apt-get update -y From 570d54064eb3108665183fdab7c94f18004e6fab Mon Sep 17 00:00:00 2001 From: Francisco Xavier Gauna Date: Tue, 27 May 2025 17:11:37 -0300 Subject: [PATCH 2/3] Clarified comment --- clients/ethrex/Dockerfile | 1 + 1 file changed, 1 insertion(+) diff --git a/clients/ethrex/Dockerfile b/clients/ethrex/Dockerfile index b6fb13a377..7c43ca97b0 100644 --- a/clients/ethrex/Dockerfile +++ b/clients/ethrex/Dockerfile @@ -1,6 +1,7 @@ # This is the image we build on a push to main # We do have a problem, if we're testing locally it doesn't show changes # Removing this from here now, but the upstream version should use the ghcr.io version +# For now, users needs to build locally ethrex # ARG baseimage=ghcr.io/lambdaclass/ethrex ARG baseimage=ethrex # We don From 2acde4ffe5590ea3cf24ce49d0bf273b3b6ee10f Mon Sep 17 00:00:00 2001 From: Francisco Xavier Gauna Date: Tue, 27 May 2025 17:59:42 -0300 Subject: [PATCH 3/3] we do --- clients/ethrex/Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/ethrex/Dockerfile b/clients/ethrex/Dockerfile index 7c43ca97b0..c518e6dd84 100644 --- a/clients/ethrex/Dockerfile +++ b/clients/ethrex/Dockerfile @@ -3,7 +3,7 @@ # Removing this from here now, but the upstream version should use the ghcr.io version # For now, users needs to build locally ethrex # ARG baseimage=ghcr.io/lambdaclass/ethrex -ARG baseimage=ethrex # We don +ARG baseimage=ethrex ARG tag=latest