fix: commit repository method wrong types

geclos · geclos · commit d59759a599e7 · 2025-10-02T11:36:18.000+02:00
diff --git a/apps/gateway/src/common/documents/getData.ts b/apps/gateway/src/common/documents/getData.ts
@@ -234,9 +234,7 @@ export async function publishDocumentRunRequestedEvent({
   const user = await findFirstUserInWorkspace(workspace)
 
   const commitsScope = new CommitsRepository(workspace.id)
-  const headCommit = await commitsScope
-    .getHeadCommit(project.id)
-    .then((r) => r.unwrap())
+  const headCommit = await commitsScope.getHeadCommit(project.id)
 
   if (user) {
     publisher.publishLater({
diff --git a/apps/gateway/src/routes/api/v3/projects/versions/get/getCommit.handler.ts b/apps/gateway/src/routes/api/v3/projects/versions/get/getCommit.handler.ts
@@ -4,7 +4,7 @@ import { BadRequestError } from '@latitude-data/constants/errors'
 import { AppRouteHandler } from '$/openApi/types'
 import { getVersionRoute } from './getCommit.route'
 
-// @ts-expect-error: broken types
+// @ts-expect-error: Types are not working as expected
 export const getVersionHandler: AppRouteHandler<
   typeof getVersionRoute
 > = async (c: Context) => {
diff --git a/apps/gateway/src/routes/webhook/integration/webhook.handler.ts b/apps/gateway/src/routes/webhook/integration/webhook.handler.ts
@@ -43,8 +43,7 @@ async function resolveWorkspaceAndCommit(
     return Result.ok({ workspace, commit })
   }
 
-  const headCommitResult = await commitsRepo.getHeadCommit(rawTrigger.projectId)
-  const commit = headCommitResult.unwrap()
+  const commit = await commitsRepo.getHeadCommit(rawTrigger.projectId)
   if (!commit) {
     return Result.error(
       new NotFoundError(
diff --git a/apps/web/src/actions/sdk/runDocumentAction.ts b/apps/web/src/actions/sdk/runDocumentAction.ts
@@ -33,9 +33,7 @@ export async function runDocumentAction({
   const { workspace, user } = await getCurrentUserOrRedirect()
 
   const commitsScope = new CommitsRepository(workspace.id)
-  const headCommit = await commitsScope
-    .getHeadCommit(projectId)
-    .then((r) => r.unwrap())
+  const headCommit = await commitsScope.getHeadCommit(projectId)
 
   publisher.publishLater({
     type: 'documentRunRequested',
diff --git a/apps/web/src/app/(private)/_data-access/index.ts b/apps/web/src/app/(private)/_data-access/index.ts
@@ -179,8 +179,7 @@ export const getHeadCommitCached = cache(
     projectId: number
   }) => {
     const commitsScope = new CommitsRepository(workspace.id)
-    const headCommitResult = await commitsScope.getHeadCommit(projectId)
-    return headCommitResult.value
+    return await commitsScope.getHeadCommit(projectId)
   },
 )
 
diff --git a/apps/web/src/app/api/documents/[documentUuid]/run/route.ts b/apps/web/src/app/api/documents/[documentUuid]/run/route.ts
@@ -65,9 +65,7 @@ export const POST = errorHandler(
         ).then((r) => r.unwrap())
 
         const commitsScope = new CommitsRepository(workspace.id)
-        const headCommit = await commitsScope
-          .getHeadCommit(projectId)
-          .then((r) => r.unwrap())
+        const headCommit = await commitsScope.getHeadCommit(projectId)
 
         // Publish document run event
         publisher.publishLater({
diff --git a/packages/core/src/lib/analytics/AnalyticsClient.ts b/packages/core/src/lib/analytics/AnalyticsClient.ts
@@ -78,7 +78,7 @@ export class AnalyticsClient {
 
     const repo = new WorkspacesRepository(user.id)
 
-    // TODO: remove, it's very expensive to have a read operation on each analytics event 
+    // TODO: remove, it's very expensive to have a read operation on each analytics event
     const result = await repo.find(this.workspaceId)
 
     if (result.error) return undefined
diff --git a/packages/core/src/repositories/commitsRepository/index.ts b/packages/core/src/repositories/commitsRepository/index.ts
@@ -71,12 +71,9 @@ export class CommitsRepository extends RepositoryLegacy<
         return Result.error(new NotFoundError('Project ID is required'))
       }
 
-      const headCommit = await this.getHeadCommit(projectId).then((r) =>
-        r.unwrap(),
-      )
-      if (!headCommit) {
+      const headCommit = await this.getHeadCommit(projectId)
+      if (!headCommit)
         return Result.error(new NotFoundError('Head commit not found'))
-      }
 
       return Result.ok(headCommit)
     }
diff --git a/packages/core/src/repositories/commitsRepository/utils/getHeadCommit.ts b/packages/core/src/repositories/commitsRepository/utils/getHeadCommit.ts
@@ -2,8 +2,8 @@ import { and, desc, eq, isNotNull } from 'drizzle-orm'
 
 import { database } from '../../../client'
 import { InferedReturnType } from '../../../lib/commonTypes'
-import { Result } from '../../../lib/Result'
 import { buildCommitsScope } from './buildCommitsScope'
+import { Commit } from '../../../browser'
 
 export async function getHeadCommitForProject(
   {
@@ -27,5 +27,5 @@ export async function getHeadCommitForProject(
     .orderBy(desc(commitsScope.mergedAt))
     .limit(1)
 
-  return Result.ok(result[0])
+  return result[0] as Commit | undefined
 }
diff --git a/packages/core/src/services/actions/cloneAgent.ts b/packages/core/src/services/actions/cloneAgent.ts
@@ -113,11 +113,7 @@ async function getSampleAgent(
   }
 
   const commitsRepository = new CommitsRepository(workspace.id, db)
-  const gettingco = await commitsRepository.getHeadCommit(project.id)
-  if (gettingco.error) {
-    return Result.error(gettingco.error)
-  }
-  const commit = gettingco.unwrap()
+  const commit = await commitsRepository.getHeadCommit(project.id)
   if (!commit) {
     return Result.error(
       new UnprocessableEntityError('Sample Agents commit not found'),
diff --git a/packages/core/src/services/copilot/get.ts b/packages/core/src/services/copilot/get.ts
@@ -36,9 +36,7 @@ export async function getCopilot({ path }: { path: string }, db = database) {
   }
 
   const commitsRepository = new CommitsRepository(workspace.id, db)
-  const commit = await commitsRepository
-    .getHeadCommit(env.COPILOT_PROJECT_ID)
-    .then((r) => r.unwrap())
+  const commit = await commitsRepository.getHeadCommit(env.COPILOT_PROJECT_ID)
   if (!commit) {
     return Result.error(new Error('Copilot commit not found'))
   }
diff --git a/packages/core/src/services/copilot/latte/helpers.ts b/packages/core/src/services/copilot/latte/helpers.ts
@@ -78,10 +78,7 @@ async function getCommitResult({
     })
   }
 
-  const headCommitResult = await commitScope.getHeadCommit(projectId)
-  if (!Result.isOk(headCommitResult)) return headCommitResult
-  const headCommit = headCommitResult.unwrap()
-
+  const headCommit = await commitScope.getHeadCommit(projectId)
   if (!headCommit) {
     return Result.error(
       new NotFoundError('Live commit not found in Latte project'),
diff --git a/packages/core/src/services/copilot/latte/tools/triggers/validateTriggerSchema.ts b/packages/core/src/services/copilot/latte/tools/triggers/validateTriggerSchema.ts
@@ -86,10 +86,7 @@ const validateDocumentReadyForCreatingTrigger = async ({
   promptUuid: string
 }): PromisedResult<boolean> => {
   const commitsScope = new CommitsRepository(workspaceId)
-  const headCommit = await commitsScope
-    .getHeadCommit(projectId)
-    .then((r) => r.unwrap())
-
+  const headCommit = await commitsScope.getHeadCommit(projectId)
   if (
     headCommit !== undefined &&
     (versionUuid === headCommit.uuid || versionUuid === HEAD_COMMIT)
@@ -111,11 +108,10 @@ const validateDocumentReadyForCreatingTrigger = async ({
     .then((r) => r.unwrap())
 
   const document = documents.find((doc) => doc.documentUuid === promptUuid)
-
   if (!document) {
     return Result.error(
       new NotFoundError(
-        `Document with UUID ${promptUuid} not found in commit ${headCommit.uuid}.`,
+        `Document with UUID ${promptUuid} not found in commit ${commit?.uuid ?? headCommit?.uuid}.`,
       ),
     )
   }
diff --git a/packages/core/src/services/documentTriggers/delete.ts b/packages/core/src/services/documentTriggers/delete.ts
@@ -33,11 +33,8 @@ async function getLiveDocumentTrigger<T extends DocumentTriggerType>(
 ): PromisedResult<DocumentTrigger<T> | undefined> {
   return transaction.call(async (tx) => {
     const commitsScope = new CommitsRepository(workspace.id, tx)
-    const liveCommitResult = await commitsScope.getHeadCommit(projectId)
-    if (!Result.isOk(liveCommitResult) || !liveCommitResult.value) {
-      return Result.ok(undefined)
-    }
-    const liveCommit = liveCommitResult.unwrap()
+    const liveCommit = await commitsScope.getHeadCommit(projectId)
+    if (!liveCommit) return Result.ok(undefined)
 
     const triggersScope = new DocumentTriggersRepository(workspace.id, tx)
     const liveTriggerResult = await triggersScope.getTriggerByUuid<T>({
diff --git a/packages/core/src/services/documentTriggers/enable.ts b/packages/core/src/services/documentTriggers/enable.ts
@@ -1,4 +1,8 @@
-import { BadRequestError, LatitudeError } from '@latitude-data/constants/errors'
+import {
+  BadRequestError,
+  LatitudeError,
+  NotFoundError,
+} from '@latitude-data/constants/errors'
 import { Commit, DocumentTrigger, Workspace } from '../../browser'
 import { Result } from '../../lib/Result'
 import Transaction, { PromisedResult } from '../../lib/Transaction'
@@ -29,9 +33,9 @@ export async function setDocumentTriggerEnabled<T extends DocumentTriggerType>(
 ): PromisedResult<DocumentTrigger<T>> {
   return await transaction.call(async (tx) => {
     const commitsScope = new CommitsRepository(workspace.id, tx)
-    const liveCommitResult = await commitsScope.getHeadCommit(commit.projectId)
-    if (!Result.isOk(liveCommitResult)) return liveCommitResult
-    const liveCommit = liveCommitResult.unwrap()
+    const liveCommit = await commitsScope.getHeadCommit(commit.projectId)
+    if (!liveCommit)
+      return Result.error(new NotFoundError('Head commit not found'))
 
     if (commit.uuid !== liveCommit?.uuid) {
       return Result.error(
diff --git a/packages/core/src/services/documentTriggers/handleMerge.ts b/packages/core/src/services/documentTriggers/handleMerge.ts
@@ -1,4 +1,4 @@
-import { BadRequestError } from '@latitude-data/constants/errors'
+import { BadRequestError, NotFoundError } from '@latitude-data/constants/errors'
 import { Commit, Workspace } from '../../browser'
 import { Result } from '../../lib/Result'
 import Transaction, { PromisedResult } from '../../lib/Transaction'
@@ -32,10 +32,9 @@ export async function handleTriggerMerge(
     const triggersScope = new DocumentTriggersRepository(workspace.id, tx)
     const commitsScope = new CommitsRepository(workspace.id, tx)
 
-    const liveCommitResult = await commitsScope.getHeadCommit(draft.projectId)
-    if (!Result.isOk(liveCommitResult)) return liveCommitResult
-
-    const liveCommit = liveCommitResult.unwrap()
+    const liveCommit = await commitsScope.getHeadCommit(draft.projectId)
+    if (!liveCommit)
+      return Result.error(new NotFoundError('Head commit not found'))
 
     const triggerUpdatesResult =
       await triggersScope.getTriggerUpdatesInDraft(draft)
diff --git a/packages/core/src/services/documentTriggers/handlers/email/registerEvent.ts b/packages/core/src/services/documentTriggers/handlers/email/registerEvent.ts
@@ -133,9 +133,7 @@ export async function registerEmailTriggerEvent(
   const uploadedFiles = uploadResult.unwrap()
 
   const commitsScope = new CommitsRepository(workspace.id, db)
-  const headCommitResult = await commitsScope.getHeadCommit(project.id)
-  if (headCommitResult.error) return Result.nil()
-  const headCommit = headCommitResult.unwrap()
+  const headCommit = await commitsScope.getHeadCommit(project.id)
 
   // TODO: Search the Live and all draft versions for each trigger, not just the Live one
   if (!headCommit) return Result.nil()
diff --git a/packages/core/src/services/documentTriggers/handlers/scheduled/registerEvents.ts b/packages/core/src/services/documentTriggers/handlers/scheduled/registerEvents.ts
@@ -98,11 +98,11 @@ async function registerSingleScheduledTriggerEvent(
       // However, the trigger's associated commit may not be the Live commit,
       // but rather just the last merged commit where it has been updated.
       // Thus, we need to find the Live commit
-      const liveCommitResult = await commitsScope.getHeadCommit(
+      const liveCommit = await commitsScope.getHeadCommit(
         documentTrigger.projectId,
       )
-      if (!Result.isOk(liveCommitResult)) return liveCommitResult
-      const liveCommit = liveCommitResult.unwrap()
+      if (!liveCommit)
+        return Result.error(new NotFoundError('Head commit not found'))
       eventCommit = liveCommit!
     }
 
diff --git a/packages/core/src/services/documentTriggers/helpers/getCommitFromTrigger.ts b/packages/core/src/services/documentTriggers/helpers/getCommitFromTrigger.ts
@@ -23,12 +23,9 @@ export async function getCommitFromTrigger(
     }
 
     // Commit is merged. This means that the latest commit active for this trigger is Live
-    const liveCommitResult = await commitsScope.getHeadCommit(
+    const liveCommit = await commitsScope.getHeadCommit(
       documentTrigger.projectId,
     )
-    if (!Result.isOk(liveCommitResult)) return liveCommitResult
-    const liveCommit = liveCommitResult.unwrap()
-
     if (!liveCommit) {
       return Result.error(
         new NotFoundError(
diff --git a/packages/core/src/services/documents/recomputeChanges/getHeadDocumentsAndDraftDocuments.ts b/packages/core/src/services/documents/recomputeChanges/getHeadDocumentsAndDraftDocuments.ts
@@ -1,3 +1,4 @@
+import { NotFoundError } from '@latitude-data/constants/errors'
 import { Commit } from '../../../browser'
 import { database } from '../../../client'
 import { Result } from '../../../lib/Result'
@@ -38,7 +39,8 @@ async function getDocumentsAtCommit(
   const headCommit = await getHeadCommitForProject(
     { projectId: projectResult.value.id, commitsScope },
     tx,
-  ).then((r) => r.unwrap())
+  )
+  if (!headCommit) return Result.error(new NotFoundError('No head commit found'))
 
   const docsScope = new DocumentVersionsRepository(workspaceId, tx)
   const headDocumentsResult = await docsScope.getDocumentsAtCommit(headCommit)
diff --git a/packages/core/src/services/documents/update.test.ts b/packages/core/src/services/documents/update.test.ts
@@ -7,6 +7,7 @@ import {
 } from '../../repositories'
 import { recomputeChanges } from './recomputeChanges'
 import { updateDocument } from './update'
+import { NotFoundError } from '@latitude-data/constants/errors'
 
 describe('updateDocument', () => {
   it('modifies a document that was created in a previous commit', async (ctx) => {
@@ -295,9 +296,8 @@ describe('updateDocument', () => {
     })
     const commitsScope = new CommitsRepository(project.workspaceId)
 
-    const commit = await commitsScope
-      .getHeadCommit(project.id)
-      .then((r) => r.unwrap())
+    const commit = await commitsScope.getHeadCommit(project.id)
+    if (!commit) throw new NotFoundError('Head commit not found')
     const fooDoc = documents.find((d) => d.path === 'foo')!
 
     const result = await updateDocument({
diff --git a/packages/core/src/services/history/resetDocumentToVersion.ts b/packages/core/src/services/history/resetDocumentToVersion.ts
@@ -1,3 +1,4 @@
+import { NotFoundError } from '@latitude-data/constants/errors'
 import { Commit, DraftChange, Project, User, Workspace } from '../../browser'
 import { Result } from '../../lib/Result'
 import { PromisedResult } from '../../lib/Transaction'
@@ -33,14 +34,14 @@ async function fetchDocumentVersionDetails({
       .then((r) => r.value)
 
     const commitScope = new CommitsRepository(workspace.id)
-    const headCommit = await commitScope
-      .getHeadCommit(project.id)
-      .then((r) => r.unwrap()!)
+    const headCommit = await commitScope.getHeadCommit(project.id)
+    if (!headCommit)
+      return Result.error(new NotFoundError('Head commit not found'))
 
     const targetCommit = targetDraftUuid
       ? await commitScope
-          .getCommitByUuid({ uuid: targetDraftUuid, projectId: project.id })
-          .then((r) => r.unwrap())
+        .getCommitByUuid({ uuid: targetDraftUuid, projectId: project.id })
+        .then((r) => r.unwrap())
       : headCommit
 
     const targetDocument = await docsScope
@@ -166,13 +167,13 @@ export async function resetDocumentToVersion({
   const targetDraftResult = targetDraftUuid
     ? Result.ok(targetCommit)
     : await createCommit({
-        project: project,
-        user: user,
-        data: {
-          title: `Reset "${oldDocumentPath}"`,
-          description: `Reset document "${oldDocumentPath}" to version "${targetCommit.title}"`,
-        },
-      })
+      project: project,
+      user: user,
+      data: {
+        title: `Reset "${oldDocumentPath}"`,
+        description: `Reset document "${oldDocumentPath}" to version "${targetCommit.title}"`,
+      },
+    })
 
   const targetDraft = targetDraftResult.unwrap()
 
diff --git a/packages/core/src/services/history/resetProjectToCommit.ts b/packages/core/src/services/history/resetProjectToCommit.ts
@@ -1,3 +1,4 @@
+import { NotFoundError } from '@latitude-data/constants/errors'
 import { Commit, DraftChange, Project, User, Workspace } from '../../browser'
 import { database } from '../../client'
 import { Result } from '../../lib/Result'
@@ -24,14 +25,14 @@ async function fetchCommitDetails({
   try {
     const commitScope = new CommitsRepository(workspace.id)
 
-    const headCommit = await commitScope
-      .getHeadCommit(project.id)
-      .then((r) => r.unwrap()!)
+    const headCommit = await commitScope.getHeadCommit(project.id)
+    if (!headCommit)
+      return Result.error(new NotFoundError('Head commit not found'))
 
     const targetCommit = targetDraftUuid
       ? await commitScope
-          .getCommitByUuid({ uuid: targetDraftUuid, projectId: project.id })
-          .then((r) => r.unwrap())
+        .getCommitByUuid({ uuid: targetDraftUuid, projectId: project.id })
+        .then((r) => r.unwrap())
       : headCommit
 
     const originalCommit = await commitScope
@@ -150,13 +151,13 @@ export async function resetProjectToCommit(
   const targetDraft = targetDraftUuid
     ? Result.ok(targetCommit)
     : await createCommit({
-        project: project,
-        user: user,
-        data: {
-          title: `Reset project to v${originalCommit.version} "${originalCommit.title}"`,
-          description: `Resetted the project to the state of commit v${originalCommit.version} "${originalCommit.title}"`,
-        },
-      })
+      project: project,
+      user: user,
+      data: {
+        title: `Reset project to v${originalCommit.version} "${originalCommit.title}"`,
+        description: `Resetted the project to the state of commit v${originalCommit.version} "${originalCommit.title}"`,
+      },
+    })
 
   if (targetDraft.error) {
     return Result.error(targetDraft.error)
diff --git a/packages/core/src/services/history/revertCommit.ts b/packages/core/src/services/history/revertCommit.ts
diff --git a/packages/core/src/services/history/revertDocumentVersion.ts b/packages/core/src/services/history/revertDocumentVersion.ts
diff --git a/packages/core/src/services/publishedDocuments/create.ts b/packages/core/src/services/publishedDocuments/create.ts
diff --git a/packages/core/src/services/publishedDocuments/findSharedDocument.ts b/packages/core/src/services/publishedDocuments/findSharedDocument.ts

Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,7 @@ async function resolveWorkspaceAndCommit(`
`43`	`43`	`return Result.ok({ workspace, commit })`
`44`	`44`	`}`
`45`	`45`
`46`		`- const headCommitResult = await commitsRepo.getHeadCommit(rawTrigger.projectId)`
`47`		`- const commit = headCommitResult.unwrap()`
	`46`	`+ const commit = await commitsRepo.getHeadCommit(rawTrigger.projectId)`
`48`	`47`	`if (!commit) {`
`49`	`48`	`return Result.error(`
`50`	`49`	`new NotFoundError(`
Original file line number	Diff line number	Diff line change
`@@ -179,8 +179,7 @@ export const getHeadCommitCached = cache(`
`179`	`179`	`projectId: number`
`180`	`180`	`}) => {`
`181`	`181`	`const commitsScope = new CommitsRepository(workspace.id)`
`182`		`- const headCommitResult = await commitsScope.getHeadCommit(projectId)`
`183`		`- return headCommitResult.value`
	`182`	`+ return await commitsScope.getHeadCommit(projectId)`
`184`	`183`	`},`
`185`	`184`	`)`
`186`	`185`
Original file line number	Diff line number	Diff line change
`@@ -71,12 +71,9 @@ export class CommitsRepository extends RepositoryLegacy<`
`71`	`71`	`return Result.error(new NotFoundError('Project ID is required'))`
`72`	`72`	`}`
`73`	`73`
`74`		`- const headCommit = await this.getHeadCommit(projectId).then((r) =>`
`75`		`- r.unwrap(),`
`76`		`- )`
`77`		`- if (!headCommit) {`
	`74`	`+ const headCommit = await this.getHeadCommit(projectId)`
	`75`	`+ if (!headCommit)`
`78`	`76`	`return Result.error(new NotFoundError('Head commit not found'))`
`79`		`- }`
`80`	`77`
`81`	`78`	`return Result.ok(headCommit)`
`82`	`79`	`}`
Original file line number	Diff line number	Diff line change
`@@ -2,8 +2,8 @@ import { and, desc, eq, isNotNull } from 'drizzle-orm'`
`2`	`2`
`3`	`3`	`import { database } from '../../../client'`
`4`	`4`	`import { InferedReturnType } from '../../../lib/commonTypes'`
`5`		`-import { Result } from '../../../lib/Result'`
`6`	`5`	`import { buildCommitsScope } from './buildCommitsScope'`
	`6`	`+import { Commit } from '../../../browser'`
`7`	`7`
`8`	`8`	`export async function getHeadCommitForProject(`
`9`	`9`	`{`
`@@ -27,5 +27,5 @@ export async function getHeadCommitForProject(`
`27`	`27`	`.orderBy(desc(commitsScope.mergedAt))`
`28`	`28`	`.limit(1)`
`29`	`29`
`30`		`- return Result.ok(result[0])`
	`30`	`+ return result[0] as Commit \| undefined`
`31`	`31`	`}`