Version 2.13.1 (#138)

* Removed early tests for reaching event capacity that caused benign Thread Sanitizer warnings
* Changed pointer nil tests to clear Static Analyzer pointer comparison warnings

Author: markpokornycos

CHANGELOG.md

@@ -2,6 +2,11 @@
 
 All notable changes to the LaunchDarkly iOS SDK will be documented in this file. This project adheres to [Semantic Versioning](http://semver.org).
 
+## [2.13.1] - 2018-06-25
+### Changed
+- Removed early tests for reaching event capacity that caused benign Thread Sanitizer warnings
+- Changed pointer nil tests to clear Static Analyzer pointer comparison warnings
+
 ## [2.13.0] - 2018-06-01
 ### Added
 - To reduce the network bandwidth used for analytics events, feature request events are now sent as counters rather than individual events, and user details are now sent only at intervals rather than in each event. These behaviors can be modified through the LaunchDarkly UI and with the new configuration option `inlineUsersInEvents`. For more details, see [Analytics Data Stream Reference](https://docs.launchdarkly.com/v2.0/docs/analytics-data-stream-reference).

Cartfile

@@ -1 +1 @@
-github "launchdarkly/ios-eventsource" >= 3.2.3
+github "launchdarkly/ios-eventsource" >= 3.2.5

Cartfile.resolved

@@ -1 +1 @@
-github "launchdarkly/ios-eventsource" "3.2.3"
+github "launchdarkly/ios-eventsource" "3.2.5"

Darkly/DarklyConstants.m

@@ -4,7 +4,7 @@
 
 #import "DarklyConstants.h"
 
-NSString * const kClientVersion = @"2.13.0";
+NSString * const kClientVersion = @"2.13.1";
 NSString * const kBaseUrl = @"https://app.launchdarkly.com";
 NSString * const kEventsUrl = @"https://mobile.launchdarkly.com";
 NSString * const kStreamUrl = @"https://clientstream.launchdarkly.com";

Darkly/LDDataManager.m

@@ -168,10 +168,6 @@ -(void)createFeatureEventWithFlagKey:(NSString*)flagKey
                     defaultFlagValue:(id)defaultFlagValue
                                 user:(LDUserModel*)user
                               config:(LDConfig*)config {
-    if ([self isAtEventCapacity:self.eventsArray]) {
-        DEBUG_LOG(@"Events have surpassed capacity. Discarding feature event %@", flagKey);
-        return;
-    }
     if (!flagConfigValue.eventTrackingContext || (flagConfigValue.eventTrackingContext && !flagConfigValue.eventTrackingContext.trackEvents)) {
         DEBUG_LOG(@"Tracking is off. Discarding feature event %@", flagKey);
         return;
@@ -187,28 +183,16 @@ -(void)createFeatureEventWithFlagKey:(NSString*)flagKey
 }
 
 -(void)createCustomEventWithKey:(NSString *)eventKey customData:(NSDictionary *)customData user:(LDUserModel*)user config:(LDConfig*)config {
-    if ([self isAtEventCapacity:self.eventsArray]) {
-        DEBUG_LOG(@"Events have surpassed capacity. Discarding custom event %@ with customData %@", eventKey, customData);
-        return;
-    }
     DEBUG_LOG(@"Creating custom event for custom key:%@ and customData:%@", eventKey, customData);
     [self addEventDictionary:[[LDEventModel customEventWithKey:eventKey customData:customData userValue:user inlineUser:config.inlineUserInEvents] dictionaryValueUsingConfig:config]];
 }
 
 -(void)createIdentifyEventWithUser:(LDUserModel*)user config:(LDConfig*)config {
-    if ([self isAtEventCapacity:self.eventsArray]) {
-        DEBUG_LOG(@"Events have surpassed capacity. Discarding identify event for user key:%@", user.key);
-        return;
-    }
     DEBUG_LOG(@"Creating identify event for user key:%@", user.key);
     [self addEventDictionary:[[LDEventModel identifyEventWithUser:user] dictionaryValueUsingConfig:config]];
 }
 
 -(void)createSummaryEventWithTracker:(LDFlagConfigTracker*)tracker config:(LDConfig*)config {
-    if ([self isAtEventCapacity:self.eventsArray]) {
-        DEBUG_LOGX(@"Events have surpassed capacity. Discarding summary event.");
-        return;
-    }
     if (tracker.flagCounters.count == 0) {
         DEBUG_LOGX(@"Tracker has no flag counters. Discarding summary event.");
         return;
@@ -223,10 +207,6 @@ -(void)createDebugEventWithFlagKey:(NSString *)flagKey
                   defaultFlagValue:(id)defaultFlagValue
                               user:(LDUserModel*)user
                             config:(LDConfig*)config {
-    if ([self isAtEventCapacity:self.eventsArray]) {
-        DEBUG_LOG(@"Events have surpassed capacity. Discarding debug event %@", flagKey);
-        return;
-    }
     if (![self shouldCreateDebugEventForContext:flagConfigValue.eventTrackingContext lastEventResponseDate:self.lastEventResponseDate]) {
         DEBUG_LOG(@"LDDataManager createDebugEventWithFlagKey aborting, debug events are turned off. Discarding debug event %@", flagKey);
         return;

Darkly/LDFlagConfig/LDFlagConfigValue.m

@@ -78,7 +78,7 @@ -(NSDictionary*)dictionaryValueUseFlagVersionForVersion:(BOOL)useFlagVersion inc
     if (self.modelVersion != kLDFlagConfigValueItemDoesNotExist) {
         dictionaryValue[kLDFlagConfigValueKeyVersion] = @(self.modelVersion);
     }
-    if (self.flagVersion) {
+    if (self.flagVersion != nil) {
         NSString *versionKey = useFlagVersion ? kLDFlagConfigValueKeyVersion : kLDFlagConfigValueKeyFlagVersion;
         dictionaryValue[versionKey] = self.flagVersion;
     }
@@ -150,6 +150,6 @@ -(BOOL)hasPropertiesMatchingDictionary:(NSDictionary*)dictionary {
 }
 
 -(NSString*)description {
-    return [NSString stringWithFormat:@"<LDFlagConfigValue: %p, value: %@, modelVersion: %ld, variation: %ld, flagVersion: %@, eventTrackingContext: %@>", self, [self.value description], (long)self.modelVersion, (long)self.variation, self.flagVersion ? [self.flagVersion description] : @"nil", self.eventTrackingContext ?: @"nil"];
+    return [NSString stringWithFormat:@"<LDFlagConfigValue: %p, value: %@, modelVersion: %ld, variation: %ld, flagVersion: %@, eventTrackingContext: %@>", self, [self.value description], (long)self.modelVersion, (long)self.variation, self.flagVersion != nil ? [self.flagVersion description] : @"nil", self.eventTrackingContext ?: @"nil"];
 }
 @end

LaunchDarkly.podspec

@@ -1,7 +1,7 @@
 Pod::Spec.new do |s|
 
   s.name         = "LaunchDarkly"
-  s.version      = "2.13.0"
+  s.version      = "2.13.1"
   s.summary      = "iOS SDK for LaunchDarkly"
 
   s.description  = <<-DESC
@@ -23,7 +23,7 @@ Pod::Spec.new do |s|
   s.tvos.deployment_target    = "9.0"
   s.osx.deployment_target     = '10.10'
 
-  s.source       = { :git => "https://github.com/launchdarkly/ios-client.git", :tag => "2.13.0" }
+  s.source       = { :git => "https://github.com/launchdarkly/ios-client.git", :tag => "2.13.1" }
 
   s.source_files  = 'Darkly/**/*.{h,m}'
 
@@ -32,6 +32,6 @@ Pod::Spec.new do |s|
   s.xcconfig	= { 'CLANG_WARN_DEPRECATED_OBJC_IMPLEMENTATIONS' => 'NO' }
 
   s.subspec 'Core' do |eventSource|
-    eventSource.dependency 'DarklyEventSource', '~>3.2.4'
+    eventSource.dependency 'DarklyEventSource', '~>3.2.5'
   end
 end

Podfile

@@ -1,22 +1,22 @@
 use_frameworks!
 target 'Darkly_iOS' do
     platform :ios, '8.0'
-    pod 'DarklyEventSource', '~> 3.2.4'
+    pod 'DarklyEventSource', '~> 3.2.5'
 end
 
 target 'Darkly_tvOS' do
     platform :tvos, '9.0'
-    pod 'DarklyEventSource', '~> 3.2.4'
+    pod 'DarklyEventSource', '~> 3.2.5'
 end
 
 target 'Darkly_watchOS' do
     platform :watchos, '2.0'
-    pod 'DarklyEventSource', '~> 3.2.4'
+    pod 'DarklyEventSource', '~> 3.2.5'
 end
 
 target 'Darkly_osx' do
     platform :osx, '10.10'
-    pod 'DarklyEventSource', '~> 3.2.4'
+    pod 'DarklyEventSource', '~> 3.2.5'
 end
 
 target 'DarklyTests' do

Podfile.lock

@@ -1,5 +1,5 @@
 PODS:
-  - DarklyEventSource (3.2.4)
+  - DarklyEventSource (3.2.5)
   - OCMock (3.4.1)
   - OHHTTPStubs (4.8.0):
     - OHHTTPStubs/Default (= 4.8.0)
@@ -16,15 +16,15 @@ PODS:
   - OHHTTPStubs/OHPathHelpers (4.8.0)
 
 DEPENDENCIES:
-  - DarklyEventSource (~> 3.2.4)
+  - DarklyEventSource (~> 3.2.5)
   - OCMock (~> 3.1)
   - OHHTTPStubs (~> 4.2)
 
 SPEC CHECKSUMS:
-  DarklyEventSource: 82340541afe6251d11767eb6f3ce53f4257729ba
+  DarklyEventSource: 3c31d126137713d61b92ab05923ca0c09c4033a6
   OCMock: 2cd0716969bab32a2283ff3a46fd26a8c8b4c5e3
   OHHTTPStubs: b393565822317305b87a1440d4c7aff131679f66
 
-PODFILE CHECKSUM: 464d91876b1e18746c3732341dc0518520c165f3
+PODFILE CHECKSUM: 18a66b3a27725c10fefbd197e97fb666f2797d2e
 
 COCOAPODS: 1.4.0