Merge pull request #29 from lfoppiano/fix/infinite-execution-of-onUpdated-method

Fix infinite execution of on updated method

Author: lfoppiano

README.md

@@ -53,7 +53,7 @@ In the following table the list of parameters that can be provided to the `pdf_v
 First, make sure that _RELEASE = False in `streamlit_pdf_viewer/__init__.py`. To run the component in development mode, use the following commands:
 
 ```shell
-streamlit run my_component/__init__.py
+streamlit run streamlit_pdf_viewer/__init__.py
 
 cd frontend
 npm run serve

streamlit_pdf_viewer/frontend/src/PdfViewer.vue

@@ -22,7 +22,7 @@
 </template>
 
 <script>
-import {onMounted, onUpdated, computed, ref} from "vue";
+import { onMounted, onUpdated, computed, ref} from "vue";
 import "pdfjs-dist/build/pdf.worker.entry";
 import {getDocument} from "pdfjs-dist/build/pdf";
 import {Streamlit} from "streamlit-component-lib";
@@ -42,7 +42,7 @@ export default {
       if (isRenderingAllPages) {
         return props.args.annotations;
       }
-      const filteredAnnotations = props.args.annotations.filter(anno =>{
+      const filteredAnnotations = props.args.annotations.filter(anno => {
         return props.args.pages_to_render.includes(Number(anno.page))
       })
       return filteredAnnotations;
@@ -167,7 +167,7 @@ export default {
 
     const setFrameHeight = () => {
       Streamlit.setFrameHeight(props.args.height || totalHeight.value);
-      Streamlit.setComponentReady();
+      // Streamlit.setComponentReady();
     };
 
     onMounted(() => {
@@ -178,7 +178,10 @@ export default {
       setFrameHeight();
     });
 
-    onUpdated(setFrameHeight);
+    onUpdated(() => {
+      setFrameHeight();
+    });
+
 
     return {
       filteredAnnotations,