Skip to content

use ScriptCompiler.compile instead of Script.compile #884

Closed
@krichprollsch

Description

@krichprollsch

Instead of using Script.compile from a v8 string, we could use ScriptCompiler.compile.

ScriptCompiler.compile takes a Source argument or a StreamdeSource.

Using a StreamedSource let us the option to implement the ExternalSourceStream. It could be interested to inject the stream result directly into the compiler instead of fetching the whole source.

The modules are already using a ScriptCompiler.

Defining the Source allow us to inject CachedData.

The CachedData is produced via ScriptCompiler.CreateCodeCached from UboundedScript or UboundModuleScript.
Both are from script.GetUnboundScript or module.GetUnboundModuleScript.

Relate with lightpanda-io/zig-js-runtime#263 and #319

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions