Fix filtering on tags for nodebalancers (#2167)

Author: yec-akamai

linode/nbs/datasource_test.go

@@ -62,6 +62,14 @@ func TestAccDataSourceNodeBalancers_basic(t *testing.T) {
 					resource.TestCheckResourceAttr(resourceName, "nodebalancers.#", "0"),
 				),
 			},
+			{
+				Config: tmpl.DataFilterTags(t, nbLabel, nbRegion),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr(resourceName, "nodebalancers.#", "1"),
+					resource.TestCheckResourceAttr(resourceName, "nodebalancers.0.region", nbRegion),
+					acceptance.CheckListContains(resourceName, "nodebalancers.0.tags", "tf_test_2"),
+				),
+			},
 			{
 				Config: tmpl.DataOrder(t, nbLabel, nbRegion),
 				Check: resource.ComposeTestCheckFunc(

linode/nbs/framework_schema_datasource.go

@@ -8,10 +8,12 @@ import (
 
 var filterConfig = frameworkfilter.Config{
 	"label":  {APIFilterable: true, TypeFunc: frameworkfilter.FilterTypeString},
-	"tags":   {APIFilterable: true, TypeFunc: frameworkfilter.FilterTypeString},
 	"ipv4":   {APIFilterable: true, TypeFunc: frameworkfilter.FilterTypeString},
 	"region": {APIFilterable: true, TypeFunc: frameworkfilter.FilterTypeString},
 
+	// temporarily use client-side filter while API filter for tags is not working properly
+	"tags": {APIFilterable: false, TypeFunc: frameworkfilter.FilterTypeString},
+
 	"hostname":             {APIFilterable: false, TypeFunc: frameworkfilter.FilterTypeString},
 	"ipv6":                 {APIFilterable: false, TypeFunc: frameworkfilter.FilterTypeString},
 	"client_conn_throttle": {APIFilterable: false, TypeFunc: frameworkfilter.FilterTypeInt},

linode/nbs/tmpl/data_filter_tags.gotf

@@ -0,0 +1,16 @@
+{{ define "nbs_data_filter_tags" }}
+
+{{ template "nbs_data_base" . }}
+
+data "linode_nodebalancers" "nbs" {
+    filter {
+        name   = "tags"
+        values = ["tf_test_2"]
+    }
+    filter {
+        name = "region"
+        values = ["{{.Region}}"]
+    }
+}
+
+{{ end }}

linode/nbs/tmpl/template.go

@@ -42,3 +42,11 @@ func DataOrder(t testing.TB, label, region string) string {
 			Region: region,
 		})
 }
+
+func DataFilterTags(t testing.TB, label, region string) string {
+	return acceptance.ExecuteTemplate(t,
+		"nbs_data_filter_tags", TemplateData{
+			Label:  label,
+			Region: region,
+		})
+}