Fixed bug which causes this._panelZoneSizes is null error when toggling panel edit mode when these applets were removed from a panel and that panel was removed. (#13034)

Applets were still listening for panel-edit-mode changed signal and not garbage collected.

Author: samw-26

files/usr/share/cinnamon/applets/notifications@cinnamon.org/applet.js

@@ -38,7 +38,7 @@ class CinnamonNotificationsApplet extends Applet.TextIconApplet {
 
         // Events
         Main.messageTray.connect('notify-applet-update', Lang.bind(this, this._notification_added));
-        global.settings.connect('changed::' + PANEL_EDIT_MODE_KEY, Lang.bind(this, this._on_panel_edit_mode_changed));
+        this.panelEditModeHandler = global.settings.connect('changed::' + PANEL_EDIT_MODE_KEY, Lang.bind(this, this._on_panel_edit_mode_changed));
 
         // States
         this._blinking = false;
@@ -53,6 +53,7 @@ class CinnamonNotificationsApplet extends Applet.TextIconApplet {
     on_applet_removed_from_panel () {
         Main.keybindingManager.removeHotKey("notification-open-" + this.instance_id);
         Main.keybindingManager.removeHotKey("notification-clear-" + this.instance_id);
+        global.settings.disconnect(this.panelEditModeHandler);
     }
 
     _openMenu() {

files/usr/share/cinnamon/applets/printers@cinnamon.org/applet.js

@@ -30,7 +30,7 @@ class CinnamonPrintersApplet extends Applet.TextIconApplet {
         this.settings = new Settings.AppletSettings(this, metadata.uuid, instance_id);
         this.settings.bind('show-icon', 'show_icon', this.update);
 
-        global.settings.connect('changed::' + PANEL_EDIT_MODE_KEY, Lang.bind(this, this._on_panel_edit_mode_changed));
+        this.panelEditModeHandler = global.settings.connect('changed::' + PANEL_EDIT_MODE_KEY, Lang.bind(this, this._on_panel_edit_mode_changed));
 
         this.jobsCount = 0;
         this.printersCount = 0;
@@ -56,6 +56,7 @@ class CinnamonPrintersApplet extends Applet.TextIconApplet {
 
     on_applet_removed_from_panel() {
         this.settings.finalize();
+        global.settings.disconnect(this.panelEditModeHandler);
     }
 
     _on_panel_edit_mode_changed () {