Skip to content

Commit 7fe9ef9

Browse files
committed
[Theme] Added missing Shape Attributes to Dialog themes
PiperOrigin-RevId: 789801786
1 parent 8c02325 commit 7fe9ef9

File tree

2 files changed

+47
-0
lines changed

2 files changed

+47
-0
lines changed

lib/java/com/google/android/material/dialog/res/values/themes_base.xml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -395,11 +395,22 @@
395395

396396
<!-- Shape attributes. -->
397397
<item name="shapeCornerFamily">@integer/m3_sys_shape_corner_full_corner_family</item>
398+
<item name="shapeCornerSizeExtraSmall">@dimen/m3_sys_shape_corner_value_extra_small</item>
399+
<item name="shapeCornerSizeSmall">@dimen/m3_sys_shape_corner_value_small</item>
400+
<item name="shapeCornerSizeMedium">@dimen/m3_sys_shape_corner_value_medium</item>
401+
<item name="shapeCornerSizeLarge">@dimen/m3_sys_shape_corner_value_large</item>
402+
<item name="shapeCornerSizeLargeIncreased">@dimen/m3_sys_shape_corner_value_large_increased</item>
403+
<item name="shapeCornerSizeExtraLarge">@dimen/m3_sys_shape_corner_value_extra_large</item>
404+
<item name="shapeCornerSizeExtraLargeIncreased">@dimen/m3_sys_shape_corner_value_extra_large_increased</item>
405+
<item name="shapeCornerSizeExtraExtraLarge">@dimen/m3_sys_shape_corner_value_extra_extra_large</item>
398406
<item name="shapeAppearanceCornerExtraSmall">@style/ShapeAppearance.Material3.Corner.ExtraSmall</item>
399407
<item name="shapeAppearanceCornerSmall">@style/ShapeAppearance.Material3.Corner.Small</item>
400408
<item name="shapeAppearanceCornerMedium">@style/ShapeAppearance.Material3.Corner.Medium</item>
401409
<item name="shapeAppearanceCornerLarge">@style/ShapeAppearance.Material3.Corner.Large</item>
410+
<item name="shapeAppearanceCornerLargeIncreased">@style/ShapeAppearance.Material3.Corner.LargeIncreased</item>
402411
<item name="shapeAppearanceCornerExtraLarge">@style/ShapeAppearance.Material3.Corner.ExtraLarge</item>
412+
<item name="shapeAppearanceCornerExtraLargeIncreased">@style/ShapeAppearance.Material3.Corner.ExtraLargeIncreased</item>
413+
<item name="shapeAppearanceCornerExtraExtraLarge">@style/ShapeAppearance.Material3.Corner.ExtraExtraLarge</item>
403414

404415
<!-- Deprecated shape styles. -->
405416
<item name="shapeAppearanceSmallComponent">@style/ShapeAppearance.Material3.SmallComponent</item>
@@ -697,11 +708,22 @@
697708

698709
<!-- Shape attributes. -->
699710
<item name="shapeCornerFamily">@integer/m3_sys_shape_corner_full_corner_family</item>
711+
<item name="shapeCornerSizeExtraSmall">@dimen/m3_sys_shape_corner_value_extra_small</item>
712+
<item name="shapeCornerSizeSmall">@dimen/m3_sys_shape_corner_value_small</item>
713+
<item name="shapeCornerSizeMedium">@dimen/m3_sys_shape_corner_value_medium</item>
714+
<item name="shapeCornerSizeLarge">@dimen/m3_sys_shape_corner_value_large</item>
715+
<item name="shapeCornerSizeLargeIncreased">@dimen/m3_sys_shape_corner_value_large_increased</item>
716+
<item name="shapeCornerSizeExtraLarge">@dimen/m3_sys_shape_corner_value_extra_large</item>
717+
<item name="shapeCornerSizeExtraLargeIncreased">@dimen/m3_sys_shape_corner_value_extra_large_increased</item>
718+
<item name="shapeCornerSizeExtraExtraLarge">@dimen/m3_sys_shape_corner_value_extra_extra_large</item>
700719
<item name="shapeAppearanceCornerExtraSmall">@style/ShapeAppearance.Material3.Corner.ExtraSmall</item>
701720
<item name="shapeAppearanceCornerSmall">@style/ShapeAppearance.Material3.Corner.Small</item>
702721
<item name="shapeAppearanceCornerMedium">@style/ShapeAppearance.Material3.Corner.Medium</item>
703722
<item name="shapeAppearanceCornerLarge">@style/ShapeAppearance.Material3.Corner.Large</item>
723+
<item name="shapeAppearanceCornerLargeIncreased">@style/ShapeAppearance.Material3.Corner.LargeIncreased</item>
704724
<item name="shapeAppearanceCornerExtraLarge">@style/ShapeAppearance.Material3.Corner.ExtraLarge</item>
725+
<item name="shapeAppearanceCornerExtraLargeIncreased">@style/ShapeAppearance.Material3.Corner.ExtraLargeIncreased</item>
726+
<item name="shapeAppearanceCornerExtraExtraLarge">@style/ShapeAppearance.Material3.Corner.ExtraExtraLarge</item>
705727

706728
<!-- Deprecated shape styles. -->
707729
<item name="shapeAppearanceSmallComponent">@style/ShapeAppearance.Material3.SmallComponent</item>

lib/javatests/com/google/android/material/theme/ThemeTest.java

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -476,6 +476,26 @@ public class ThemeTest {
476476
R.attr.toolbarStyle,
477477
R.attr.toolbarSurfaceStyle);
478478

479+
/** These are shape styles that should be the same for *all* M3 full themes. */
480+
private static final ImmutableList<Integer> M3_SHAPE_ATTRIBUTES =
481+
ImmutableList.of(
482+
R.attr.shapeCornerFamily,
483+
R.attr.shapeCornerSizeExtraSmall,
484+
R.attr.shapeCornerSizeSmall,
485+
R.attr.shapeCornerSizeMedium,
486+
R.attr.shapeCornerSizeLarge,
487+
R.attr.shapeCornerSizeLargeIncreased,
488+
R.attr.shapeCornerSizeExtraExtraLarge,
489+
R.attr.shapeCornerSizeExtraLargeIncreased,
490+
R.attr.shapeCornerSizeExtraExtraLarge,
491+
R.attr.shapeAppearanceCornerExtraSmall,
492+
R.attr.shapeAppearanceCornerSmall,
493+
R.attr.shapeAppearanceCornerMedium,
494+
R.attr.shapeAppearanceCornerLarge,
495+
R.attr.shapeAppearanceCornerLargeIncreased,
496+
R.attr.shapeAppearanceCornerExtraLarge,
497+
R.attr.shapeAppearanceCornerExtraLargeIncreased);
498+
479499
/**
480500
* These are all the attributes where full themes should match {@code Theme.Material3.Light} or
481501
* {@code Theme_Material3_Dark}.
@@ -486,6 +506,7 @@ public class ThemeTest {
486506
.addAll(M3_FULL_TYPOGRAPHY_ATTRIBUTES)
487507
.addAll(M3_FULL_MOTION_ATTRIBUTES)
488508
.addAll(M3_COMMON_WIDGET_STYLE_ATTRIBUTES)
509+
.addAll(M3_SHAPE_ATTRIBUTES)
489510
.build();
490511

491512
@Parameters(name = "{0}")
@@ -615,6 +636,10 @@ public static ImmutableList<Object[]> getTestData() {
615636
R.style.Theme_Material3_Dark,
616637
R.style.Theme_Material3_Light,
617638
M3_FULL_MOTION_ATTRIBUTES))
639+
// Compare M3 Light and Dark themes - they should have the same shape styles.
640+
.addAll(
641+
createTestData(
642+
R.style.Theme_Material3_Dark, R.style.Theme_Material3_Light, M3_SHAPE_ATTRIBUTES))
618643
.build();
619644
}
620645

0 commit comments

Comments
 (0)