-
Notifications
You must be signed in to change notification settings - Fork 167
Open
Labels
Description
Package
dynamic_color
Existing issue?
- I checked the existing issues
What happened?
Background color of ElevatedButton
is the same as surface color when using the plugin
Expected vs actual result:
Steps to reproduce:
- Create a Flutter application project on 3.21.0-1.0.pre.2 (beta channel)
- Add
dynamic_color: ^1.7.0
todependencies
inpubspec.yaml
- Paste code below into
main.dart
import 'package:dynamic_color/dynamic_color.dart';
import 'package:flutter/material.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return Column(
children: [
Expanded(
child: MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
colorScheme: ColorScheme.fromSeed(
seedColor: Colors.blue,
),
useMaterial3: true,
),
darkTheme: ThemeData(
colorScheme: ColorScheme.fromSeed(
seedColor: Colors.blue,
brightness: Brightness.dark,
),
useMaterial3: true,
),
themeMode: ThemeMode.system,
home: const MyHomePage(text: "ColorScheme.fromSeed"),
debugShowCheckedModeBanner: false,
),
),
Expanded(
child: DynamicColorBuilder(
builder: (light, dark) => MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
colorScheme: light ?? ColorScheme.fromSeed(
seedColor: Colors.blue,
),
useMaterial3: true,
),
darkTheme: ThemeData(
colorScheme: dark ?? ColorScheme.fromSeed(
seedColor: Colors.blue,
brightness: Brightness.dark,
),
useMaterial3: true,
),
themeMode: ThemeMode.system,
home: const MyHomePage(text: "DynamicColorBuilder"),
debugShowCheckedModeBanner: false,
),
),
)
],
);
}
}
class MyHomePage extends StatefulWidget {
const MyHomePage({super.key, required this.text});
final String text;
@override
State<MyHomePage> createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
String get text => widget.text;
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
Text(text),
ElevatedButton(
onPressed: () {},
child: const Text("Click me"),
),
],
),
),
);
}
}
- Run the app and observe the difference
Relevant log output
[✓] Flutter (Channel beta, 3.21.0-1.0.pre.2, on Arch Linux 6.8.2-arch2-1, locale en_US.UTF-8)
• Flutter version 3.21.0-1.0.pre.2 on channel beta at /data/distr/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision c398442c35 (3 weeks ago), 2024-03-12 22:26:24 -0700
• Engine revision 0d4f78c952
• Dart version 3.4.0 (build 3.4.0-190.1.beta)
• DevTools version 2.33.1
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
• Android SDK at /data/distr/android-sdk
• Platform android-VanillaIceCream, build-tools 34.0.0
• ANDROID_HOME = /data/distr/android-sdk
• Java binary at: /home/evgfilim1/.local/share/JetBrains/Toolbox/apps/android-studio/jbr/bin/java
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
• All Android licenses accepted.
[✓] Chrome - develop for the web
• CHROME_EXECUTABLE = /usr/bin/chromium
[✓] Linux toolchain - develop for Linux desktop
• clang version 17.0.6
• cmake version 3.29.0
• ninja version 1.11.1
• pkg-config version 2.1.1
[✓] Android Studio (version 2023.3)
• Android Studio at /home/evgfilim1/.local/share/JetBrains/Toolbox/apps/android-studio
• Flutter plugin version 78.4.2
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 17.0.10+0-17.0.10b1087.21-11572160)
[✓] IntelliJ IDEA Ultimate Edition (version 2023.3)
• IntelliJ at /home/evgfilim1/.local/share/JetBrains/Toolbox/apps/intellij-idea-ultimate
• Flutter plugin version 78.4.2
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
[✓] Connected device (3 available)
• Pixel 7 (mobile) • 192.168.0.2:34305 • android-arm64 • Android 14 (API 34)
• Linux (desktop) • linux • linux-x64 • Arch Linux 6.8.2-arch2-1
• Chrome (web) • chrome • web-javascript • Chromium 123.0.6312.86 Arch Linux
[✓] Network resources
• All expected network resources are available.
• No issues found!
Extra info
Bisecting flutter changes between latest known working version and latest beta, I found the commit that changed the behavior: flutter/flutter@0d8eafb
hasali19, Mosc, veloce, haashemi, TomBursch and 4 more