Skip to content

Commit c61812e

Browse files
committed
Remove labextension install of jupyterlab/server-proxy as it ships with jupyter-server-proxy's python package as of JupyterLab 3.0
1 parent 63c3d26 commit c61812e

File tree

6 files changed

+6
-12
lines changed

6 files changed

+6
-12
lines changed

matlab-vnc/Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,7 @@ ENV NOVNC_PATH=${NOVNC_PATH}
125125
# Pip install the latest version of the integration
126126
RUN curl -s https://api.github.com/repos/mathworks/jupyter-matlab-vnc-proxy/releases/latest | grep tarball_url | cut -d '"' -f 4 | xargs python -m pip install
127127

128-
# Ensure jupyter-server-proxy JupyterLab extension is installed
129-
RUN jupyter labextension install @jupyterlab/server-proxy
128+
130129

131130
# Move MATLAB resource files to the expected locations
132131
RUN export RESOURCES_LOC=$(python -c "import jupyter_matlab_vnc_proxy as pkg; print(pkg.__path__[0])")/resources \

matlab-vnc/Dockerfile.mounted

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -113,8 +113,7 @@ ENV NOVNC_PATH=${NOVNC_PATH}
113113
# Pip install the latest version of the integration
114114
RUN curl -s https://api.github.com/repos/mathworks/jupyter-matlab-vnc-proxy/releases/latest | grep tarball_url | cut -d '"' -f 4 | xargs python -m pip install
115115

116-
# Ensure jupyter-server-proxy JupyterLab extension is installed
117-
RUN jupyter labextension install @jupyterlab/server-proxy
116+
118117

119118
# Move MATLAB resource files to the expected locations
120119
RUN export RESOURCES_LOC=$(python -c "import jupyter_matlab_vnc_proxy as pkg; print(pkg.__path__[0])")/resources \

matlab/Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,7 @@ WORKDIR /home/${NB_USER}
103103
# Install integration
104104
RUN python -m pip install jupyter-matlab-proxy
105105

106-
# Ensure jupyter-server-proxy JupyterLab extension is installed
107-
RUN jupyter labextension install @jupyterlab/server-proxy
106+
108107

109108
# Make JupyterLab the default environment
110109
ENV JUPYTER_ENABLE_LAB="yes"

matlab/Dockerfile.byoi

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,7 @@ WORKDIR /home/${NB_USER}
123123
# Install integration
124124
RUN python -m pip install jupyter-matlab-proxy
125125

126-
# Ensure jupyter-server-proxy JupyterLab extension is installed
127-
RUN jupyter labextension install @jupyterlab/server-proxy
126+
128127

129128
# Make JupyterLab the default environment
130129
ENV JUPYTER_ENABLE_LAB="yes"

matlab/Dockerfile.mounted

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,7 @@ WORKDIR /home/${NB_USER}
7979
# Install integration
8080
RUN python -m pip install jupyter-matlab-proxy
8181

82-
# Ensure jupyter-server-proxy JupyterLab extension is installed
83-
RUN jupyter labextension install @jupyterlab/server-proxy
82+
8483

8584
# Make JupyterLab the default environment
8685
ENV JUPYTER_ENABLE_LAB="yes"

matlab/Dockerfile.ubuntu-22.04

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,7 @@ WORKDIR /home/${NB_USER}
9797
# Install integration
9898
RUN python -m pip install jupyter-matlab-proxy
9999

100-
# Ensure jupyter-server-proxy JupyterLab extension is installed
101-
RUN jupyter labextension install @jupyterlab/server-proxy
100+
102101

103102
# Make JupyterLab the default environment
104103
ENV JUPYTER_ENABLE_LAB="yes"

0 commit comments

Comments
 (0)