Skip to content

fix: add resize observer for parent #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: add resize observer for parent #430

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82cd8cd
fix: add ResizeObserver to handle parent size changes
htomo1122 Oct 5, 2025
090e178
fix: adjust dimensions on parent size changes to prevent overflow
htomo1122 Oct 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 54 additions & 4 deletions src/components/vue-draggable-resizable.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ export default {

parentWidth: null,
parentHeight: null,
parentResizeObserver: null,

handle: null,
enabled: this.active,
Expand Down Expand Up @@ -296,6 +297,13 @@ export default {
addEvent(document.documentElement, 'touchend touchcancel', this.deselect)

addEvent(window, 'resize', this.checkParentSize)

if (this.parent && this.$el.parentNode) {
this.parentResizeObserver = new ResizeObserver(() => {
this.checkParentSize()
})
this.parentResizeObserver.observe(this.$el.parentNode)
}
},
beforeUnmount: function () {
removeEvent(document.documentElement, 'mousedown', this.deselect)
Expand All @@ -306,6 +314,11 @@ export default {
removeEvent(document.documentElement, 'touchend touchcancel', this.deselect)

removeEvent(window, 'resize', this.checkParentSize)

if (this.parentResizeObserver) {
this.parentResizeObserver.disconnect()
this.parentResizeObserver = null
}
},

methods: {
Expand All @@ -327,10 +340,47 @@ export default {
if (this.parent) {
const [newParentWidth, newParentHeight] = this.getParentSize()

this.parentWidth = newParentWidth
this.parentHeight = newParentHeight
this.right = this.parentWidth - this.width - this.left
this.bottom = this.parentHeight - this.height - this.top
const parentWidthChanged = this.parentWidth !== newParentWidth
const parentHeightChanged = this.parentHeight !== newParentHeight

if (parentWidthChanged || parentHeightChanged) {
const oldParentWidth = this.parentWidth
const oldParentHeight = this.parentHeight

this.parentWidth = newParentWidth
this.parentHeight = newParentHeight

if (parentWidthChanged && newParentWidth < oldParentWidth) {
const overflow = (this.left + this.width) - newParentWidth
if (overflow > 0) {
this.left = Math.max(0, this.left - overflow)
const remainingOverflow = (this.left + this.width) - newParentWidth
if (remainingOverflow > 0) {
this.width = Math.max(this.minWidth, this.width - remainingOverflow)
}
}
}

if (parentHeightChanged && newParentHeight < oldParentHeight) {
const overflow = (this.top + this.height) - newParentHeight
if (overflow > 0) {
this.top = Math.max(0, this.top - overflow)
const remainingOverflow = (this.top + this.height) - newParentHeight
if (remainingOverflow > 0) {
this.height = Math.max(this.minHeight, this.height - remainingOverflow)
}
}
}

this.right = this.parentWidth - this.width - this.left
this.bottom = this.parentHeight - this.height - this.top

if (this.resizing) {
this.bounds = this.calcResizeLimits()
} else if (this.dragging) {
this.bounds = this.calcDragLimits()
}
}
}
},
getParentSize () {
Expand Down