Skip to content

Commit 81493d1

Browse files
committed
adressed review comments
1 parent c51e7c6 commit 81493d1

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ readme = "README.md"
1414
[features]
1515
# Uses gp_log_add_func instead of gp_context_set_log_func for logging (not supported on many systems)
1616
extended_logs = []
17-
test = ["libgphoto2_sys/test", "dep:tracing-subscriber"]
17+
test = ["libgphoto2_sys/test"]
1818
serde = ["dep:serde"]
1919

2020
# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
@@ -28,7 +28,7 @@ libc = "0.2"
2828
crossbeam-channel = "0.5.6"
2929
serde = { version = "1", optional = true, features = ["derive"] }
3030
tracing = "0.1.37"
31-
tracing-subscriber = { version = "0.3.17", optional = true, features = ["env-filter"] }
3231

3332
[dev-dependencies]
33+
tracing-subscriber = { version = "0.3.17", features = ["env-filter"] }
3434
insta = "1.20.0"

examples/logging.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ use tracing_subscriber::{prelude::*, EnvFilter};
22

33
pub fn setup() {
44
tracing_subscriber::registry()
5-
.with(EnvFilter::from_default_env())
65
.with(tracing_subscriber::fmt::layer())
76
.init();
87
}

src/lib.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ fn sample_context() -> Context {
4141
static INIT: Once = Once::new();
4242
INIT.call_once(|| {
4343
tracing_subscriber::registry()
44-
.with(fmt::layer())
44+
.with(fmt::layer().with_test_writer())
4545
.with(EnvFilter::from_default_env().add_directive("gphoto2=trace".parse().unwrap()))
4646
.init();
4747

0 commit comments

Comments
 (0)