- use alternate row colors by default

- code cleanup
- remove Windows 7 table legacy stuff

Author: derreisende77

src/main/java/mediathek/mac/MediathekGuiMac.kt

@@ -30,10 +30,6 @@ import kotlin.io.path.absolutePathString
 class MediathekGuiMac : MediathekGui() {
     private val powerManager = OsxPowerManager()
 
-    override fun useAlternateRowColors(): Boolean {
-        return true
-    }
-
     override fun addQuitMenuItem() {
         //using native handler instead
     }

src/main/java/mediathek/mainwindow/MediathekGui.java

@@ -338,7 +338,7 @@ protected void setupScrollBarWidth() {
      * @return true when alternating row colors should be used, false otherwise.
      */
     protected boolean useAlternateRowColors() {
-        return false;
+        return true;
     }
 
     public void setupAlternatingRowColors() {

src/main/java/mediathek/tool/table/MVTable.java

@@ -1,12 +1,10 @@
 package mediathek.tool.table;
 
-import com.sun.jna.platform.win32.VersionHelpers;
 import mediathek.config.MVConfig;
 import mediathek.gui.messages.FontSizeChangedEvent;
 import mediathek.tool.MessageBus;
 import net.engio.mbassy.listener.Handler;
 import org.apache.commons.lang3.StringUtils;
-import org.apache.commons.lang3.SystemUtils;
 import org.apache.logging.log4j.LogManager;
 import org.apache.logging.log4j.Logger;
 import org.jetbrains.annotations.NotNull;
@@ -64,8 +62,6 @@ public MVTable(int maxColumns, boolean @NotNull [] visibleColumStore,
 
         calculateRowHeight();
 
-        applyWindowsSevenTableEffects();
-
         MessageBus.getMessageBus().subscribe(this);
     }
 
@@ -75,17 +71,6 @@ private void handleFontSizeChanged(FontSizeChangedEvent e) {
         SwingUtilities.invokeLater(this::calculateRowHeight);
     }
 
-    /**
-     * Show JTable grid lines on Windows 7 only.
-     */
-    private void applyWindowsSevenTableEffects() {
-        // Windows 7 used to have grid lines therefore simulate behaviour
-        if (SystemUtils.IS_OS_WINDOWS && !VersionHelpers.IsWindows8OrGreater()) {
-            setShowHorizontalLines(true);
-            setShowVerticalLines(true);
-        }
-    }
-
     private SortKey sortKeyLesen(String s, String strSortOrder) {
         SortKey sk;
 

src/main/java/mediathek/x11/MediathekGuiX11.java

@@ -20,11 +20,6 @@ public MediathekGuiX11() {
         setupX11WindowManagerClassName();
     }
 
-    @Override
-    protected boolean useAlternateRowColors() {
-        return true;
-    }
-
     @Override
     protected void createDarkModeToggleButton() {
         // we are using a menu item here

src/main/kotlin/mediathek/windows/MediathekGuiWindows.kt

@@ -1,6 +1,5 @@
 package mediathek.windows
 
-import com.sun.jna.platform.win32.VersionHelpers
 import mediathek.mainwindow.MediathekGui
 import mediathek.tool.notification.INotificationCenter
 import mediathek.tool.notification.WinNotificationCenter
@@ -11,21 +10,13 @@ import java.io.IOException
 class MediathekGuiWindows : MediathekGui() {
     private val logger = LogManager.getLogger()
 
-    override fun useAlternateRowColors(): Boolean {
-        return VersionHelpers.IsWindows8OrGreater()
-    }
-
     override fun createDarkModeToggleButton() {
-        //not used on Windows 10, we are creating a menu bar action here
-        if (!VersionHelpers.IsWindows10OrGreater())
-            super.createDarkModeToggleButton()
+        //not used on Windows 10+, we are creating a menu bar action here
     }
 
     override fun createMenuBar() {
         super.createMenuBar()
-        if (VersionHelpers.IsWindows10OrGreater()) {
-            createDarkModeMenuAction()
-        }
+        createDarkModeMenuAction()
     }
     override fun shutdownComputer() {
         val strShutdownCommand = arrayOf("shutdown.exe", "-s", "-t", "0")